From: Frank Rowand <frowand.list@gmail.com>
To: David Gibson <david@gibson.dropbear.id.au>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
linux-kernel@vger.kernel.org, anmar.oueja@linaro.org,
Bill Mills <bill.mills@linaro.org>,
devicetree@vger.kernel.org,
Michal Marek <michal.lkml@markovi.net>
Subject: Re: [PATCH V6 5/6] of: unittest: Create overlay_common.dtsi and testcases_common.dtsi
Date: Mon, 25 Jan 2021 21:18:43 -0600 [thread overview]
Message-ID: <ff39a4ff-ee73-8f70-fddb-f869f5317c6a@gmail.com> (raw)
In-Reply-To: <20210123030709.GI4400@yekko.fritz.box>
On 1/22/21 9:07 PM, David Gibson wrote:
> On Fri, Jan 22, 2021 at 04:20:35PM +0530, Viresh Kumar wrote:
>> In order to build-test the same unit-test files using fdtoverlay tool,
>> move the device nodes from the existing overlay_base.dts and
>> testcases_common.dts files to .dtsi files. The .dts files now include
>> the new .dtsi files, resulting in exactly the same behavior as earlier.
>>
>> The .dtsi files can now be reused for compile time tests using
>> fdtoverlay (will be done in a later patch).
>>
>> This is required because the base files passed to fdtoverlay tool
>> shouldn't be overlays themselves (i.e. shouldn't have the /plugin/;
>> tag).
>>
>> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>> ---
>> drivers/of/unittest-data/overlay_base.dts | 90 +-----------------
>> drivers/of/unittest-data/overlay_common.dtsi | 91 +++++++++++++++++++
>> drivers/of/unittest-data/testcases.dts | 17 +---
>> .../of/unittest-data/testcases_common.dtsi | 18 ++++
>> 4 files changed, 111 insertions(+), 105 deletions(-)
>> create mode 100644 drivers/of/unittest-data/overlay_common.dtsi
>> create mode 100644 drivers/of/unittest-data/testcases_common.dtsi
>>
>> diff --git a/drivers/of/unittest-data/overlay_base.dts b/drivers/of/unittest-data/overlay_base.dts
>> index 99ab9d12d00b..ab9014589c5d 100644
>> --- a/drivers/of/unittest-data/overlay_base.dts
>> +++ b/drivers/of/unittest-data/overlay_base.dts
>> @@ -2,92 +2,4 @@
>> /dts-v1/;
>> /plugin/;
>
> This still makes no sense to me. Is this data intended as a base
> tree, or as an overlay? If it's an overlay, what are the constraints
> on the base tree it's supposed to apply to.
I have already replied several times that this should not make sense to
anyone unless they read unittest.c and see in detail how these FDTs are
abused. I have stated several times that the usage is bizarre and not
normal.
>
> This patch is treating it as both in different places, but that's such
> a bizarre usecase it needs detailed justification. It really looks
> like the unittest stuff is doing some very bogus stuff that should be
> fixed first, before trying to do this on top.
>
The unittest stuff is bizarre, but it is correct. This patch series does
not alter the current usage.
-Frank
next prev parent reply other threads:[~2021-01-26 21:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 10:50 [PATCH V6 0/6] dt: build overlays Viresh Kumar
2021-01-22 10:50 ` [PATCH V6 1/6] scripts: dtc: Fetch fdtoverlay.c from external DTC project Viresh Kumar
2021-01-22 10:50 ` [PATCH V6 2/6] scripts: dtc: Build fdtoverlay tool Viresh Kumar
2021-01-23 0:35 ` David Gibson
2021-01-25 3:15 ` Viresh Kumar
2021-01-29 6:03 ` Frank Rowand
2021-01-29 6:11 ` Viresh Kumar
2021-01-22 10:50 ` [PATCH V6 3/6] scripts: dtc: Remove the unused fdtdump.c file Viresh Kumar
2021-01-22 10:50 ` [PATCH V6 4/6] kbuild: Add support to build overlays (%.dtbo) Viresh Kumar
2021-01-22 11:12 ` Masahiro Yamada
2021-01-22 10:50 ` [PATCH V6 5/6] of: unittest: Create overlay_common.dtsi and testcases_common.dtsi Viresh Kumar
2021-01-23 3:07 ` David Gibson
2021-01-25 3:16 ` Viresh Kumar
2021-01-26 3:18 ` Frank Rowand [this message]
2021-01-27 5:56 ` Viresh Kumar
2021-01-29 5:59 ` Frank Rowand
2021-01-29 6:39 ` Frank Rowand
2021-01-22 10:50 ` [PATCH V6 6/6] of: unittest: Statically apply overlays using fdtoverlay Viresh Kumar
2021-01-26 3:15 ` Frank Rowand
2021-01-26 3:21 ` Frank Rowand
2021-01-26 3:45 ` [PATCH V6 0/6] dt: build overlays Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff39a4ff-ee73-8f70-fddb-f869f5317c6a@gmail.com \
--to=frowand.list@gmail.com \
--cc=anmar.oueja@linaro.org \
--cc=bill.mills@linaro.org \
--cc=david@gibson.dropbear.id.au \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).