[PATCH] scsi: ufs: dt-bindings: exynos: add power-domains

[PATCH] scsi: ufs: dt-bindings: exynos: add power-domains

[André Draszik]

The UFS controller can be part of a power domain, so we need to allow
the relevant property 'power-domains'.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
 Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
index b4e744ebffd10aa237e01a675039f173e29c888a..a7eb7ad85a94e588473eab896e48934cd5f72313 100644
--- a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
@@ -61,6 +61,9 @@ properties:
   phy-names:
     const: ufs-phy
 
+  power-domains:
+    maxItems: 1
+
   samsung,sysreg:
     $ref: /schemas/types.yaml#/definitions/phandle-array
     items:

---
base-commit: 3b9b1f8df454caa453c7fb07689064edb2eda90a
change-id: 20251007-power-domains-scsi-ufs-dt-bindings-exynos-87d3ecbb3f4b

Best regards,
-- 
André Draszik <andre.draszik@linaro.org>

Re: [PATCH] scsi: ufs: dt-bindings: exynos: add power-domains

[Peter Griffin]

On Tue, 7 Oct 2025 at 16:56, André Draszik <andre.draszik@linaro.org> wrote:
>
> The UFS controller can be part of a power domain, so we need to allow
> the relevant property 'power-domains'.
>
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---

Reviewed-by: Peter Griffin <peter.griffin@linaro.org>

Re: [PATCH] scsi: ufs: dt-bindings: exynos: add power-domains

[Krzysztof Kozlowski]

On 08/10/2025 00:56, André Draszik wrote:
> The UFS controller can be part of a power domain, so we need to allow
> the relevant property 'power-domains'.
> 
> Signed-off-by: André Draszik <andre.draszik@linaro.org>


Indeed, confirmed on Exynos 7420.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

RE: [PATCH] scsi: ufs: dt-bindings: exynos: add power-domains

[Alim Akhtar]

> -----Original Message-----
> From: André Draszik <andre.draszik@linaro.org>
> Sent: Tuesday, October 7, 2025 9:26 PM
> To: Alim Akhtar <alim.akhtar@samsung.com>; Avri Altman
> <avri.altman@wdc.com>; Bart Van Assche <bvanassche@acm.org>; Rob
> Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>;
> Conor Dooley <conor+dt@kernel.org>
> Cc: Peter Griffin <peter.griffin@linaro.org>; Tudor Ambarus
> <tudor.ambarus@linaro.org>; Will McVicker <willmcvicker@google.com>;
> kernel-team@android.com; linux-scsi@vger.kernel.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org; André Draszik
> <andre.draszik@linaro.org>
> Subject: [PATCH] scsi: ufs: dt-bindings: exynos: add power-domains
> 
> The UFS controller can be part of a power domain, so we need to allow the
> relevant property 'power-domains'.
> 
In Exynos, power domains has a boundary at _block_ level. I assume in this
case it is BLK_HSI, which contains, multiple IPs within block, including UFS
controller. I hope you will be sending the corresponding DTS changes as well. 

> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
Feel free to add 
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

Re: [PATCH] scsi: ufs: dt-bindings: exynos: add power-domains

[André Draszik]

On Wed, 2025-10-08 at 11:05 +0530, Alim Akhtar wrote:
> 
> 
> > -----Original Message-----
> > From: André Draszik <andre.draszik@linaro.org>
> > Sent: Tuesday, October 7, 2025 9:26 PM
> > To: Alim Akhtar <alim.akhtar@samsung.com>; Avri Altman
> > <avri.altman@wdc.com>; Bart Van Assche <bvanassche@acm.org>; Rob
> > Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>;
> > Conor Dooley <conor+dt@kernel.org>
> > Cc: Peter Griffin <peter.griffin@linaro.org>; Tudor Ambarus
> > <tudor.ambarus@linaro.org>; Will McVicker <willmcvicker@google.com>;
> > kernel-team@android.com; linux-scsi@vger.kernel.org;
> > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> > samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org; André Draszik
> > <andre.draszik@linaro.org>
> > Subject: [PATCH] scsi: ufs: dt-bindings: exynos: add power-domains
> > 
> > The UFS controller can be part of a power domain, so we need to allow the
> > relevant property 'power-domains'.
> > 
> In Exynos, power domains has a boundary at _block_ level. I assume in this
> case it is BLK_HSI, which contains, multiple IPs within block, including UFS
> controller.

On gs101, there are three hsi power domains:
* hsi0 (USB)
* hsi1 (PCIe)
* hsi2 (UFS)

I have not looked at hsi1 so far.

From what I can gather, hsi2-pd affects:
* cmu_hsi2
* sysreg hsi2
* pinctrl (gpio) hsi2
* ufs
* ufs-phy
(not sure if there is more)

hsi0-pd is similar, except that there is no pinctrl (gpio) hsi0.

They're all modelled as individual nodes in DT, so we need to add the
power-domains = <>
to each of them.

> I hope you will be sending the corresponding DTS changes as well. 

Yes, of course :-)

> Feel free to add 
> Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

Thanks :-)

Cheers,
Andre'

Re: [PATCH] scsi: ufs: dt-bindings: exynos: add power-domains

[Martin K. Petersen]

André,

> The UFS controller can be part of a power domain, so we need to allow
> the relevant property 'power-domains'.

Applied to 6.19/scsi-staging, thanks!

-- 
Martin K. Petersen