From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2AFDC4332F for ; Tue, 20 Dec 2022 10:50:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229766AbiLTKuL (ORCPT ); Tue, 20 Dec 2022 05:50:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229749AbiLTKuK (ORCPT ); Tue, 20 Dec 2022 05:50:10 -0500 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12E8BAE74 for ; Tue, 20 Dec 2022 02:50:09 -0800 (PST) Received: by mail-lf1-x132.google.com with SMTP id bp15so17947267lfb.13 for ; Tue, 20 Dec 2022 02:50:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9gfcuA14rqPUTUjjsVp9VcIwRZasaVKQdRygjZ2irTU=; b=anpeRiNM7FlnxT5gtmKwEo9mEc9aOuR5M4DaPXbt9wiIelhZdcKyYLsH612lT0gdbn k4QJetrOLBEGyAF5BB/xzz09GIr8IYoOPuni7OuY50H3Je9KBocnD21s1cDJLacRSOCt HxEoPB81hUQCY/IhV7rb28/FHCgqP+9h7g/RY8Zb2N0fXTc8w+Dk6Oiro79nAhSNsI2R 5vQPplpMQBhj2Run4kIKddQzon2gMb8F20JP4rR3ynDsUph9i5Gkx5DrGM9bR658Flqu 2oOVfMSYawPY18055kSFOQ//Q6uFcPFnScZlUFTeHHAKEPW6nNpR3GzDUMIRWWa5MAjU JWXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9gfcuA14rqPUTUjjsVp9VcIwRZasaVKQdRygjZ2irTU=; b=KON6xwiqo6Un/rPiryL4uEnMHhfbV4uX7GP08UH/fOgqEgOIxOQ38w6Ndd0de7TYF4 QcD27WvWv6BOKaPOGM/76FgPzyjh1lvMK2Hs6lWq8gmCgageXSwM+DRdnChrkCSOsvOr 53sLGdVU4SDDsDhybuOFwuhx2x9a8TF8OczdIO3G3nGcf0h7IL0O9xxm/RFCWNn8TB1B kVSHMkgZ9kX7psP5Gqnk8EHWMwTdJ4kl/IsgQ7vMWRS77+8Iiy8iW2qiYkcC+kzyV93R +6kC6bRt7BQNkme5oQfA+cFFsg9zhzEZtNL75Y160aX8bS5Fj/0BhS5NKHFPpKHvEHBv lfGw== X-Gm-Message-State: AFqh2krcNi0qWae/sYu1IcHfafFouqvSFVOLGC1SAAgKHJhr6Li7a/mV MSUGchCc8U2sLoECPSFm48Cb5g== X-Google-Smtp-Source: AMrXdXuW0FVi+JBWXdCwrMCPwlIJkB9K57igjb8vvaYBBu5oPOgHP59tcGGEBi0Ow1zr3U4zP9sWhQ== X-Received: by 2002:a05:6512:308a:b0:4c0:91d0:e7bc with SMTP id z10-20020a056512308a00b004c091d0e7bcmr5642377lfd.26.1671533407452; Tue, 20 Dec 2022 02:50:07 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id m8-20020a056512358800b004b5284a92f9sm1404763lfr.208.2022.12.20.02.50.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Dec 2022 02:50:06 -0800 (PST) Message-ID: Date: Tue, 20 Dec 2022 11:50:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes Content-Language: en-US To: Bhavya Kapoor , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, kristo@kernel.org, nm@ti.com References: <20221220101249.46450-1-b-kapoor@ti.com> From: Krzysztof Kozlowski In-Reply-To: <20221220101249.46450-1-b-kapoor@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/12/2022 11:12, Bhavya Kapoor wrote: > J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes > for 8 channel ADCs for J721s2 SoC. > > Signed-off-by: Bhavya Kapoor > --- > .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++ > .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++- > 2 files changed, 55 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts > index a7aa6cf08acd..67593aa69327 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts > @@ -309,3 +309,17 @@ &mcu_mcan1 { > pinctrl-0 = <&mcu_mcan1_pins_default>; > phys = <&transceiver2>; > }; > + > +&tscadc0 { > + status = "okay"; > + adc { > + ti,adc-channels = <0 1 2 3 4 5 6 7>; > + }; > +}; > + > +&tscadc1 { > + status = "okay"; > + adc { > + ti,adc-channels = <0 1 2 3 4 5 6 7>; > + }; > +}; > \ No newline at end of file This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof