From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62A1F2AE77 for ; Wed, 24 Sep 2025 03:55:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758686106; cv=none; b=NSqeMad4CA4dTLTVVhY4+1ATNYwnFmBmA+wQG3px7r4GfHVfR3Jz+JDD1jH1ak/J+KYbxGC2x+ueV0W3YFY9/JGwZlRnedqXS5zHSnqd4YloHK4rF+vLCthLJCgANXyccjER7Sgm2IUrl96Fwn4CllzN6KcCghs9VR2ZX2iCwzo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758686106; c=relaxed/simple; bh=GLI4abl8FZ4HfkmnRdlogF0X6++XTS/tUyrTv2strik=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=e7jg/n+NufNMx3/MNnaXg6HadiQr/1BBPuUINBjMSD3BDQmwMT0YChBg1ylQH2Bn+V10OZSbPLXudT+sZQ7NLLhQuoLdsVeJzqdxYqzi6T0Xh/I8OZSBGeks7NjID54bBc3K0HN0Sl0mO36eI5UTrASjkv3fIC2qnCdqe3hgLbk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=GCN4JXvy; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="GCN4JXvy" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id E38FFC007A9; Wed, 24 Sep 2025 03:54:40 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id D3384606B6; Wed, 24 Sep 2025 03:54:57 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id EF2FD102F1886; Wed, 24 Sep 2025 05:54:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1758686096; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=g+qDq5wTJI6x9EY39D0tJB9MH6r0WcMVdVhtkKarOt0=; b=GCN4JXvy5Jr2Cc5svIW5gg1tIvUpzdNR4vXL3iilzXOvA0IDaSnXsAipk852bsHFxPGIar 8xzEeaC3wRS7xz17WwtS9be1O0lZdzovwkekvueR4jPF20QzmTvDy5Eq7nR2JGLrRuKNSg Ku8B522sIzaksIy3APEcrUHJ7wxRltQdFreb3Em9UPhhxCvlEUtSvVjcr+qiOZXaP+j8Yl IAewYMc7DqVeRLKEno1S6nCb+rdumy5n1bjCodVN71F+Mm5tjr8DpQQfvqkUvJdnPQmJIq y4ltufGnQ4H3zsCCGOJOSY/k69w417eWj3go6jOn9ibxoz7FxppNR2aVFDu9SA== Message-ID: Date: Wed, 24 Sep 2025 09:23:55 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v13 13/18] net: phy: marvell10g: Support SFP through phy_port To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?Q?K=C3=B6ry_Maincent?= , =?UTF-8?Q?Marek_Beh=C3=BAn?= , Oleksij Rempel , =?UTF-8?Q?Nicol=C3=B2_Veronese?= , Simon Horman , mwojtas@chromium.org, Antoine Tenart , devicetree@vger.kernel.org, Conor Dooley , Krzysztof Kozlowski , Rob Herring , Romain Gantois , Daniel Golle , Dimitri Fedrau , Florian Fainelli References: <20250921160419.333427-1-maxime.chevallier@bootlin.com> <20250921160419.333427-14-maxime.chevallier@bootlin.com> <20250923182429.697b149b@kernel.org> From: Maxime Chevallier Content-Language: en-US In-Reply-To: <20250923182429.697b149b@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 24/09/2025 06:54, Jakub Kicinski wrote: > On Sun, 21 Sep 2025 21:34:11 +0530 Maxime Chevallier wrote: >> +/** >> + * phy_port_restrict_mediums - Mask away some of the port's supported mediums >> + * @port: The port to act upon >> + * @mediums: A mask of mediums to support on the port >> + * >> + * This helper allows removing some mediums from a port's list of supported >> + * mediums, which occurs once we have enough information about the port to >> + * know its nature. >> + * >> + * Returns 0 if the change was donne correctly, a negative value otherwise. > > kdoc likes colons after return so: > > Returns 0 -> Return: 0 > > sorry for only providing an automated nit pick.. It's OK, the series no longer applies with Russell's sfp_module_caps series being here, so a new version is due anyway. Russell, I missed this series of yours as I wasn't available at all at that time, but as this phy_port series has been in the pipe for quite a while, and you commented on the used of sfp_parse_support et.al. that was being replaced, I'd have appreciated to be in CC :( Given my schedule, next iteration is probably going to be for the next cycle anyway so no harm :) Thanks, Maxime > >> + */ >> +int phy_port_restrict_mediums(struct phy_port *port, unsigned long mediums)