From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Pavel Hofman <pavel.hofman@ivitera.com>,
Minas Harutyunyan <hminas@synopsys.com>,
Rob Herring <robh+dt@kernel.org>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: bcm283x: increase dwc2's RX FIFO size
Date: Fri, 20 Nov 2020 17:44:45 +0100 [thread overview]
Message-ID: <ff83fd481f3de4bcfa453a837a9c516e50f93061.camel@suse.de> (raw)
In-Reply-To: <e9e7d070-593c-122f-3a5c-2435bb147ab2@ivitera.com>
[-- Attachment #1: Type: text/plain, Size: 1293 bytes --]
On Fri, 2020-11-13 at 08:18 +0100, Pavel Hofman wrote:
> The previous version of the dwc2 overlay set the RX FIFO size to
> 256 4-byte words. This is not enough for 1024 bytes of the largest
> isochronous high speed packet allowed, because it doesn't take into
> account extra space needed by dwc2.
>
> RX FIFO's size is calculated based on the following (in 4byte words):
> - 13 locations for SETUP packets
> 5*n + 8 for Slave and Buffer DMA mode where n is number of control
> endpoints which is 1 on the bcm283x core
>
> - 1 location for Global OUT NAK
>
> - 2 * 257 locations for status information and the received packet.
> Typically two spaces are recommended so that when the previous packet
> is being transferred to AHB, the USB can receive the subsequent
> packet.
>
> - 10 * 1 location for transfer complete status for last packet of each
> endpoint. The bcm283x core has 5 IN and 5 OUT EPs
>
> - 10 * 1 additional location for EPDisable status for each endpoint
>
> - 5 * 2 additional locations are recommended for each OUT endpoint
>
> Total is 558 locations.
>
> Signed-off-by: Phil Elwell <phil@raspberrypi.com>
> Signed-off-by: Pavel Hofman <pavel.hofman@ivitera.com>
> ---
Applied for next. Thanks!
Regards,
Nicolas
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-11-20 16:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 7:18 [PATCH] ARM: dts: bcm283x: increase dwc2's RX FIFO size Pavel Hofman
2020-11-20 16:44 ` Nicolas Saenz Julienne [this message]
2021-05-26 17:12 ` Stefan Wahren
2021-05-27 13:17 ` Pavel Hofman
2021-05-27 13:47 ` Stefan Wahren
2021-05-28 8:59 ` Pavel Hofman
2021-08-06 13:03 ` Pavel Hofman
2021-08-06 14:08 ` Stefan Wahren
2021-08-06 14:46 ` Pavel Hofman
2021-08-06 15:57 ` Stefan Wahren
-- strict thread matches above, loose matches on Subject: below --
2020-02-07 21:12 Pavel Hofman
2020-02-12 18:57 ` Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff83fd481f3de4bcfa453a837a9c516e50f93061.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=hminas@synopsys.com \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=pavel.hofman@ivitera.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).