From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9877A159204 for ; Wed, 29 May 2024 14:32:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716993169; cv=none; b=lpUJfJTmmLVWQ+xEexOR/VzIR3Kgudl4xU2mQlARYQa4yCswOH+OfqGkDUMJKbH4EJyi0IQ81sSU88wMoz+8pYZAFWfp+KmGp2rDP6C/A+MJpbwLiKeUuZACbInfU0mC30xBQ7g4S2Gz/YDr9sPOvcASApAuiE+6UnOh7In/TtI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716993169; c=relaxed/simple; bh=li4ZbxG2F4FGjel82rPqgESS9j5jdY8puT5M++X2kzs=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=QTxU4v/b+hFveBXvLiZCunqjRx4ONNJzUeSOjuOgDg8HZJRnwcm21CQdTVICEDHOtSocf9VU1ORdppiKqejzbUeq2dmChx6Ktos6RpR3PIMY8xN4azsKLfPAKOV5iPcm7IsiqZ2wcO2+MfqVddoXIF8PkBKdf9wo2NGlWc6Y4dI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xUIgsqKA; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xUIgsqKA" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-578517c7ae9so2671280a12.3 for ; Wed, 29 May 2024 07:32:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716993165; x=1717597965; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=GL+ZXu8YsVg8veqNeDMZZjWT6LtrFbHYU/tEpop01gE=; b=xUIgsqKA4gwS6IlCcqRCDws750HblDaRb5uS1D8m4Uv2bLD3NYQhVeIxMpg+l9IWeK 3dl3aaL0AS+1HrSJGPmeOMyzUrhawEwmg8OIvB2PgpqNta+QanLTQmtfZLD0PbUN/hzd 1nmT7xcbk9PthQ5vqGcU2H1gVdxkc6P+oVdQa8SVyJkBF2uda+1+iC0bQ5PUdVRXEgm3 X+g7lySFmZuQJvKZf62r+rARCDo2ppCkNbZMgmvxjLVP/lv/Rpb6WW3jQZSCBRdo0hVE pV3HU6TnMt06ZCMYHEdwUZNiR2adMD1p75eEeORrcQBp4OnXu8YlFPOei2vvegtd9sNV LeLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716993165; x=1717597965; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=GL+ZXu8YsVg8veqNeDMZZjWT6LtrFbHYU/tEpop01gE=; b=rAomGwM9p9Fr9K7yecmP/NuZmAfVQtxyMBD47yaIvpj2XQxc+CZYKwh17yFxCnpIIz 3PPH6GJt+WJwhHM8aTA2Bxs4OMEx69ck1q7TL5I65vk+fC0fVFtqiUnXhs4DaKCyFl1p LxWz6N3MngO7aG4PUnmrnCdOnU31goOwNJtbdvwoRx2xuB8UuovqgdIOu1Fi6vtAk5hz NR7v4cDa//vch7ysBI6zHDFz1JH25osELPk+0MX1GFh9BnvWV4TL1SPSvV8qTaazarLb ZvGHo6Kq06grZr9o1+cBebwmARFn2DJ4aXN3/bJ4+MfpXVw6i8NhA6A+8f5OR3c/ja7U vL4Q== X-Forwarded-Encrypted: i=1; AJvYcCUKGl0Hdfi1AqPvId0IfmNRf8KIoWmLMJwz2D/UpvH879KXUkk/4J1+tgmcYL5jDv+9f4eA6xBKgx23yJfp45voIbVlIEvuN+2vZg== X-Gm-Message-State: AOJu0YwLe6ACYAexYyktp0uX90RwRYKmclUSAFUk15/zzJwtttOcEcnk UmBIw0OWpnimr3/9R7ayg2VuK1ktX5drIUKlRDmh5V8+P7VG7XxwDAijroquzf8= X-Google-Smtp-Source: AGHT+IFHKZcI8vnShZhzgKqN73KpOv8IjqZ877BnV4ShkqFBb+Deu4xUihuipUqnmdso1P98gLeYAA== X-Received: by 2002:a17:906:dff9:b0:a5a:5bd3:9f0 with SMTP id a640c23a62f3a-a62641df7b1mr987106666b.24.1716993164975; Wed, 29 May 2024 07:32:44 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a626cc4f465sm717035366b.120.2024.05.29.07.32.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 07:32:44 -0700 (PDT) Date: Wed, 29 May 2024 17:32:40 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Ramona Gradinariu , linux-kernel@vger.kernel.org, jic23@kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, robh@kernel.org, nuno.sa@analog.com Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Ramona Gradinariu Subject: Re: [PATCH v5 9/9] drivers: iio: imu: Add support for adis1657x family Message-ID: Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240527142618.275897-10-ramona.bolboaca13@gmail.com> Hi Ramona, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Ramona-Gradinariu/dt-bindings-iio-imu-Add-ADIS16501-compatibles/20240527-230203 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg patch link: https://lore.kernel.org/r/20240527142618.275897-10-ramona.bolboaca13%40gmail.com patch subject: [PATCH v5 9/9] drivers: iio: imu: Add support for adis1657x family config: x86_64-randconfig-161-20240528 (https://download.01.org/0day-ci/archive/20240528/202405281539.EXGy0dhk-lkp@intel.com/config) compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202405281539.EXGy0dhk-lkp@intel.com/ smatch warnings: drivers/iio/imu/adis16475.c:1608 adis16475_push_single_sample() warn: missing error code? 'ret' vim +/ret +1608 drivers/iio/imu/adis16475.c c49e2871e50119 Ramona Gradinariu 2024-05-27 1577 static int adis16475_push_single_sample(struct iio_poll_func *pf) fff7352bf7a3ce Nuno Sá 2020-04-13 1578 { fff7352bf7a3ce Nuno Sá 2020-04-13 1579 struct iio_dev *indio_dev = pf->indio_dev; fff7352bf7a3ce Nuno Sá 2020-04-13 1580 struct adis16475 *st = iio_priv(indio_dev); fff7352bf7a3ce Nuno Sá 2020-04-13 1581 struct adis *adis = &st->adis; 8f6bc87d67c030 Ramona Bolboaca 2023-08-08 1582 int ret, bit, buff_offset = 0, i = 0; fff7352bf7a3ce Nuno Sá 2020-04-13 1583 __be16 *buffer; fff7352bf7a3ce Nuno Sá 2020-04-13 1584 u16 crc; fff7352bf7a3ce Nuno Sá 2020-04-13 1585 bool valid; 7f174ee4adeb12 Ramona Gradinariu 2024-05-27 1586 u8 crc_offset = 9; 7f174ee4adeb12 Ramona Gradinariu 2024-05-27 1587 u16 burst_size = ADIS16475_BURST_MAX_DATA; 7f174ee4adeb12 Ramona Gradinariu 2024-05-27 1588 u16 start_idx = (st->info->flags & ADIS16475_HAS_TIMESTAMP32) ? 2 : 0; 7f174ee4adeb12 Ramona Gradinariu 2024-05-27 1589 fff7352bf7a3ce Nuno Sá 2020-04-13 1590 /* offset until the first element after gyro and accel */ fff7352bf7a3ce Nuno Sá 2020-04-13 1591 const u8 offset = st->burst32 ? 13 : 7; fff7352bf7a3ce Nuno Sá 2020-04-13 1592 7f174ee4adeb12 Ramona Gradinariu 2024-05-27 1593 if (st->burst32) { 7f174ee4adeb12 Ramona Gradinariu 2024-05-27 1594 crc_offset = (st->info->flags & ADIS16475_HAS_TIMESTAMP32) ? 16 : 15; 7f174ee4adeb12 Ramona Gradinariu 2024-05-27 1595 burst_size = adis->data->burst_max_len; 7f174ee4adeb12 Ramona Gradinariu 2024-05-27 1596 } 7f174ee4adeb12 Ramona Gradinariu 2024-05-27 1597 fff7352bf7a3ce Nuno Sá 2020-04-13 1598 ret = spi_sync(adis->spi, &adis->msg); fff7352bf7a3ce Nuno Sá 2020-04-13 1599 if (ret) 7f174ee4adeb12 Ramona Gradinariu 2024-05-27 1600 return ret; fff7352bf7a3ce Nuno Sá 2020-04-13 1601 fff7352bf7a3ce Nuno Sá 2020-04-13 1602 buffer = adis->buffer; fff7352bf7a3ce Nuno Sá 2020-04-13 1603 7f174ee4adeb12 Ramona Gradinariu 2024-05-27 1604 crc = be16_to_cpu(buffer[crc_offset]); 7f174ee4adeb12 Ramona Gradinariu 2024-05-27 1605 valid = adis16475_validate_crc(adis->buffer, crc, burst_size, start_idx); fff7352bf7a3ce Nuno Sá 2020-04-13 1606 if (!valid) { fff7352bf7a3ce Nuno Sá 2020-04-13 1607 dev_err(&adis->spi->dev, "Invalid crc\n"); 7f174ee4adeb12 Ramona Gradinariu 2024-05-27 @1608 return ret; ^^^^^^^^^^ return -EINVAL fff7352bf7a3ce Nuno Sá 2020-04-13 1609 } fff7352bf7a3ce Nuno Sá 2020-04-13 1610 fff7352bf7a3ce Nuno Sá 2020-04-13 1611 for_each_set_bit(bit, indio_dev->active_scan_mask, fff7352bf7a3ce Nuno Sá 2020-04-13 1612 indio_dev->masklength) { fff7352bf7a3ce Nuno Sá 2020-04-13 1613 /* fff7352bf7a3ce Nuno Sá 2020-04-13 1614 * When burst mode is used, system flags is the first data fff7352bf7a3ce Nuno Sá 2020-04-13 1615 * channel in the sequence, but the scan index is 7. fff7352bf7a3ce Nuno Sá 2020-04-13 1616 */ -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki