From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other Date: Tue, 3 Jan 2017 09:15:29 -0300 Message-ID: References: <1483430237-26823-1-git-send-email-jcsing.lee@samsung.com> <1483430237-26823-4-git-send-email-jcsing.lee@samsung.com> <20170103095842.h3hl64amje4qv4ts@gangnam.samsung> <20170103102548.73jg6qddlcthe2mu@gangnam.samsung> <20170103115530.zhjwn7bzmqmumy23@gangnam.samsung> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170103115530.zhjwn7bzmqmumy23-8vUhnHFVuGn35fTxX1Dczw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andi Shyti , Chanwoo Choi Cc: Krzysztof Kozlowski , Jaechul Lee , Dmitry Torokhov , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Kukjin Kim , Chanwoo Choi , beomho.seo-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, galaxyra-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-arm-kernel , linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree , linux-kernel , linux-samsung-soc List-Id: devicetree@vger.kernel.org Hello Andi, On 01/03/2017 08:55 AM, Andi Shyti wrote: > Hi Chanwoo, > >>>>>>> Currently tm2e dts includes tm2 but there are some differences >>>>>>> between the two boards and tm2 has some properties that tm2e >>>>>>> doesn't have. >>>>>>> >>>>>>> That's why it's important to keep the two dts files independent >>>>>>> and put all the commonalities in a tm2-common.dtsi file. >>>>>>> >>>>>>> Signed-off-by: Andi Shyti >>>>>>> Signed-off-by: Jaechul Lee >>>>>>> --- >>>>>>> .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 1046 ++++++++++++++++++++ >>>>>>> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 1033 +------------------ >>>>>>> arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 2 +- >>>>>>> 3 files changed, 1049 insertions(+), 1032 deletions(-) >>>>>>> create mode 100644 arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >>>>>> > > [...] > >>> Because exynos5433-tm2.dts results modified, while >>> exynos5433-tm2-common.dtsi is new. Even though I did: >>> >>> 1. mv exynos5433-tm2.dts exynos5433-tm2-common.dtsi >>> 2. copied pieces from exynos5433-tm2-common.dtsi to a new >>> exynos5433-tm2.dts >> >> I think that exynos5433-tm2-common.dtsi is not necessary because there >> is small difference between TM2 and TM2E. >> >> I explain the detailed difference between TM2 and TM2E and then reply >> how to support the TM2E board with existing exynos5433-tm2.dts file >> without exynos5433-tm2-common.dtsi. >> >> Difference and the way to support TM2E with existing >> exynos5433-tm2.dts file as following: >> - hsi2c_9 is either used or not. TM2 uses the hsi2c_9 node for >> touchkey. but TM2E do not use the hsi2c_9. >> : We can just disable the hsi2c_9 node on tm2e.dts as following: >> >> &hsi2c_9 { >> status = "disable"; >> }; > > I thought about this alternative too, it just looked cleaner to > me to have a tm2-common.dtsi file. > > Anyway, as you guys wish. If for you and Krzysztof is better this > way, we can drop this patch and add the above lines in the current > Jaechul's patch 4/4. > FWIW, I also agree with Chanwoo that the difference is too small to need a common .dtsi file. > Thanks, > Andi > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html