From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Furkan Kardame <f.kardame@manjaro.org>, robh+dt@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
heiko@sntech.de, broonie@kernel.org, deller@gmx.de,
dsterba@suse.com, arnd@arndb.de, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 2/2] arm64: dts: rockchip: add dts for Firefly Station P2 aka rk3568-roc-pc
Date: Tue, 20 Jun 2023 19:17:15 +0200 [thread overview]
Message-ID: <ff9045bd-1030-b3c6-9692-e223846b0ee5@linaro.org> (raw)
In-Reply-To: <1687280004029.3690769854.982412891@manjaro.org>
On 20/06/2023 19:05, Furkan Kardame wrote:
>>
>>> + };
>>> +
>>> + hdmi-con {
>>> + compatible = "hdmi-connector";
>>> + type = "a";
>>> +
>>> + port {
>>> + hdmi_con_in: endpoint {
>>> + remote-endpoint = <&hdmi_out_con>;
>>
>> Missing indentation.
>
> I am not able to see any missing indentation in the patch.
> I did run checkpatch and did not find any such warning.
> Please advice in detail ?
remote-endpoint is a property within a node, so it cannot have same
indentation as the node.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-06-20 17:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 18:48 [PATCHv3 0/2] Add support for Firefly Station P2 aka rk3568-roc-pc Furkan Kardame
2023-06-19 18:48 ` [PATCHv3 1/2] dt-bindings: arm: rockchip: Add Firefly Station P2 Furkan Kardame
2023-06-19 20:02 ` Conor Dooley
2023-06-19 18:48 ` [PATCHv3 2/2] arm64: dts: rockchip: add dts for Firefly Station P2 aka rk3568-roc-pc Furkan Kardame
2023-06-20 6:19 ` Krzysztof Kozlowski
2023-06-20 17:05 ` Furkan Kardame
2023-06-20 17:17 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff9045bd-1030-b3c6-9692-e223846b0ee5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dsterba@suse.com \
--cc=f.kardame@manjaro.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).