Re: [PATCH 01/11] dt-bindings: crypto: qcom,ice: Require power-domain and iface clk

[Krzysztof Kozlowski <krzk@kernel.org>]

On 09/02/2026 06:43, Harshal Dev wrote:
>>>> Either I do not understand the point or you still insist on breaking a
>>>> working DTS on kernels with clk_ignore_unused, just because what
>>>> exactly? You claim it did not work, but in fact it did work. So you
>>>> claim it worked by luck, right? And what this patchset achieves? It
>>>> breaks this "work by luck" into "100% not working and broken". I do not
>>>> see how is this an improvement.
>>>>
>>>
>>> My point is something more fundamental. It worked before and it will still continue
>>> to work if:
>>> 1. We pass the 'clk_ignore_unused' flag. or,
>>> 2. If the Linux distro is overriding CONFIG_SCSI_UFS_QCOM to 'y'.
>>
>> I do not agree with this. I already commented about your driver. If you
>> do not believe me, apply your driver patch and show the test results of
>> existing working device.
>>
>>
> 
> Apologies, it seems like I failed to explain correctly what I meant.
> Here I was talking about the existing in-tree ICE driver and not about this particular DT
> binding commit. This commit, as you rightly said and I mentioned below too, breaks backward
> compatibility for existing in-tree and out-of-tree DTS.

I was also talking about existing in-tree ICE driver, not about my
commit. I do not believe anything will work fine with existing in-tree
ICE driver.

We shifted away from this binding in the discussion, imagine it does not
matter. Just look at your driver code.

Best regards,
Krzysztof