Re: [PATCH v2 1/3] dt-bindings: iio: dac: Document AD5446 and similar devices

["Nuno Sá" <noname.nuno@gmail.com>]

On Thu, 2025-10-23 at 18:08 +0100, Jonathan Cameron wrote:
> On Thu, 23 Oct 2025 14:01:37 +0300
> Nuno Sá <nuno.sa@analog.com> wrote:
> 
> > Add device tree binding documentation for the Analog Devices AD5446
> > family of Digital-to-Analog Converters and compatible devices from
> > Texas Instruments. There's both SPI and I2C interfaces and feature
> > resolutions ranging from 8-bit to 16-bit.
> > 
> > The binding covers 29 compatible devices including the AD5446 series,
> > AD5600 series, AD5620/5640/5660 variants with different voltage ranges,
> > and TI DAC081s101/DAC101s101/DAC121s101 devices.
> > 
> > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> Hi Nuno,
> 
> Thanks for filling in this missing doc.  I wonder what else is old
> enough that we still don't have docs? Guess I should check when
> I'm next bored enough (so that's not happening any time soon ;)

Yeah, wouldn't be surprised if there's some more ADI old stuff hanging around.
This caught my attention since I saw that out of tree patch adding support for a
new device (with no real reason for not being in tree).

> 
> > ---
> >  .../devicetree/bindings/iio/dac/adi,ad5446.yaml    | 138
> > +++++++++++++++++++++
> >  MAINTAINERS                                        |   8 ++
> >  2 files changed, 146 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> > b/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> > new file mode 100644
> > index 000000000000..90fc8ca053fe
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> > @@ -0,0 +1,138 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/dac/adi,ad5446.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analog Devices AD5446 and similar DACs
> > +
> > +maintainers:
> > +  - Michael Hennerich <michael.hennerich@analog.com>
> > +  - Nuno Sá <nuno.sa@analog.com>
> > +
> > +description: |
> 
> Trivial but don't need the | as hardly matters if these get formatted
> differently.

Sure.

> 
> > +  Digital to Analog Converter devices supporting both SPI and I2C
> > interfaces.
> > +  These devices feature a range of resolutions from 8-bit to 16-bit.
> 
> ...
> 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 940889b158eb..dae04c308975 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -440,6 +440,14 @@ W:	http://wiki.analog.com/AD5398
> >  W:	https://ez.analog.com/linux-software-drivers
> >  F:	drivers/regulator/ad5398.c
> >  
> > +AD5456	DAC DRIVER
> Tab seems odd here. 
> 
> Hmm. For a lot of ADI drivers we have entries that would look like
> ANALOG DEVICES INC AD5456 DAC DRIVER
> 
> Any reason for formatting it like this?

Ok, time to come clean :)

Bindings were AI generated and then I just cleaned the obvious problems (clearly
I did not payed too much attention to the boilerplate stuff - lesson learned).

- Nuno Sá

> 
> > +M:	Michael Hennerich <michael.hennerich@analog.com>
> > +M:	Nuno Sá <nuno.sa@analog.com>
> > +L:	linux-iio@vger.kernel.org
> > +S:	Supported
> > +W:	https://ez.analog.com/linux-software-drivers
> > +F:	Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> > +
> >  AD714X CAPACITANCE TOUCH SENSOR DRIVER (AD7142/3/7/8/7A)
> >  M:	Michael Hennerich <michael.hennerich@analog.com>
> >  S:	Supported
> >