* [PATCH v2 1/3] dt-bindings: iio: dac: Document AD5446 and similar devices
2025-10-23 11:01 [PATCH v2 0/3] iio: dac: ad5446: Add AD5542 to the spi id table Nuno Sá
@ 2025-10-23 11:01 ` Nuno Sá
2025-10-23 17:08 ` Jonathan Cameron
2025-10-23 18:24 ` Conor Dooley
2025-10-23 11:01 ` [PATCH v2 2/3] iio: dac: ad5456: Add missing DT compatibles Nuno Sá
2025-10-23 11:01 ` [PATCH v2 3/3] iio: dac: ad5446: Add AD5542 to the spi id table Nuno Sá
2 siblings, 2 replies; 17+ messages in thread
From: Nuno Sá @ 2025-10-23 11:01 UTC (permalink / raw)
To: Michael Hennerich, Jonathan Cameron, David Lechner,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-iio, devicetree, Nuno Sá
Add device tree binding documentation for the Analog Devices AD5446
family of Digital-to-Analog Converters and compatible devices from
Texas Instruments. There's both SPI and I2C interfaces and feature
resolutions ranging from 8-bit to 16-bit.
The binding covers 29 compatible devices including the AD5446 series,
AD5600 series, AD5620/5640/5660 variants with different voltage ranges,
and TI DAC081s101/DAC101s101/DAC121s101 devices.
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
.../devicetree/bindings/iio/dac/adi,ad5446.yaml | 138 +++++++++++++++++++++
MAINTAINERS | 8 ++
2 files changed, 146 insertions(+)
diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
new file mode 100644
index 000000000000..90fc8ca053fe
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
@@ -0,0 +1,138 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/dac/adi,ad5446.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices AD5446 and similar DACs
+
+maintainers:
+ - Michael Hennerich <michael.hennerich@analog.com>
+ - Nuno Sá <nuno.sa@analog.com>
+
+description: |
+ Digital to Analog Converter devices supporting both SPI and I2C interfaces.
+ These devices feature a range of resolutions from 8-bit to 16-bit.
+
+properties:
+ compatible:
+ oneOf:
+ - description: SPI DACs
+ enum:
+ - adi,ad5300
+ - adi,ad5310
+ - adi,ad5320
+ - adi,ad5444
+ - adi,ad5446
+ - adi,ad5450
+ - adi,ad5451
+ - adi,ad5452
+ - adi,ad5453
+ - adi,ad5512a
+ - adi,ad5541a
+ - adi,ad5542
+ - adi,ad5542a
+ - adi,ad5543
+ - adi,ad5553
+ - adi,ad5600
+ - adi,ad5601
+ - adi,ad5611
+ - adi,ad5621
+ - adi,ad5641
+ - adi,ad5620-2500
+ - adi,ad5620-1250
+ - adi,ad5640-2500
+ - adi,ad5640-1250
+ - adi,ad5660-2500
+ - adi,ad5660-1250
+ - adi,ad5662
+ - ti,dac081s101
+ - ti,dac101s101
+ - ti,dac121s101
+ - description: I2C DACs
+ enum:
+ - adi,ad5301
+ - adi,ad5311
+ - adi,ad5321
+ - adi,ad5602
+ - adi,ad5612
+ - adi,ad5622
+
+ reg:
+ maxItems: 1
+
+ vcc-supply:
+ description:
+ Reference voltage supply. If not supplied, devices with internal
+ voltage reference will use that.
+
+required:
+ - compatible
+ - reg
+
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - adi,ad5300
+ - adi,ad5310
+ - adi,ad5320
+ - adi,ad5444
+ - adi,ad5446
+ - adi,ad5450
+ - adi,ad5451
+ - adi,ad5452
+ - adi,ad5453
+ - adi,ad5512a
+ - adi,ad5541a
+ - adi,ad5542
+ - adi,ad5542a
+ - adi,ad5543
+ - adi,ad5553
+ - adi,ad5600
+ - adi,ad5601
+ - adi,ad5611
+ - adi,ad5621
+ - adi,ad5641
+ - adi,ad5620-2500
+ - adi,ad5620-1250
+ - adi,ad5640-2500
+ - adi,ad5640-1250
+ - adi,ad5660-2500
+ - adi,ad5660-1250
+ - adi,ad5662
+ - ti,dac081s101
+ - ti,dac101s101
+ - ti,dac121s101
+ then:
+ allOf:
+ - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ dac@0 {
+ compatible = "adi,ad5446";
+ reg = <0>;
+ vcc-supply = <&dac_vref>;
+ };
+ };
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ dac@42 {
+ compatible = "adi,ad5622";
+ reg = <0x42>;
+ vcc-supply = <&dac_vref>;
+ };
+ };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 940889b158eb..dae04c308975 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -440,6 +440,14 @@ W: http://wiki.analog.com/AD5398
W: https://ez.analog.com/linux-software-drivers
F: drivers/regulator/ad5398.c
+AD5456 DAC DRIVER
+M: Michael Hennerich <michael.hennerich@analog.com>
+M: Nuno Sá <nuno.sa@analog.com>
+L: linux-iio@vger.kernel.org
+S: Supported
+W: https://ez.analog.com/linux-software-drivers
+F: Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
+
AD714X CAPACITANCE TOUCH SENSOR DRIVER (AD7142/3/7/8/7A)
M: Michael Hennerich <michael.hennerich@analog.com>
S: Supported
--
2.34.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH v2 1/3] dt-bindings: iio: dac: Document AD5446 and similar devices
2025-10-23 11:01 ` [PATCH v2 1/3] dt-bindings: iio: dac: Document AD5446 and similar devices Nuno Sá
@ 2025-10-23 17:08 ` Jonathan Cameron
2025-10-27 14:48 ` Nuno Sá
2025-10-23 18:24 ` Conor Dooley
1 sibling, 1 reply; 17+ messages in thread
From: Jonathan Cameron @ 2025-10-23 17:08 UTC (permalink / raw)
To: Nuno Sá
Cc: Michael Hennerich, Jonathan Cameron, David Lechner,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-iio, devicetree
On Thu, 23 Oct 2025 14:01:37 +0300
Nuno Sá <nuno.sa@analog.com> wrote:
> Add device tree binding documentation for the Analog Devices AD5446
> family of Digital-to-Analog Converters and compatible devices from
> Texas Instruments. There's both SPI and I2C interfaces and feature
> resolutions ranging from 8-bit to 16-bit.
>
> The binding covers 29 compatible devices including the AD5446 series,
> AD5600 series, AD5620/5640/5660 variants with different voltage ranges,
> and TI DAC081s101/DAC101s101/DAC121s101 devices.
>
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Hi Nuno,
Thanks for filling in this missing doc. I wonder what else is old
enough that we still don't have docs? Guess I should check when
I'm next bored enough (so that's not happening any time soon ;)
> ---
> .../devicetree/bindings/iio/dac/adi,ad5446.yaml | 138 +++++++++++++++++++++
> MAINTAINERS | 8 ++
> 2 files changed, 146 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> new file mode 100644
> index 000000000000..90fc8ca053fe
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> @@ -0,0 +1,138 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/dac/adi,ad5446.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AD5446 and similar DACs
> +
> +maintainers:
> + - Michael Hennerich <michael.hennerich@analog.com>
> + - Nuno Sá <nuno.sa@analog.com>
> +
> +description: |
Trivial but don't need the | as hardly matters if these get formatted differently.
> + Digital to Analog Converter devices supporting both SPI and I2C interfaces.
> + These devices feature a range of resolutions from 8-bit to 16-bit.
...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 940889b158eb..dae04c308975 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -440,6 +440,14 @@ W: http://wiki.analog.com/AD5398
> W: https://ez.analog.com/linux-software-drivers
> F: drivers/regulator/ad5398.c
>
> +AD5456 DAC DRIVER
Tab seems odd here.
Hmm. For a lot of ADI drivers we have entries that would look like
ANALOG DEVICES INC AD5456 DAC DRIVER
Any reason for formatting it like this?
> +M: Michael Hennerich <michael.hennerich@analog.com>
> +M: Nuno Sá <nuno.sa@analog.com>
> +L: linux-iio@vger.kernel.org
> +S: Supported
> +W: https://ez.analog.com/linux-software-drivers
> +F: Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> +
> AD714X CAPACITANCE TOUCH SENSOR DRIVER (AD7142/3/7/8/7A)
> M: Michael Hennerich <michael.hennerich@analog.com>
> S: Supported
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: iio: dac: Document AD5446 and similar devices
2025-10-23 17:08 ` Jonathan Cameron
@ 2025-10-27 14:48 ` Nuno Sá
2025-10-27 15:01 ` Jonathan Cameron
0 siblings, 1 reply; 17+ messages in thread
From: Nuno Sá @ 2025-10-27 14:48 UTC (permalink / raw)
To: Jonathan Cameron, Nuno Sá
Cc: Michael Hennerich, Jonathan Cameron, David Lechner,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-iio, devicetree
On Thu, 2025-10-23 at 18:08 +0100, Jonathan Cameron wrote:
> On Thu, 23 Oct 2025 14:01:37 +0300
> Nuno Sá <nuno.sa@analog.com> wrote:
>
> > Add device tree binding documentation for the Analog Devices AD5446
> > family of Digital-to-Analog Converters and compatible devices from
> > Texas Instruments. There's both SPI and I2C interfaces and feature
> > resolutions ranging from 8-bit to 16-bit.
> >
> > The binding covers 29 compatible devices including the AD5446 series,
> > AD5600 series, AD5620/5640/5660 variants with different voltage ranges,
> > and TI DAC081s101/DAC101s101/DAC121s101 devices.
> >
> > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> Hi Nuno,
>
> Thanks for filling in this missing doc. I wonder what else is old
> enough that we still don't have docs? Guess I should check when
> I'm next bored enough (so that's not happening any time soon ;)
Yeah, wouldn't be surprised if there's some more ADI old stuff hanging around.
This caught my attention since I saw that out of tree patch adding support for a
new device (with no real reason for not being in tree).
>
> > ---
> > .../devicetree/bindings/iio/dac/adi,ad5446.yaml | 138
> > +++++++++++++++++++++
> > MAINTAINERS | 8 ++
> > 2 files changed, 146 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> > b/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> > new file mode 100644
> > index 000000000000..90fc8ca053fe
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> > @@ -0,0 +1,138 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/dac/adi,ad5446.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analog Devices AD5446 and similar DACs
> > +
> > +maintainers:
> > + - Michael Hennerich <michael.hennerich@analog.com>
> > + - Nuno Sá <nuno.sa@analog.com>
> > +
> > +description: |
>
> Trivial but don't need the | as hardly matters if these get formatted
> differently.
Sure.
>
> > + Digital to Analog Converter devices supporting both SPI and I2C
> > interfaces.
> > + These devices feature a range of resolutions from 8-bit to 16-bit.
>
> ...
>
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 940889b158eb..dae04c308975 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -440,6 +440,14 @@ W: http://wiki.analog.com/AD5398
> > W: https://ez.analog.com/linux-software-drivers
> > F: drivers/regulator/ad5398.c
> >
> > +AD5456 DAC DRIVER
> Tab seems odd here.
>
> Hmm. For a lot of ADI drivers we have entries that would look like
> ANALOG DEVICES INC AD5456 DAC DRIVER
>
> Any reason for formatting it like this?
Ok, time to come clean :)
Bindings were AI generated and then I just cleaned the obvious problems (clearly
I did not payed too much attention to the boilerplate stuff - lesson learned).
- Nuno Sá
>
> > +M: Michael Hennerich <michael.hennerich@analog.com>
> > +M: Nuno Sá <nuno.sa@analog.com>
> > +L: linux-iio@vger.kernel.org
> > +S: Supported
> > +W: https://ez.analog.com/linux-software-drivers
> > +F: Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> > +
> > AD714X CAPACITANCE TOUCH SENSOR DRIVER (AD7142/3/7/8/7A)
> > M: Michael Hennerich <michael.hennerich@analog.com>
> > S: Supported
> >
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: iio: dac: Document AD5446 and similar devices
2025-10-27 14:48 ` Nuno Sá
@ 2025-10-27 15:01 ` Jonathan Cameron
2025-10-30 11:30 ` Nuno Sá
0 siblings, 1 reply; 17+ messages in thread
From: Jonathan Cameron @ 2025-10-27 15:01 UTC (permalink / raw)
To: Nuno Sá
Cc: Jonathan Cameron, Nuno Sá, Michael Hennerich, David Lechner,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-iio, devicetree
On Mon, 27 Oct 2025 14:48:50 +0000
Nuno Sá <noname.nuno@gmail.com> wrote:
> On Thu, 2025-10-23 at 18:08 +0100, Jonathan Cameron wrote:
> > On Thu, 23 Oct 2025 14:01:37 +0300
> > Nuno Sá <nuno.sa@analog.com> wrote:
> >
> > > Add device tree binding documentation for the Analog Devices AD5446
> > > family of Digital-to-Analog Converters and compatible devices from
> > > Texas Instruments. There's both SPI and I2C interfaces and feature
> > > resolutions ranging from 8-bit to 16-bit.
> > >
> > > The binding covers 29 compatible devices including the AD5446 series,
> > > AD5600 series, AD5620/5640/5660 variants with different voltage ranges,
> > > and TI DAC081s101/DAC101s101/DAC121s101 devices.
> > >
> > > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > Hi Nuno,
> >
> > Thanks for filling in this missing doc. I wonder what else is old
> > enough that we still don't have docs? Guess I should check when
> > I'm next bored enough (so that's not happening any time soon ;)
>
> Yeah, wouldn't be surprised if there's some more ADI old stuff hanging around.
> This caught my attention since I saw that out of tree patch adding support for a
> new device (with no real reason for not being in tree).
>
> >
> > > ---
> > > .../devicetree/bindings/iio/dac/adi,ad5446.yaml | 138
> > > +++++++++++++++++++++
> > > MAINTAINERS | 8 ++
> > > 2 files changed, 146 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> > > b/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> > > new file mode 100644
> > > index 000000000000..90fc8ca053fe
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> > > @@ -0,0 +1,138 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/iio/dac/adi,ad5446.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Analog Devices AD5446 and similar DACs
> > > +
> > > +maintainers:
> > > + - Michael Hennerich <michael.hennerich@analog.com>
> > > + - Nuno Sá <nuno.sa@analog.com>
> > > +
> > > +description: |
> >
> > Trivial but don't need the | as hardly matters if these get formatted
> > differently.
>
> Sure.
>
> >
> > > + Digital to Analog Converter devices supporting both SPI and I2C
> > > interfaces.
> > > + These devices feature a range of resolutions from 8-bit to 16-bit.
> >
> > ...
> >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 940889b158eb..dae04c308975 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -440,6 +440,14 @@ W: http://wiki.analog.com/AD5398
> > > W: https://ez.analog.com/linux-software-drivers
> > > F: drivers/regulator/ad5398.c
> > >
> > > +AD5456 DAC DRIVER
> > Tab seems odd here.
> >
> > Hmm. For a lot of ADI drivers we have entries that would look like
> > ANALOG DEVICES INC AD5456 DAC DRIVER
> >
> > Any reason for formatting it like this?
>
> Ok, time to come clean :)
>
> Bindings were AI generated and then I just cleaned the obvious problems (clearly
> I did not payed too much attention to the boilerplate stuff - lesson learned).
I'd hold off on doing anything much with AI on kernel code for now.
A clear policy might come out of the maintainers summit in December.
If you are curious, various threads on: https://lore.kernel.org/ksummit/
DT bindings get picked up by various projects so they may have their own
policy long run.
J
>
> - Nuno Sá
>
> >
> > > +M: Michael Hennerich <michael.hennerich@analog.com>
> > > +M: Nuno Sá <nuno.sa@analog.com>
> > > +L: linux-iio@vger.kernel.org
> > > +S: Supported
> > > +W: https://ez.analog.com/linux-software-drivers
> > > +F: Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> > > +
> > > AD714X CAPACITANCE TOUCH SENSOR DRIVER (AD7142/3/7/8/7A)
> > > M: Michael Hennerich <michael.hennerich@analog.com>
> > > S: Supported
> > >
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: iio: dac: Document AD5446 and similar devices
2025-10-27 15:01 ` Jonathan Cameron
@ 2025-10-30 11:30 ` Nuno Sá
2025-11-02 12:13 ` Jonathan Cameron
0 siblings, 1 reply; 17+ messages in thread
From: Nuno Sá @ 2025-10-30 11:30 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Jonathan Cameron, Nuno Sá, Michael Hennerich, David Lechner,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-iio, devicetree
On Mon, 2025-10-27 at 15:01 +0000, Jonathan Cameron wrote:
> On Mon, 27 Oct 2025 14:48:50 +0000
> Nuno Sá <noname.nuno@gmail.com> wrote:
>
> > On Thu, 2025-10-23 at 18:08 +0100, Jonathan Cameron wrote:
> > > On Thu, 23 Oct 2025 14:01:37 +0300
> > > Nuno Sá <nuno.sa@analog.com> wrote:
> > >
> > > > Add device tree binding documentation for the Analog Devices AD5446
> > > > family of Digital-to-Analog Converters and compatible devices from
> > > > Texas Instruments. There's both SPI and I2C interfaces and feature
> > > > resolutions ranging from 8-bit to 16-bit.
> > > >
> > > > The binding covers 29 compatible devices including the AD5446 series,
> > > > AD5600 series, AD5620/5640/5660 variants with different voltage ranges,
> > > > and TI DAC081s101/DAC101s101/DAC121s101 devices.
> > > >
> > > > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > > Hi Nuno,
> > >
> > > Thanks for filling in this missing doc. I wonder what else is old
> > > enough that we still don't have docs? Guess I should check when
> > > I'm next bored enough (so that's not happening any time soon ;)
> >
> > Yeah, wouldn't be surprised if there's some more ADI old stuff hanging around.
> > This caught my attention since I saw that out of tree patch adding support for a
> > new device (with no real reason for not being in tree).
> >
> > >
> > > > ---
> > > > .../devicetree/bindings/iio/dac/adi,ad5446.yaml | 138
> > > > +++++++++++++++++++++
> > > > MAINTAINERS | 8 ++
> > > > 2 files changed, 146 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> > > > b/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> > > > new file mode 100644
> > > > index 000000000000..90fc8ca053fe
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> > > > @@ -0,0 +1,138 @@
> > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/iio/dac/adi,ad5446.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: Analog Devices AD5446 and similar DACs
> > > > +
> > > > +maintainers:
> > > > + - Michael Hennerich <michael.hennerich@analog.com>
> > > > + - Nuno Sá <nuno.sa@analog.com>
> > > > +
> > > > +description: |
> > >
> > > Trivial but don't need the | as hardly matters if these get formatted
> > > differently.
> >
> > Sure.
> >
> > >
> > > > + Digital to Analog Converter devices supporting both SPI and I2C
> > > > interfaces.
> > > > + These devices feature a range of resolutions from 8-bit to 16-bit.
> > >
> > > ...
> > >
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index 940889b158eb..dae04c308975 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -440,6 +440,14 @@ W: http://wiki.analog.com/AD5398
> > > > W: https://ez.analog.com/linux-software-drivers
> > > > F: drivers/regulator/ad5398.c
> > > >
> > > > +AD5456 DAC DRIVER
> > > Tab seems odd here.
> > >
> > > Hmm. For a lot of ADI drivers we have entries that would look like
> > > ANALOG DEVICES INC AD5456 DAC DRIVER
> > >
> > > Any reason for formatting it like this?
> >
> > Ok, time to come clean :)
> >
> > Bindings were AI generated and then I just cleaned the obvious problems (clearly
> > I did not payed too much attention to the boilerplate stuff - lesson learned).
>
> I'd hold off on doing anything much with AI on kernel code for now.
> A clear policy might come out of the maintainers summit in December.
> If you are curious, various threads on: https://lore.kernel.org/ksummit/
Right, I did saw some threads regarding some patches being automatically sent
(I think the AUTOSEL stuff for stable) by AI. Not completely the same here as I still
reviewed it and changed things (more like co-developed thing :)).
>
> DT bindings get picked up by various projects so they may have their own
> policy long run.
>
I see, it's kind of handy (for bindings not so complicated) as it can come up with maybe
50/60% of the whole thing. But sure, I will refrain from using it until we have a clear
policy in place.
BTW, writing covers and commit messages would be fine, right?
- Nuno Sá
> J
>
> >
> > - Nuno Sá
> >
> > >
> > > > +M: Michael Hennerich <michael.hennerich@analog.com>
> > > > +M: Nuno Sá <nuno.sa@analog.com>
> > > > +L: linux-iio@vger.kernel.org
> > > > +S: Supported
> > > > +W: https://ez.analog.com/linux-software-drivers
> > > > +F: Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> > > > +
> > > > AD714X CAPACITANCE TOUCH SENSOR DRIVER (AD7142/3/7/8/7A)
> > > > M: Michael Hennerich <michael.hennerich@analog.com>
> > > > S: Supported
> > > >
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: iio: dac: Document AD5446 and similar devices
2025-10-30 11:30 ` Nuno Sá
@ 2025-11-02 12:13 ` Jonathan Cameron
0 siblings, 0 replies; 17+ messages in thread
From: Jonathan Cameron @ 2025-11-02 12:13 UTC (permalink / raw)
To: Nuno Sá
Cc: Jonathan Cameron, Nuno Sá, Michael Hennerich, David Lechner,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-iio, devicetree
On Thu, 30 Oct 2025 11:30:55 +0000
Nuno Sá <noname.nuno@gmail.com> wrote:
> On Mon, 2025-10-27 at 15:01 +0000, Jonathan Cameron wrote:
> > On Mon, 27 Oct 2025 14:48:50 +0000
> > Nuno Sá <noname.nuno@gmail.com> wrote:
> >
> > > On Thu, 2025-10-23 at 18:08 +0100, Jonathan Cameron wrote:
> > > > On Thu, 23 Oct 2025 14:01:37 +0300
> > > > Nuno Sá <nuno.sa@analog.com> wrote:
> > > >
> > > > > Add device tree binding documentation for the Analog Devices AD5446
> > > > > family of Digital-to-Analog Converters and compatible devices from
> > > > > Texas Instruments. There's both SPI and I2C interfaces and feature
> > > > > resolutions ranging from 8-bit to 16-bit.
> > > > >
> > > > > The binding covers 29 compatible devices including the AD5446 series,
> > > > > AD5600 series, AD5620/5640/5660 variants with different voltage ranges,
> > > > > and TI DAC081s101/DAC101s101/DAC121s101 devices.
> > > > >
> > > > > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > > > Hi Nuno,
> > > >
> > > > Thanks for filling in this missing doc. I wonder what else is old
> > > > enough that we still don't have docs? Guess I should check when
> > > > I'm next bored enough (so that's not happening any time soon ;)
> > >
> > > Yeah, wouldn't be surprised if there's some more ADI old stuff hanging around.
> > > This caught my attention since I saw that out of tree patch adding support for a
> > > new device (with no real reason for not being in tree).
> > >
> > > >
> > > > > ---
> > > > > .../devicetree/bindings/iio/dac/adi,ad5446.yaml | 138
> > > > > +++++++++++++++++++++
> > > > > MAINTAINERS | 8 ++
> > > > > 2 files changed, 146 insertions(+)
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> > > > > b/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> > > > > new file mode 100644
> > > > > index 000000000000..90fc8ca053fe
> > > > > --- /dev/null
> > > > > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> > > > > @@ -0,0 +1,138 @@
> > > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > > > +%YAML 1.2
> > > > > +---
> > > > > +$id: http://devicetree.org/schemas/iio/dac/adi,ad5446.yaml#
> > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > > +
> > > > > +title: Analog Devices AD5446 and similar DACs
> > > > > +
> > > > > +maintainers:
> > > > > + - Michael Hennerich <michael.hennerich@analog.com>
> > > > > + - Nuno Sá <nuno.sa@analog.com>
> > > > > +
> > > > > +description: |
> > > >
> > > > Trivial but don't need the | as hardly matters if these get formatted
> > > > differently.
> > >
> > > Sure.
> > >
> > > >
> > > > > + Digital to Analog Converter devices supporting both SPI and I2C
> > > > > interfaces.
> > > > > + These devices feature a range of resolutions from 8-bit to 16-bit.
> > > >
> > > > ...
> > > >
> > > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > > index 940889b158eb..dae04c308975 100644
> > > > > --- a/MAINTAINERS
> > > > > +++ b/MAINTAINERS
> > > > > @@ -440,6 +440,14 @@ W: http://wiki.analog.com/AD5398
> > > > > W: https://ez.analog.com/linux-software-drivers
> > > > > F: drivers/regulator/ad5398.c
> > > > >
> > > > > +AD5456 DAC DRIVER
> > > > Tab seems odd here.
> > > >
> > > > Hmm. For a lot of ADI drivers we have entries that would look like
> > > > ANALOG DEVICES INC AD5456 DAC DRIVER
> > > >
> > > > Any reason for formatting it like this?
> > >
> > > Ok, time to come clean :)
> > >
> > > Bindings were AI generated and then I just cleaned the obvious problems (clearly
> > > I did not payed too much attention to the boilerplate stuff - lesson learned).
> >
> > I'd hold off on doing anything much with AI on kernel code for now.
> > A clear policy might come out of the maintainers summit in December.
> > If you are curious, various threads on: https://lore.kernel.org/ksummit/
>
> Right, I did saw some threads regarding some patches being automatically sent
> (I think the AUTOSEL stuff for stable) by AI. Not completely the same here as I still
> reviewed it and changed things (more like co-developed thing :)).
>
> >
> > DT bindings get picked up by various projects so they may have their own
> > policy long run.
> >
>
> I see, it's kind of handy (for bindings not so complicated) as it can come up with maybe
> 50/60% of the whole thing. But sure, I will refrain from using it until we have a clear
> policy in place.
>
> BTW, writing covers and commit messages would be fine, right?
Yes - I've not seen anyone object to that and it is very helpful
in improving the readability of those. As long as people closely check
the result!
>
> - Nuno Sá
>
> > J
> >
> > >
> > > - Nuno Sá
> > >
> > > >
> > > > > +M: Michael Hennerich <michael.hennerich@analog.com>
> > > > > +M: Nuno Sá <nuno.sa@analog.com>
> > > > > +L: linux-iio@vger.kernel.org
> > > > > +S: Supported
> > > > > +W: https://ez.analog.com/linux-software-drivers
> > > > > +F: Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> > > > > +
> > > > > AD714X CAPACITANCE TOUCH SENSOR DRIVER (AD7142/3/7/8/7A)
> > > > > M: Michael Hennerich <michael.hennerich@analog.com>
> > > > > S: Supported
> > > > >
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: iio: dac: Document AD5446 and similar devices
2025-10-23 11:01 ` [PATCH v2 1/3] dt-bindings: iio: dac: Document AD5446 and similar devices Nuno Sá
2025-10-23 17:08 ` Jonathan Cameron
@ 2025-10-23 18:24 ` Conor Dooley
2025-10-24 10:12 ` Jonathan Cameron
1 sibling, 1 reply; 17+ messages in thread
From: Conor Dooley @ 2025-10-23 18:24 UTC (permalink / raw)
To: Nuno Sá
Cc: Michael Hennerich, Jonathan Cameron, David Lechner,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-iio, devicetree
[-- Attachment #1: Type: text/plain, Size: 5683 bytes --]
On Thu, Oct 23, 2025 at 02:01:37PM +0300, Nuno Sá wrote:
> Add device tree binding documentation for the Analog Devices AD5446
> family of Digital-to-Analog Converters and compatible devices from
> Texas Instruments. There's both SPI and I2C interfaces and feature
> resolutions ranging from 8-bit to 16-bit.
>
> The binding covers 29 compatible devices including the AD5446 series,
If they're compatible, how come there's no fallback use? Just to keep
things consistent with how they've always been while probing as spi
child devices?
Conor.
> AD5600 series, AD5620/5640/5660 variants with different voltage ranges,
> and TI DAC081s101/DAC101s101/DAC121s101 devices.
>
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> ---
> .../devicetree/bindings/iio/dac/adi,ad5446.yaml | 138 +++++++++++++++++++++
> MAINTAINERS | 8 ++
> 2 files changed, 146 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> new file mode 100644
> index 000000000000..90fc8ca053fe
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> @@ -0,0 +1,138 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/dac/adi,ad5446.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AD5446 and similar DACs
> +
> +maintainers:
> + - Michael Hennerich <michael.hennerich@analog.com>
> + - Nuno Sá <nuno.sa@analog.com>
> +
> +description: |
> + Digital to Analog Converter devices supporting both SPI and I2C interfaces.
> + These devices feature a range of resolutions from 8-bit to 16-bit.
> +
> +properties:
> + compatible:
> + oneOf:
> + - description: SPI DACs
> + enum:
> + - adi,ad5300
> + - adi,ad5310
> + - adi,ad5320
> + - adi,ad5444
> + - adi,ad5446
> + - adi,ad5450
> + - adi,ad5451
> + - adi,ad5452
> + - adi,ad5453
> + - adi,ad5512a
> + - adi,ad5541a
> + - adi,ad5542
> + - adi,ad5542a
> + - adi,ad5543
> + - adi,ad5553
> + - adi,ad5600
> + - adi,ad5601
> + - adi,ad5611
> + - adi,ad5621
> + - adi,ad5641
> + - adi,ad5620-2500
> + - adi,ad5620-1250
> + - adi,ad5640-2500
> + - adi,ad5640-1250
> + - adi,ad5660-2500
> + - adi,ad5660-1250
> + - adi,ad5662
> + - ti,dac081s101
> + - ti,dac101s101
> + - ti,dac121s101
> + - description: I2C DACs
> + enum:
> + - adi,ad5301
> + - adi,ad5311
> + - adi,ad5321
> + - adi,ad5602
> + - adi,ad5612
> + - adi,ad5622
> +
> + reg:
> + maxItems: 1
> +
> + vcc-supply:
> + description:
> + Reference voltage supply. If not supplied, devices with internal
> + voltage reference will use that.
> +
> +required:
> + - compatible
> + - reg
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - adi,ad5300
> + - adi,ad5310
> + - adi,ad5320
> + - adi,ad5444
> + - adi,ad5446
> + - adi,ad5450
> + - adi,ad5451
> + - adi,ad5452
> + - adi,ad5453
> + - adi,ad5512a
> + - adi,ad5541a
> + - adi,ad5542
> + - adi,ad5542a
> + - adi,ad5543
> + - adi,ad5553
> + - adi,ad5600
> + - adi,ad5601
> + - adi,ad5611
> + - adi,ad5621
> + - adi,ad5641
> + - adi,ad5620-2500
> + - adi,ad5620-1250
> + - adi,ad5640-2500
> + - adi,ad5640-1250
> + - adi,ad5660-2500
> + - adi,ad5660-1250
> + - adi,ad5662
> + - ti,dac081s101
> + - ti,dac101s101
> + - ti,dac121s101
> + then:
> + allOf:
> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + dac@0 {
> + compatible = "adi,ad5446";
> + reg = <0>;
> + vcc-supply = <&dac_vref>;
> + };
> + };
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + dac@42 {
> + compatible = "adi,ad5622";
> + reg = <0x42>;
> + vcc-supply = <&dac_vref>;
> + };
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 940889b158eb..dae04c308975 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -440,6 +440,14 @@ W: http://wiki.analog.com/AD5398
> W: https://ez.analog.com/linux-software-drivers
> F: drivers/regulator/ad5398.c
>
> +AD5456 DAC DRIVER
> +M: Michael Hennerich <michael.hennerich@analog.com>
> +M: Nuno Sá <nuno.sa@analog.com>
> +L: linux-iio@vger.kernel.org
> +S: Supported
> +W: https://ez.analog.com/linux-software-drivers
> +F: Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> +
> AD714X CAPACITANCE TOUCH SENSOR DRIVER (AD7142/3/7/8/7A)
> M: Michael Hennerich <michael.hennerich@analog.com>
> S: Supported
>
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH v2 1/3] dt-bindings: iio: dac: Document AD5446 and similar devices
2025-10-23 18:24 ` Conor Dooley
@ 2025-10-24 10:12 ` Jonathan Cameron
2025-10-24 11:04 ` Conor Dooley
0 siblings, 1 reply; 17+ messages in thread
From: Jonathan Cameron @ 2025-10-24 10:12 UTC (permalink / raw)
To: Conor Dooley
Cc: Nuno Sá, Michael Hennerich, Jonathan Cameron, David Lechner,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-iio, devicetree
On Thu, 23 Oct 2025 19:24:17 +0100
Conor Dooley <conor@kernel.org> wrote:
> On Thu, Oct 23, 2025 at 02:01:37PM +0300, Nuno Sá wrote:
> > Add device tree binding documentation for the Analog Devices AD5446
> > family of Digital-to-Analog Converters and compatible devices from
> > Texas Instruments. There's both SPI and I2C interfaces and feature
> > resolutions ranging from 8-bit to 16-bit.
> >
> > The binding covers 29 compatible devices including the AD5446 series,
>
> If they're compatible, how come there's no fallback use? Just to keep
> things consistent with how they've always been while probing as spi
> child devices?
Hi Conor,
They aren't compatible. The 2nd patch is misleading because it doesn't
associate data with the of_device_id. The driver is getting that from
matching the compatible property with manufacturer stripped off.
I've requested Nuno sort that out in v3. It's a bit more than just
adding the data as would also involve moving away from using an enum
to using pointers to the structures that the enum indexes (currently in
an array).
https://elixir.bootlin.com/linux/v6.17.4/source/drivers/iio/dac/ad5446.c#L315
Thanks,
J
>
> Conor.
>
> > AD5600 series, AD5620/5640/5660 variants with different voltage ranges,
> > and TI DAC081s101/DAC101s101/DAC121s101 devices.
> >
> > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > ---
> > .../devicetree/bindings/iio/dac/adi,ad5446.yaml | 138 +++++++++++++++++++++
> > MAINTAINERS | 8 ++
> > 2 files changed, 146 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> > new file mode 100644
> > index 000000000000..90fc8ca053fe
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> > @@ -0,0 +1,138 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/dac/adi,ad5446.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analog Devices AD5446 and similar DACs
> > +
> > +maintainers:
> > + - Michael Hennerich <michael.hennerich@analog.com>
> > + - Nuno Sá <nuno.sa@analog.com>
> > +
> > +description: |
> > + Digital to Analog Converter devices supporting both SPI and I2C interfaces.
> > + These devices feature a range of resolutions from 8-bit to 16-bit.
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - description: SPI DACs
> > + enum:
> > + - adi,ad5300
> > + - adi,ad5310
> > + - adi,ad5320
> > + - adi,ad5444
> > + - adi,ad5446
> > + - adi,ad5450
> > + - adi,ad5451
> > + - adi,ad5452
> > + - adi,ad5453
> > + - adi,ad5512a
> > + - adi,ad5541a
> > + - adi,ad5542
> > + - adi,ad5542a
> > + - adi,ad5543
> > + - adi,ad5553
> > + - adi,ad5600
> > + - adi,ad5601
> > + - adi,ad5611
> > + - adi,ad5621
> > + - adi,ad5641
> > + - adi,ad5620-2500
> > + - adi,ad5620-1250
> > + - adi,ad5640-2500
> > + - adi,ad5640-1250
> > + - adi,ad5660-2500
> > + - adi,ad5660-1250
> > + - adi,ad5662
> > + - ti,dac081s101
> > + - ti,dac101s101
> > + - ti,dac121s101
> > + - description: I2C DACs
> > + enum:
> > + - adi,ad5301
> > + - adi,ad5311
> > + - adi,ad5321
> > + - adi,ad5602
> > + - adi,ad5612
> > + - adi,ad5622
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + vcc-supply:
> > + description:
> > + Reference voltage supply. If not supplied, devices with internal
> > + voltage reference will use that.
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> > +allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - adi,ad5300
> > + - adi,ad5310
> > + - adi,ad5320
> > + - adi,ad5444
> > + - adi,ad5446
> > + - adi,ad5450
> > + - adi,ad5451
> > + - adi,ad5452
> > + - adi,ad5453
> > + - adi,ad5512a
> > + - adi,ad5541a
> > + - adi,ad5542
> > + - adi,ad5542a
> > + - adi,ad5543
> > + - adi,ad5553
> > + - adi,ad5600
> > + - adi,ad5601
> > + - adi,ad5611
> > + - adi,ad5621
> > + - adi,ad5641
> > + - adi,ad5620-2500
> > + - adi,ad5620-1250
> > + - adi,ad5640-2500
> > + - adi,ad5640-1250
> > + - adi,ad5660-2500
> > + - adi,ad5660-1250
> > + - adi,ad5662
> > + - ti,dac081s101
> > + - ti,dac101s101
> > + - ti,dac121s101
> > + then:
> > + allOf:
> > + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > + - |
> > + spi {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + dac@0 {
> > + compatible = "adi,ad5446";
> > + reg = <0>;
> > + vcc-supply = <&dac_vref>;
> > + };
> > + };
> > + - |
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + dac@42 {
> > + compatible = "adi,ad5622";
> > + reg = <0x42>;
> > + vcc-supply = <&dac_vref>;
> > + };
> > + };
> > +...
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 940889b158eb..dae04c308975 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -440,6 +440,14 @@ W: http://wiki.analog.com/AD5398
> > W: https://ez.analog.com/linux-software-drivers
> > F: drivers/regulator/ad5398.c
> >
> > +AD5456 DAC DRIVER
> > +M: Michael Hennerich <michael.hennerich@analog.com>
> > +M: Nuno Sá <nuno.sa@analog.com>
> > +L: linux-iio@vger.kernel.org
> > +S: Supported
> > +W: https://ez.analog.com/linux-software-drivers
> > +F: Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
> > +
> > AD714X CAPACITANCE TOUCH SENSOR DRIVER (AD7142/3/7/8/7A)
> > M: Michael Hennerich <michael.hennerich@analog.com>
> > S: Supported
> >
> > --
> > 2.34.1
> >
>
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH v2 1/3] dt-bindings: iio: dac: Document AD5446 and similar devices
2025-10-24 10:12 ` Jonathan Cameron
@ 2025-10-24 11:04 ` Conor Dooley
2025-10-27 14:49 ` Nuno Sá
0 siblings, 1 reply; 17+ messages in thread
From: Conor Dooley @ 2025-10-24 11:04 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Nuno Sá, Michael Hennerich, Jonathan Cameron, David Lechner,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-iio, devicetree
[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]
On Fri, Oct 24, 2025 at 11:12:07AM +0100, Jonathan Cameron wrote:
> On Thu, 23 Oct 2025 19:24:17 +0100
> Conor Dooley <conor@kernel.org> wrote:
>
> > On Thu, Oct 23, 2025 at 02:01:37PM +0300, Nuno Sá wrote:
> > > Add device tree binding documentation for the Analog Devices AD5446
> > > family of Digital-to-Analog Converters and compatible devices from
> > > Texas Instruments. There's both SPI and I2C interfaces and feature
> > > resolutions ranging from 8-bit to 16-bit.
> > >
> > > The binding covers 29 compatible devices including the AD5446 series,
> >
> > If they're compatible, how come there's no fallback use? Just to keep
> > things consistent with how they've always been while probing as spi
> > child devices?
> Hi Conor,
>
> They aren't compatible. The 2nd patch is misleading because it doesn't
> associate data with the of_device_id. The driver is getting that from
> matching the compatible property with manufacturer stripped off.
>
> I've requested Nuno sort that out in v3. It's a bit more than just
> adding the data as would also involve moving away from using an enum
> to using pointers to the structures that the enum indexes (currently in
> an array).
>
> https://elixir.bootlin.com/linux/v6.17.4/source/drivers/iio/dac/ad5446.c#L315
>
Right, I think the wording about "compatible" should be removed from the
commit message here then. Maybe something like "derivative devices"
would be a better fit?
pw-bot: changes-requested
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: iio: dac: Document AD5446 and similar devices
2025-10-24 11:04 ` Conor Dooley
@ 2025-10-27 14:49 ` Nuno Sá
0 siblings, 0 replies; 17+ messages in thread
From: Nuno Sá @ 2025-10-27 14:49 UTC (permalink / raw)
To: Conor Dooley, Jonathan Cameron
Cc: Nuno Sá, Michael Hennerich, Jonathan Cameron, David Lechner,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-iio, devicetree
On Fri, 2025-10-24 at 12:04 +0100, Conor Dooley wrote:
> On Fri, Oct 24, 2025 at 11:12:07AM +0100, Jonathan Cameron wrote:
> > On Thu, 23 Oct 2025 19:24:17 +0100
> > Conor Dooley <conor@kernel.org> wrote:
> >
> > > On Thu, Oct 23, 2025 at 02:01:37PM +0300, Nuno Sá wrote:
> > > > Add device tree binding documentation for the Analog Devices AD5446
> > > > family of Digital-to-Analog Converters and compatible devices from
> > > > Texas Instruments. There's both SPI and I2C interfaces and feature
> > > > resolutions ranging from 8-bit to 16-bit.
> > > >
> > > > The binding covers 29 compatible devices including the AD5446 series,
> > >
> > > If they're compatible, how come there's no fallback use? Just to keep
> > > things consistent with how they've always been while probing as spi
> > > child devices?
> > Hi Conor,
> >
> > They aren't compatible. The 2nd patch is misleading because it doesn't
> > associate data with the of_device_id. The driver is getting that from
> > matching the compatible property with manufacturer stripped off.
> >
> > I've requested Nuno sort that out in v3. It's a bit more than just
> > adding the data as would also involve moving away from using an enum
> > to using pointers to the structures that the enum indexes (currently in
> > an array).
> >
> > https://elixir.bootlin.com/linux/v6.17.4/source/drivers/iio/dac/ad5446.c#L315
> >
>
> Right, I think the wording about "compatible" should be removed from the
> commit message here then. Maybe something like "derivative devices"
> would be a better fit?
Will do that for v3
- Nuno Sá
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2 2/3] iio: dac: ad5456: Add missing DT compatibles
2025-10-23 11:01 [PATCH v2 0/3] iio: dac: ad5446: Add AD5542 to the spi id table Nuno Sá
2025-10-23 11:01 ` [PATCH v2 1/3] dt-bindings: iio: dac: Document AD5446 and similar devices Nuno Sá
@ 2025-10-23 11:01 ` Nuno Sá
2025-10-23 17:13 ` Jonathan Cameron
2025-10-24 16:29 ` Andy Shevchenko
2025-10-23 11:01 ` [PATCH v2 3/3] iio: dac: ad5446: Add AD5542 to the spi id table Nuno Sá
2 siblings, 2 replies; 17+ messages in thread
From: Nuno Sá @ 2025-10-23 11:01 UTC (permalink / raw)
To: Michael Hennerich, Jonathan Cameron, David Lechner,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-iio, devicetree, Nuno Sá
Add missing of_device_id compatibles for the i2c and spi drivers.
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
drivers/iio/dac/ad5446.c | 41 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c
index ad304b0fec08..b6967f3b9386 100644
--- a/drivers/iio/dac/ad5446.c
+++ b/drivers/iio/dac/ad5446.c
@@ -445,6 +445,35 @@ static const struct spi_device_id ad5446_spi_ids[] = {
MODULE_DEVICE_TABLE(spi, ad5446_spi_ids);
static const struct of_device_id ad5446_of_ids[] = {
+ { .compatible = "adi,ad5300" },
+ { .compatible = "adi,ad5310" },
+ { .compatible = "adi,ad5320" },
+ { .compatible = "adi,ad5444" },
+ { .compatible = "adi,ad5446" },
+ { .compatible = "adi,ad5450" },
+ { .compatible = "adi,ad5451" },
+ { .compatible = "adi,ad5452" },
+ { .compatible = "adi,ad5453" },
+ { .compatible = "adi,ad5512a" },
+ { .compatible = "adi,ad5541a" },
+ { .compatible = "adi,ad5542a" },
+ { .compatible = "adi,ad5543" },
+ { .compatible = "adi,ad5553" },
+ { .compatible = "adi,ad5600" },
+ { .compatible = "adi,ad5601" },
+ { .compatible = "adi,ad5611" },
+ { .compatible = "adi,ad5621" },
+ { .compatible = "adi,ad5641" },
+ { .compatible = "adi,ad5620-2500" },
+ { .compatible = "adi,ad5620-1250" },
+ { .compatible = "adi,ad5640-2500" },
+ { .compatible = "adi,ad5640-1250" },
+ { .compatible = "adi,ad5660-2500" },
+ { .compatible = "adi,ad5660-1250" },
+ { .compatible = "adi,ad5662" },
+ { .compatible = "ti,dac081s101" },
+ { .compatible = "ti,dac101s101" },
+ { .compatible = "ti,dac121s101" },
{ .compatible = "ti,dac7512" },
{ }
};
@@ -547,9 +576,21 @@ static const struct i2c_device_id ad5446_i2c_ids[] = {
};
MODULE_DEVICE_TABLE(i2c, ad5446_i2c_ids);
+static const struct of_device_id ad5446_i2c_of_ids[] = {
+ { .compatible = "adi,ad5301" },
+ { .compatible = "adi,ad5311" },
+ { .compatible = "adi,ad5321" },
+ { .compatible = "adi,ad5602" },
+ { .compatible = "adi,ad5612" },
+ { .compatible = "adi,ad5622" },
+ { }
+};
+MODULE_DEVICE_TABLE(OF, ad5446_i2c_of_ids);
+
static struct i2c_driver ad5446_i2c_driver = {
.driver = {
.name = "ad5446",
+ .of_match_table = ad5446_i2c_of_ids,
},
.probe = ad5446_i2c_probe,
.id_table = ad5446_i2c_ids,
--
2.34.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH v2 2/3] iio: dac: ad5456: Add missing DT compatibles
2025-10-23 11:01 ` [PATCH v2 2/3] iio: dac: ad5456: Add missing DT compatibles Nuno Sá
@ 2025-10-23 17:13 ` Jonathan Cameron
2025-10-27 14:55 ` Nuno Sá
2025-10-24 16:29 ` Andy Shevchenko
1 sibling, 1 reply; 17+ messages in thread
From: Jonathan Cameron @ 2025-10-23 17:13 UTC (permalink / raw)
To: Nuno Sá
Cc: Michael Hennerich, Jonathan Cameron, David Lechner,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-iio, devicetree
On Thu, 23 Oct 2025 14:01:38 +0300
Nuno Sá <nuno.sa@analog.com> wrote:
I'd retitle this to say it's adding explicit DT compatibles
Missing made me thing one or two were missing rather than it relying
on the fallback path to use the i2c_device_id / spi_device_id paths.
I'm not particularly keen on only get the drvdata from those other
tables as that's fragile to the two remaining precisely in sync. Until
we fix that better to not add these tables at all.
The cleanup will need to switch to pointers rather than enum entries
and then use generic fetchers to get those pointers which ever type
of firmware we have.
Not trivial but also fairly mechanical change to make so I don't
feel too mean asking that you do that as part of this patch series.
If nothing else looking at just this series, someone might think a fallback
compatible would be fine given the differences between parts aren't
visible.
Jonathan
> Add missing of_device_id compatibles for the i2c and spi drivers.
>
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> ---
> drivers/iio/dac/ad5446.c | 41 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
> diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c
> index ad304b0fec08..b6967f3b9386 100644
> --- a/drivers/iio/dac/ad5446.c
> +++ b/drivers/iio/dac/ad5446.c
> @@ -445,6 +445,35 @@ static const struct spi_device_id ad5446_spi_ids[] = {
> MODULE_DEVICE_TABLE(spi, ad5446_spi_ids);
>
> static const struct of_device_id ad5446_of_ids[] = {
> + { .compatible = "adi,ad5300" },
> + { .compatible = "adi,ad5310" },
> + { .compatible = "adi,ad5320" },
> + { .compatible = "adi,ad5444" },
> + { .compatible = "adi,ad5446" },
> + { .compatible = "adi,ad5450" },
> + { .compatible = "adi,ad5451" },
> + { .compatible = "adi,ad5452" },
> + { .compatible = "adi,ad5453" },
> + { .compatible = "adi,ad5512a" },
> + { .compatible = "adi,ad5541a" },
> + { .compatible = "adi,ad5542a" },
> + { .compatible = "adi,ad5543" },
> + { .compatible = "adi,ad5553" },
> + { .compatible = "adi,ad5600" },
> + { .compatible = "adi,ad5601" },
> + { .compatible = "adi,ad5611" },
> + { .compatible = "adi,ad5621" },
> + { .compatible = "adi,ad5641" },
> + { .compatible = "adi,ad5620-2500" },
> + { .compatible = "adi,ad5620-1250" },
> + { .compatible = "adi,ad5640-2500" },
> + { .compatible = "adi,ad5640-1250" },
> + { .compatible = "adi,ad5660-2500" },
> + { .compatible = "adi,ad5660-1250" },
> + { .compatible = "adi,ad5662" },
> + { .compatible = "ti,dac081s101" },
> + { .compatible = "ti,dac101s101" },
> + { .compatible = "ti,dac121s101" },
> { .compatible = "ti,dac7512" },
> { }
> };
> @@ -547,9 +576,21 @@ static const struct i2c_device_id ad5446_i2c_ids[] = {
> };
> MODULE_DEVICE_TABLE(i2c, ad5446_i2c_ids);
>
> +static const struct of_device_id ad5446_i2c_of_ids[] = {
> + { .compatible = "adi,ad5301" },
> + { .compatible = "adi,ad5311" },
> + { .compatible = "adi,ad5321" },
> + { .compatible = "adi,ad5602" },
> + { .compatible = "adi,ad5612" },
> + { .compatible = "adi,ad5622" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(OF, ad5446_i2c_of_ids);
> +
> static struct i2c_driver ad5446_i2c_driver = {
> .driver = {
> .name = "ad5446",
> + .of_match_table = ad5446_i2c_of_ids,
> },
> .probe = ad5446_i2c_probe,
> .id_table = ad5446_i2c_ids,
>
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH v2 2/3] iio: dac: ad5456: Add missing DT compatibles
2025-10-23 17:13 ` Jonathan Cameron
@ 2025-10-27 14:55 ` Nuno Sá
0 siblings, 0 replies; 17+ messages in thread
From: Nuno Sá @ 2025-10-27 14:55 UTC (permalink / raw)
To: Jonathan Cameron, Nuno Sá
Cc: Michael Hennerich, Jonathan Cameron, David Lechner,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-iio, devicetree
On Thu, 2025-10-23 at 18:13 +0100, Jonathan Cameron wrote:
> On Thu, 23 Oct 2025 14:01:38 +0300
> Nuno Sá <nuno.sa@analog.com> wrote:
>
> I'd retitle this to say it's adding explicit DT compatibles
>
> Missing made me thing one or two were missing rather than it relying
> on the fallback path to use the i2c_device_id / spi_device_id paths.
>
> I'm not particularly keen on only get the drvdata from those other
> tables as that's fragile to the two remaining precisely in sync. Until
> we fix that better to not add these tables at all.
>
> The cleanup will need to switch to pointers rather than enum entries
> and then use generic fetchers to get those pointers which ever type
> of firmware we have.
>
> Not trivial but also fairly mechanical change to make so I don't
> feel too mean asking that you do that as part of this patch series.
> If nothing else looking at just this series, someone might think a fallback
> compatible would be fine given the differences between parts aren't
> visible.
>
For such an old part I was trying to get away without having to refactor that
much eheh :). But fair enough, I'll do the above and look for some more obvious
improvements (like i2c and spi dedicated files). Should also note that I don't
really have HW with me so I'll really stick to obvious stuff.
- Nuno Sá
>
>
> > Add missing of_device_id compatibles for the i2c and spi drivers.
> >
> > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > ---
> > drivers/iio/dac/ad5446.c | 41 +++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 41 insertions(+)
> >
> > diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c
> > index ad304b0fec08..b6967f3b9386 100644
> > --- a/drivers/iio/dac/ad5446.c
> > +++ b/drivers/iio/dac/ad5446.c
> > @@ -445,6 +445,35 @@ static const struct spi_device_id ad5446_spi_ids[] = {
> > MODULE_DEVICE_TABLE(spi, ad5446_spi_ids);
> >
> > static const struct of_device_id ad5446_of_ids[] = {
> > + { .compatible = "adi,ad5300" },
> > + { .compatible = "adi,ad5310" },
> > + { .compatible = "adi,ad5320" },
> > + { .compatible = "adi,ad5444" },
> > + { .compatible = "adi,ad5446" },
> > + { .compatible = "adi,ad5450" },
> > + { .compatible = "adi,ad5451" },
> > + { .compatible = "adi,ad5452" },
> > + { .compatible = "adi,ad5453" },
> > + { .compatible = "adi,ad5512a" },
> > + { .compatible = "adi,ad5541a" },
> > + { .compatible = "adi,ad5542a" },
> > + { .compatible = "adi,ad5543" },
> > + { .compatible = "adi,ad5553" },
> > + { .compatible = "adi,ad5600" },
> > + { .compatible = "adi,ad5601" },
> > + { .compatible = "adi,ad5611" },
> > + { .compatible = "adi,ad5621" },
> > + { .compatible = "adi,ad5641" },
> > + { .compatible = "adi,ad5620-2500" },
> > + { .compatible = "adi,ad5620-1250" },
> > + { .compatible = "adi,ad5640-2500" },
> > + { .compatible = "adi,ad5640-1250" },
> > + { .compatible = "adi,ad5660-2500" },
> > + { .compatible = "adi,ad5660-1250" },
> > + { .compatible = "adi,ad5662" },
> > + { .compatible = "ti,dac081s101" },
> > + { .compatible = "ti,dac101s101" },
> > + { .compatible = "ti,dac121s101" },
> > { .compatible = "ti,dac7512" },
> > { }
> > };
> > @@ -547,9 +576,21 @@ static const struct i2c_device_id ad5446_i2c_ids[] = {
> > };
> > MODULE_DEVICE_TABLE(i2c, ad5446_i2c_ids);
> >
> > +static const struct of_device_id ad5446_i2c_of_ids[] = {
> > + { .compatible = "adi,ad5301" },
> > + { .compatible = "adi,ad5311" },
> > + { .compatible = "adi,ad5321" },
> > + { .compatible = "adi,ad5602" },
> > + { .compatible = "adi,ad5612" },
> > + { .compatible = "adi,ad5622" },
> > + { }
> > +};
> > +MODULE_DEVICE_TABLE(OF, ad5446_i2c_of_ids);
> > +
> > static struct i2c_driver ad5446_i2c_driver = {
> > .driver = {
> > .name = "ad5446",
> > + .of_match_table = ad5446_i2c_of_ids,
> > },
> > .probe = ad5446_i2c_probe,
> > .id_table = ad5446_i2c_ids,
> >
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/3] iio: dac: ad5456: Add missing DT compatibles
2025-10-23 11:01 ` [PATCH v2 2/3] iio: dac: ad5456: Add missing DT compatibles Nuno Sá
2025-10-23 17:13 ` Jonathan Cameron
@ 2025-10-24 16:29 ` Andy Shevchenko
2025-10-24 18:41 ` Jonathan Cameron
1 sibling, 1 reply; 17+ messages in thread
From: Andy Shevchenko @ 2025-10-24 16:29 UTC (permalink / raw)
To: Nuno Sá
Cc: Michael Hennerich, Jonathan Cameron, David Lechner,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-iio, devicetree
On Thu, Oct 23, 2025 at 02:01:38PM +0300, Nuno Sá wrote:
> Add missing of_device_id compatibles for the i2c and spi drivers.
How does it work at all? Is there an ugly ifdeferry? No module should have two
module_*_driver() and other stuff.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/3] iio: dac: ad5456: Add missing DT compatibles
2025-10-24 16:29 ` Andy Shevchenko
@ 2025-10-24 18:41 ` Jonathan Cameron
0 siblings, 0 replies; 17+ messages in thread
From: Jonathan Cameron @ 2025-10-24 18:41 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Nuno Sá, Michael Hennerich, Jonathan Cameron, David Lechner,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-iio, devicetree
On Fri, 24 Oct 2025 19:29:00 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Thu, Oct 23, 2025 at 02:01:38PM +0300, Nuno Sá wrote:
> > Add missing of_device_id compatibles for the i2c and spi drivers.
>
> How does it work at all? Is there an ugly ifdeferry?
Exactly that.
> No module should have two
> module_*_driver() and other stuff.
>
Indeed, hence not using that infrastructure.
I wouldn't mind more significant refactors...
J
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2 3/3] iio: dac: ad5446: Add AD5542 to the spi id table
2025-10-23 11:01 [PATCH v2 0/3] iio: dac: ad5446: Add AD5542 to the spi id table Nuno Sá
2025-10-23 11:01 ` [PATCH v2 1/3] dt-bindings: iio: dac: Document AD5446 and similar devices Nuno Sá
2025-10-23 11:01 ` [PATCH v2 2/3] iio: dac: ad5456: Add missing DT compatibles Nuno Sá
@ 2025-10-23 11:01 ` Nuno Sá
2 siblings, 0 replies; 17+ messages in thread
From: Nuno Sá @ 2025-10-23 11:01 UTC (permalink / raw)
To: Michael Hennerich, Jonathan Cameron, David Lechner,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-iio, devicetree, Michael Hennerich, Nuno Sá
From: Michael Hennerich <michael.hennerich@analog.com>
This adds support for the AD5542 single channel Current Source and
Voltage Output DACs.
It is similar to the AD5542A model so just use the same id.
While at it, add the driver to the proper MAINTAINERS entry.
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Co-developed-by: Nuno Sá <nuno.sa@analog.com>
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
MAINTAINERS | 1 +
drivers/iio/dac/ad5446.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index dae04c308975..1288df469151 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -447,6 +447,7 @@ L: linux-iio@vger.kernel.org
S: Supported
W: https://ez.analog.com/linux-software-drivers
F: Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
+F: drivers/iio/dac/ad5446.c
AD714X CAPACITANCE TOUCH SENSOR DRIVER (AD7142/3/7/8/7A)
M: Michael Hennerich <michael.hennerich@analog.com>
diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c
index b6967f3b9386..e71f10806496 100644
--- a/drivers/iio/dac/ad5446.c
+++ b/drivers/iio/dac/ad5446.c
@@ -421,6 +421,7 @@ static const struct spi_device_id ad5446_spi_ids[] = {
{"ad5453", ID_AD5446}, /* ad5453 is compatible to the ad5446 */
{"ad5512a", ID_AD5512A},
{"ad5541a", ID_AD5541A},
+ {"ad5542", ID_AD5541A}, /* ad5541a and ad5542 are compatible */
{"ad5542a", ID_AD5541A}, /* ad5541a and ad5542a are compatible */
{"ad5543", ID_AD5541A}, /* ad5541a and ad5543 are compatible */
{"ad5553", ID_AD5553},
@@ -456,6 +457,7 @@ static const struct of_device_id ad5446_of_ids[] = {
{ .compatible = "adi,ad5453" },
{ .compatible = "adi,ad5512a" },
{ .compatible = "adi,ad5541a" },
+ { .compatible = "adi,ad5542" },
{ .compatible = "adi,ad5542a" },
{ .compatible = "adi,ad5543" },
{ .compatible = "adi,ad5553" },
--
2.34.1
^ permalink raw reply related [flat|nested] 17+ messages in thread