Re: [RESEND v5 3/4] soundwire: qcom: Add set_channel_map api support

[Mohammad Rafi Shaik <quic_mohs@quicinc.com>]

On 2/3/2025 6:49 PM, Mark Brown wrote:
> On Thu, Jan 23, 2025 at 09:58:22AM +0530, Mohammad Rafi Shaik wrote:
>> Added qcom_swrm_set_channel_map api to set the master channel mask for
>> TX and RX paths based on the provided slots.
> 
> This breaks an allmodconfig build, and arm64 defconfig:
> 
> /build/stage/linux/drivers/soundwire/qcom.c: In function ‘qcom_swrm_set_channel_map’:
> /build/stage/linux/drivers/soundwire/qcom.c:1283:36: warning: unused variable ‘sruntime’ [-Wunused-variable]
>   1283 |         struct sdw_stream_runtime *sruntime = ctrl->sruntime[dai->id];
>        |                                    ^~~~~~~~
> /build/stage/linux/drivers/soundwire/qcom.c: At top level:
> /build/stage/linux/drivers/soundwire/qcom.c:1335:28: error: initialization of ‘int (*)(struct snd_soc_dai *, unsigned int,  const unsigned int *, unsigned int,  const unsigned int *)’ from incompatible pointer type ‘int (*)(struct snd_soc_dai *, unsigned int,  unsigned int *, unsigned int,  unsigned int *)’ [-Werror=incompatible-pointer-types]
>   1335 |         .set_channel_map = qcom_swrm_set_channel_map,
>        |                            ^~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/drivers/soundwire/qcom.c:1335:28: note: (near initialization for ‘qcom_swrm_pdm_dai_ops.set_channel_map’)

ACK,

Thanks for the review and test.

Somehow above build errors not reproduced in my build setup.

I am Using below commands for build:
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- allmodconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j32

Will check and fix in next version.

Thanks & Regards,
Rafi