From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Ding, Shenghao" <shenghao-ding@ti.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"Lu, Kevin" <kevin-lu@ti.com>, "Xu, Baojun" <baojun.xu@ti.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"pierre-louis.bossart@linux.intel.com"
<pierre-louis.bossart@linux.intel.com>,
"13916275206@139.com" <13916275206@139.com>,
"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"liam.r.girdwood@intel.com" <liam.r.girdwood@intel.com>,
"soyer@irl.hu" <soyer@irl.hu>, "tiwai@suse.de" <tiwai@suse.de>,
"Gupta, Peeyush" <peeyush@ti.com>,
"Navada Kanyana, Mukund" <navada@ti.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 from yaml
Date: Wed, 27 Dec 2023 11:56:25 +0100 [thread overview]
Message-ID: <ffc11f9c-6643-4e46-8bb2-8918e1179f72@linaro.org> (raw)
In-Reply-To: <8285d102645b43f6b46b15c99321105a@ti.com>
On 27/12/2023 08:07, Ding, Shenghao wrote:
>
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: Friday, December 22, 2023 1:31 AM
>> To: Ding, Shenghao <shenghao-ding@ti.com>; broonie@kernel.org;
>> conor+dt@kernel.org
>> Cc: robh+dt@kernel.org; andriy.shevchenko@linux.intel.com; Lu, Kevin
>> <kevin-lu@ti.com>; Xu, Baojun <baojun.xu@ti.com>;
>> devicetree@vger.kernel.org; lgirdwood@gmail.com; perex@perex.cz; pierre-
>> louis.bossart@linux.intel.com; 13916275206@139.com; linux-
>> sound@vger.kernel.org; linux-kernel@vger.kernel.org;
>> liam.r.girdwood@intel.com; soyer@irl.hu; tiwai@suse.de; Gupta, Peeyush
>> <peeyush@ti.com>; Navada Kanyana, Mukund <navada@ti.com>
>> Subject: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563
>> from yaml
>>
>> On 21/12/2023 11:13, Shenghao Ding wrote:
>>> Remove tas2563 from tas2562, it will be supported in tas2781 to better
>>> support dsp mode.
>>
>> Please provide rationale in terms of bindings and hardware, not in terms of
>> driver. Or at least not only. For example "supported in tas2781" does not fit
>> hardware part, so you sure must be talking about drivers thus why driver
>> change would affect bindings?
> This patch mainly change the binding, not the driver code. Tas2563 is unbound
> to tas2562 driver, and bound to tas2781 driver.
Then why do you reference driver "tas2781" here?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-27 10:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 10:13 [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 from yaml Shenghao Ding
2023-12-21 10:13 ` [PATCH v2 2/5] ASoC: tas2562: remove tas2563 into driver Shenghao Ding
2023-12-21 15:52 ` Andy Shevchenko
2023-12-21 10:13 ` [PATCH v2 3/5] ASoC: tas2781: Add tas2563 into header file for dsp mode Shenghao Ding
2023-12-21 15:53 ` Andy Shevchenko
2023-12-21 10:13 ` [PATCH v2 4/5] ASoC: tas2781: Add tas2563 into driver Shenghao Ding
2023-12-21 15:54 ` Andy Shevchenko
2023-12-21 10:13 ` [PATCH v2 5/5] ASoC: dt-bindings: Add tas2563 into ti,ta2781.yaml to support dsp mode better Shenghao Ding
2023-12-21 17:29 ` Krzysztof Kozlowski
2023-12-21 15:50 ` [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 from yaml Andy Shevchenko
2023-12-21 17:31 ` Krzysztof Kozlowski
2023-12-27 7:04 ` [EXTERNAL] " Ding, Shenghao
2023-12-27 10:55 ` Krzysztof Kozlowski
2023-12-23 11:48 ` Ding, Shenghao
2023-12-21 17:31 ` Krzysztof Kozlowski
2023-12-27 7:07 ` [EXTERNAL] " Ding, Shenghao
2023-12-27 10:56 ` Krzysztof Kozlowski [this message]
2023-12-27 13:45 ` Ding, Shenghao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffc11f9c-6643-4e46-8bb2-8918e1179f72@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=13916275206@139.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=navada@ti.com \
--cc=peeyush@ti.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).