From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDBB1C7EE23 for ; Wed, 17 May 2023 19:41:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229635AbjEQTlw (ORCPT ); Wed, 17 May 2023 15:41:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229562AbjEQTlv (ORCPT ); Wed, 17 May 2023 15:41:51 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 153061B8 for ; Wed, 17 May 2023 12:41:49 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-96b0235c10bso209931466b.3 for ; Wed, 17 May 2023 12:41:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684352507; x=1686944507; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AE8+B3pWQ4l7QxfBqXUnPyiVc+aZlt+BtRcwXsFR3Kg=; b=JeDzLUDQ2pq/eW+97XnNWJdM/lObXBgEGxcH7lBWg6seb0FFwdy+Skry85v27s6EvM QkKH/tarHJPDjjQLK1puuvgut2LSyAGVlXvtgQk85PVSFy2ZrpUXtZCoQdoEG4NYgMJq ecYIECc3PBpmL8RasuQeCZ8hXX7hhxfC2bTTNXwk7kQw9Yp3FrTvUxxIvUe9j2IPmmj8 XYAnodyLH69Fi5r5Z0kVGXZz57/Xitgrslunok7K0u2BrSApjH7yzTPKUGDHH4SwwMj1 bnIg4tChp1M9aS3koD+8rutqnoTrCa3Cc+09L8PFzVd5FnecZA/i+KSehJoymjAUhr21 QwXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684352507; x=1686944507; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AE8+B3pWQ4l7QxfBqXUnPyiVc+aZlt+BtRcwXsFR3Kg=; b=PES9vey187aYRwzCg86AvKA12Zw7KkQX7SIc1HFFcvGhNRDOsvidNGLbPDnzZbjWwY pkIfHU5cEGul5QWG+6mkSrz4HbC6yKI2d0c5SahbRa2WaoeJYFEMKGtttFPso4pBpWkZ u/hpKp3Y4aQ2U19j7AkpnhNx1eHBk6Y/WGZfZwpNxXIrNlj4ir78uxTDp4fcYxZSWdlZ koulUwiBzQH1dHpz+bwjXmMyqaT5OBb5RM+l10Cg2Kq7sHn7HAChJs6fdAmBI29Fp/2I otdXYfuPpi4gIOm7PuAa1E/orX/K7OzksWPurzzcCYhCzdPWKr2TWuhRaAn7a7PkAM7i ICXQ== X-Gm-Message-State: AC+VfDxYRM5qUU9XOXNZFpk0aJSXi81VPZCpIWgLHMZJ2kuLcaNq1+Tc vQkHaIZqlvEyCDmYRQV4L7geLA== X-Google-Smtp-Source: ACHHUZ4Qg3tRhWiRB2mnHGaX2Qu65CxTKUwvjCQnfKZkAA1h5PCV5S9tuiMPT1sXlI8/YMjQYOhZ5A== X-Received: by 2002:a17:907:8a04:b0:95f:de3c:6c98 with SMTP id sc4-20020a1709078a0400b0095fde3c6c98mr39648716ejc.58.1684352507571; Wed, 17 May 2023 12:41:47 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:d7a:e7cc:21b3:c435? ([2a02:810d:15c0:828:d7a:e7cc:21b3:c435]) by smtp.gmail.com with ESMTPSA id og16-20020a1709071dd000b0096637a19dcasm12671085ejc.4.2023.05.17.12.41.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 May 2023 12:41:47 -0700 (PDT) Message-ID: Date: Wed, 17 May 2023 21:41:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 7/7] dt-bindings: Add bidings for mtk,apu-drm Content-Language: en-US From: Krzysztof Kozlowski To: Alexandre Bailon , airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, sumit.semwal@linaro.org, christian.koenig@amd.com, jstephan@baylibre.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, khilman@baylibre.com, nbelin@baylibre.com, bero@baylibre.com References: <20230517145237.295461-1-abailon@baylibre.com> <20230517145237.295461-8-abailon@baylibre.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/05/2023 21:38, Krzysztof Kozlowski wrote: > On 17/05/2023 16:52, Alexandre Bailon wrote: >> This adds the device tree bindings for the APU DRM driver. >> >> Signed-off-by: Alexandre Bailon >> Reviewed-by: Julien Stephan > > There are so many errors in this patch... that for sure it was not > tested. Reduced review, except what was already said: > >> --- >> .../devicetree/bindings/gpu/mtk,apu-drm.yaml | 38 +++++++++++++++++++ >> 1 file changed, 38 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/gpu/mtk,apu-drm.yaml >> >> diff --git a/Documentation/devicetree/bindings/gpu/mtk,apu-drm.yaml b/Documentation/devicetree/bindings/gpu/mtk,apu-drm.yaml >> new file mode 100644 >> index 000000000000..6f432d3ea478 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/gpu/mtk,apu-drm.yaml >> @@ -0,0 +1,38 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/gpu/mediatek,apu-drm.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: AI Processor Unit DRM >> + >> +properties: >> + compatible: >> + const: mediatek,apu-drm > > drm is not hardware. Drop everywhere or explain the acronym. If you > explain it like Linux explains, then: drm is not hardware. > >> + >> + remoteproc: >> + maxItems: 2 >> + description: >> + Handle to remoteproc devices controlling the APU > > Missing type/ref. Does not look like generic property, so missing vendor > prefix. > >> + >> + iova: >> + maxItems: 1 >> + description: >> + Address and size of virtual memory that could used by the APU > > So it is a reg? > >> + >> +required: >> + - compatible >> + - remoteproc >> + - iova >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + apu@0 { > > Where is reg? @0 says you have it... > >> + compatible = "mediatek,apu-drm"; >> + remoteproc = <&vpu0>, <&vpu1>; >> + iova = <0 0x60000000 0 0x10000000>; > > Why would you store virtual address, not real, in DT? Let's say you have > some randomization like KASLR. How is it going to work? Drop, it is not > hardware property. Actually RANDOMIZE_BASE. KASLR randomizes the physical. Best regards, Krzysztof