From: vnkgutta@codeaurora.org
To: Evan Green <evgreen@chromium.org>
Cc: robh@kernel.org, mchehab@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, tsoni@codeaurora.org,
ckadabi@codeaurora.org, rishabhb@codeaurora.org, bp@alien8.de
Subject: Re: [PATCH v2 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs
Date: Fri, 24 Aug 2018 11:38:10 -0700 [thread overview]
Message-ID: <ffe2184066ddc9b4be4bf1bafc3497be@codeaurora.org> (raw)
In-Reply-To: <CAE=gft6GTuk+j81J+jTNqD_6VFQym=gb6aJ==cbcg-6odVq3qg@mail.gmail.com>
On 2018-08-23 16:07, Evan Green wrote:
> On Thu, Aug 23, 2018 at 4:04 PM Evan Green <evgreen@chromium.org>
> wrote:
>>
>> On Fri, Aug 17, 2018 at 5:08 PM Venkata Narendra Kumar Gutta
>> <vnkgutta@codeaurora.org> wrote:
>> >
>> > From: Channagoud Kadabi <ckadabi@codeaurora.org>
>
> Also checkpatch.pl complains a bit about this patch:
>
> WARNING: Non-standard signature: Co-developed-by:
> #14:
> Co-developed-by: Venkata Narendra Kumar Gutta
> <vnkgutta@codeaurora.org>
This needs to be there as the original author is Channagoud Kadabi
and I'm the one who is modifying and upstreaming this driver.
It was suggested to have this kind of signature from the earlier
patchset comments.
Can we do anything about this?
>
> WARNING: please write a paragraph that describes the
> config symbol fully
> #63: FILE: drivers/edac/Kconfig:460:
> +config EDAC_QCOM
This is also, I will check if I can get rid of this by writing more in
the description.
I don't really understand why do we need a paragraph here.
>
> WARNING: DT compatible string "qcom,llcc-edac" appears
> un-documented -- check ./Documentation/devicetree/bindings/
> #536: FILE: drivers/edac/qcom_edac.c:430:
> + { .compatible = "qcom,llcc-edac" },
This file is not added in the dt-bindings as there are no properties
(like reg-names or interrupts) for this driver
and anyway initialized from llcc driver.
Do we still need to have the Documentation in place?
>
> total: 0 errors, 3 warnings, 533 lines checked
>
> -Evan
next prev parent reply other threads:[~2018-08-24 18:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-18 0:08 [PATCH v2 0/4] Add EDAC driver for QCOM SoCs Venkata Narendra Kumar Gutta
2018-08-18 0:08 ` [PATCH v2 1/4] drivers: soc: Add broadcast base for Last Level Cache Controller (LLCC) Venkata Narendra Kumar Gutta
2018-08-23 23:01 ` Evan Green
2018-08-24 17:58 ` vnkgutta
2018-08-18 0:08 ` [PATCH v2 2/4] drivers: soc: Add support to register LLCC EDAC driver Venkata Narendra Kumar Gutta
2018-08-23 23:01 ` Evan Green
2018-08-24 17:57 ` vnkgutta
2018-08-18 0:08 ` [PATCH v2 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs Venkata Narendra Kumar Gutta
2018-08-23 23:04 ` Evan Green
2018-08-23 23:07 ` Evan Green
2018-08-24 18:38 ` vnkgutta [this message]
2018-08-24 18:32 ` vnkgutta
2018-08-24 20:18 ` Evan Green
2018-08-24 21:05 ` vnkgutta
2018-08-24 16:11 ` Stephen Boyd
2018-08-24 19:47 ` vnkgutta
2018-08-18 0:08 ` [PATCH v2 4/4] dt-bindigs: msm: Update documentation of qcom,llcc Venkata Narendra Kumar Gutta
2018-08-20 19:53 ` Rob Herring
2018-08-22 21:46 ` vnkgutta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffe2184066ddc9b4be4bf1bafc3497be@codeaurora.org \
--to=vnkgutta@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bp@alien8.de \
--cc=ckadabi@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=rishabhb@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).