devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: imx95: add some USB3 PHY tuning properties
@ 2025-06-27  3:13 Xu Yang
  2025-07-07  8:21 ` Shawn Guo
  0 siblings, 1 reply; 3+ messages in thread
From: Xu Yang @ 2025-06-27  3:13 UTC (permalink / raw)
  To: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam
  Cc: devicetree, imx, linux-arm-kernel, jun.li

Add some USB3 PHY tuning properties to imx95-15x15-evk and
imx95-19x19-evk boards to improve USB signal quality.

Reviewed-by: Jun Li <jun.li@nxp.com>
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts | 6 +++++-
 arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts | 4 ++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts b/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts
index 6c47f4b47356..b26e9db7832a 100644
--- a/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts
@@ -1069,8 +1069,12 @@ usb3_data_hs: endpoint {
 };
 
 &usb3_phy {
-	orientation-switch;
+	fsl,phy-pcs-tx-deemph-3p5db-attenuation-db = <17>;
+	fsl,phy-pcs-tx-swing-full-percent = <100>;
 	fsl,phy-tx-preemp-amp-tune-microamp = <600>;
+	fsl,phy-tx-vboost-level-microvolt = <1156>;
+	fsl,phy-tx-vref-tune-percent = <100>;
+	orientation-switch;
 	status = "okay";
 
 	port {
diff --git a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
index 6886ea766655..e212f12f869a 100644
--- a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
@@ -514,7 +514,11 @@ usb3_data_hs: endpoint {
 };
 
 &usb3_phy {
+	fsl,phy-pcs-tx-deemph-3p5db-attenuation-db = <17>;
+	fsl,phy-pcs-tx-swing-full-percent = <100>;
 	fsl,phy-tx-preemp-amp-tune-microamp = <600>;
+	fsl,phy-tx-vboost-level-microvolt = <1156>;
+	fsl,phy-tx-vref-tune-percent = <100>;
 	orientation-switch;
 	status = "okay";
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: imx95: add some USB3 PHY tuning properties
  2025-06-27  3:13 [PATCH] arm64: dts: imx95: add some USB3 PHY tuning properties Xu Yang
@ 2025-07-07  8:21 ` Shawn Guo
  2025-07-07  9:00   ` Xu Yang
  0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2025-07-07  8:21 UTC (permalink / raw)
  To: Xu Yang, Frank Li
  Cc: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam,
	devicetree, imx, linux-arm-kernel, jun.li

On Fri, Jun 27, 2025 at 11:13:48AM +0800, Xu Yang wrote:
> Add some USB3 PHY tuning properties to imx95-15x15-evk and
> imx95-19x19-evk boards to improve USB signal quality.
> 
> Reviewed-by: Jun Li <jun.li@nxp.com>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts | 6 +++++-
>  arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts | 4 ++++
>  2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts b/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts
> index 6c47f4b47356..b26e9db7832a 100644
> --- a/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts
> @@ -1069,8 +1069,12 @@ usb3_data_hs: endpoint {
>  };
>  
>  &usb3_phy {
> -	orientation-switch;
> +	fsl,phy-pcs-tx-deemph-3p5db-attenuation-db = <17>;
> +	fsl,phy-pcs-tx-swing-full-percent = <100>;
>  	fsl,phy-tx-preemp-amp-tune-microamp = <600>;
> +	fsl,phy-tx-vboost-level-microvolt = <1156>;
> +	fsl,phy-tx-vref-tune-percent = <100>;
> +	orientation-switch;
>  	status = "okay";

It conflicts with what I applied from Frank [1].

Shawn

[1] https://lkml.org/lkml/2025/6/6/920

>  
>  	port {
> diff --git a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> index 6886ea766655..e212f12f869a 100644
> --- a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> @@ -514,7 +514,11 @@ usb3_data_hs: endpoint {
>  };
>  
>  &usb3_phy {
> +	fsl,phy-pcs-tx-deemph-3p5db-attenuation-db = <17>;
> +	fsl,phy-pcs-tx-swing-full-percent = <100>;
>  	fsl,phy-tx-preemp-amp-tune-microamp = <600>;
> +	fsl,phy-tx-vboost-level-microvolt = <1156>;
> +	fsl,phy-tx-vref-tune-percent = <100>;
>  	orientation-switch;
>  	status = "okay";
>  
> -- 
> 2.34.1
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: imx95: add some USB3 PHY tuning properties
  2025-07-07  8:21 ` Shawn Guo
@ 2025-07-07  9:00   ` Xu Yang
  0 siblings, 0 replies; 3+ messages in thread
From: Xu Yang @ 2025-07-07  9:00 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Frank Li, robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel,
	festevam, devicetree, imx, linux-arm-kernel, jun.li

On Mon, Jul 07, 2025 at 04:21:00PM +0800, Shawn Guo wrote:
> On Fri, Jun 27, 2025 at 11:13:48AM +0800, Xu Yang wrote:
> > Add some USB3 PHY tuning properties to imx95-15x15-evk and
> > imx95-19x19-evk boards to improve USB signal quality.
> > 
> > Reviewed-by: Jun Li <jun.li@nxp.com>
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts | 6 +++++-
> >  arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts | 4 ++++
> >  2 files changed, 9 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts b/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts
> > index 6c47f4b47356..b26e9db7832a 100644
> > --- a/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts
> > @@ -1069,8 +1069,12 @@ usb3_data_hs: endpoint {
> >  };
> >  
> >  &usb3_phy {
> > -	orientation-switch;
> > +	fsl,phy-pcs-tx-deemph-3p5db-attenuation-db = <17>;
> > +	fsl,phy-pcs-tx-swing-full-percent = <100>;
> >  	fsl,phy-tx-preemp-amp-tune-microamp = <600>;
> > +	fsl,phy-tx-vboost-level-microvolt = <1156>;
> > +	fsl,phy-tx-vref-tune-percent = <100>;
> > +	orientation-switch;
> >  	status = "okay";
> 
> It conflicts with what I applied from Frank [1].
> 
> Shawn
> 
> [1] https://lkml.org/lkml/2025/6/6/920

Well, my bad. I should rebase my tree firstly. I will send another one later.

Thanks,
Xu Yang

> 
> >  
> >  	port {
> > diff --git a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> > index 6886ea766655..e212f12f869a 100644
> > --- a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> > @@ -514,7 +514,11 @@ usb3_data_hs: endpoint {
> >  };
> >  
> >  &usb3_phy {
> > +	fsl,phy-pcs-tx-deemph-3p5db-attenuation-db = <17>;
> > +	fsl,phy-pcs-tx-swing-full-percent = <100>;
> >  	fsl,phy-tx-preemp-amp-tune-microamp = <600>;
> > +	fsl,phy-tx-vboost-level-microvolt = <1156>;
> > +	fsl,phy-tx-vref-tune-percent = <100>;
> >  	orientation-switch;
> >  	status = "okay";
> >  
> > -- 
> > 2.34.1
> > 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-07-07  9:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-27  3:13 [PATCH] arm64: dts: imx95: add some USB3 PHY tuning properties Xu Yang
2025-07-07  8:21 ` Shawn Guo
2025-07-07  9:00   ` Xu Yang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).