From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Eremin-Solenikov Subject: Re: [PATCH] mtd: dataflash: add device tree probe support Date: Sun, 10 Jul 2011 08:14:29 +0000 (UTC) Message-ID: References: <1310283313-32087-1-git-send-email-shawn.guo@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org Cc: linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Shawn Guo wrote: > It adds device tree probe support for mtd_dataflash driver. > > Signed-off-by: Shawn Guo > Cc: Grant Likely > Cc: David Woodhouse > Cc: Artem Bityutskiy > --- > drivers/mtd/devices/mtd_dataflash.c | 12 +++++++++++- > 1 files changed, 11 insertions(+), 1 deletions(-) > > diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c > index 8f6b02c..64d7242 100644 > --- a/drivers/mtd/devices/mtd_dataflash.c > +++ b/drivers/mtd/devices/mtd_dataflash.c > @@ -24,6 +24,8 @@ > #include > #include > > +#include > +#include > > /* > * DataFlash is a kind of SPI flash. Most AT45 chips have two buffers in > @@ -98,6 +100,11 @@ struct dataflash { > struct mtd_info mtd; > }; > > +static const struct of_device_id dataflash_dt_ids[] = { > + { .compatible = "atmel,dataflash", }, Please add also smth. like atmel,at45 to be more descriptive (probably single at45 entry will be sufficient). -- With best wishes Dmitry