From: Kevin Hilman <khilman@baylibre.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-media@vger.kernel.org, "Hans Verkuil" <hverkuil@xs4all.nl>,
devicetree@vger.kernel.org, "Sekhar Nori" <nsekhar@ti.com>,
"Axel Haslam" <ahaslam@baylibre.com>,
"Bartosz Gołaszewski" <bgolaszewski@baylibre.com>,
"Alexandre Bailon" <abailon@baylibre.com>,
"David Lechner" <david@lechnology.com>,
"Rob Herring" <robh@kernel.org>
Subject: Re: [PATCH 4/4] [media] dt-bindings: add TI VPIF documentation
Date: Mon, 21 Nov 2016 16:09:40 -0800 [thread overview]
Message-ID: <m28tsc1ikb.fsf@baylibre.com> (raw)
In-Reply-To: <165090919.oFnaNnsijv@wuerfel> (Arnd Bergmann's message of "Mon, 21 Nov 2016 15:15:07 +0100")
Arnd Bergmann <arnd@arndb.de> writes:
> On Friday, November 18, 2016 4:32:08 PM CET Kevin Hilman wrote:
>> +
>> +Required properties:
>> +- compatible: must be "ti,vpif-capture"
>> +- reg: physical base address and length of the registers set for the device;
>> +- interrupts: should contain IRQ line for the VPIF
>> +
>>
>
> Shouldn't this have a SoC specific identifier or a version number
> in the compatible string? "vpif" seems rather generic, so it's
> likely that TI made more than one variant of it.
AFAICT, they used this for a single generation of davinci SoCs (dm6467,
da850) and then moved on to using something completely different.
But, that still proves your point because it's very SoC specific, so
I'll make the compatible specific.
Thanks for the review,
Kevin
next prev parent reply other threads:[~2016-11-22 0:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-19 0:32 [PATCH 1/4] [media] davinci: add support for DT init Kevin Hilman
2016-11-19 0:32 ` [PATCH 2/4] [media] davinci: vpif_capture: don't lock over s_stream Kevin Hilman
2016-11-21 14:37 ` Hans Verkuil
[not found] ` <f385c65b-1f73-a5b1-b498-43916d5bdfb6-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2016-11-22 0:10 ` Kevin Hilman
[not found] ` <20161119003208.10550-1-khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-11-19 0:32 ` [PATCH 3/4] [media] davinci: vpif_capture: get subdevs from DT Kevin Hilman
2016-11-19 0:32 ` [PATCH 4/4] [media] dt-bindings: add TI VPIF documentation Kevin Hilman
2016-11-21 14:15 ` Arnd Bergmann
2016-11-22 0:09 ` Kevin Hilman [this message]
[not found] ` <20161119003208.10550-4-khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-11-24 0:04 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m28tsc1ikb.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=abailon@baylibre.com \
--cc=ahaslam@baylibre.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).