From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Schwab Subject: Re: [PATCH v5 06/27] irq_domain/powerpc: eliminate irq_map; use irq_alloc_desc() instead Date: Fri, 06 Apr 2012 13:25:19 +0200 Message-ID: References: <1329383368-12122-1-git-send-email-grant.likely@secretlab.ca> <1329383368-12122-7-git-send-email-grant.likely@secretlab.ca> <20120402202848.1EB833E02A7@localhost> <20120404154020.40C513E09D5@localhost> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: (Thomas Gleixner's message of "Fri, 6 Apr 2012 13:17:04 +0200 (CEST)") Sender: linux-kernel-owner@vger.kernel.org To: Thomas Gleixner Cc: Grant Likely , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree-discuss@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Benjamin Herrenschmidt , Milton Miller , Rob Herring List-Id: devicetree@vger.kernel.org Thomas Gleixner writes: > And it looks like the irqdomain code is the real culprit. > > void irq_set_virq_count(unsigned int count) > { > pr_debug("irq: Trying to set virq count to %d\n", count); > > BUG_ON(count < NUM_ISA_INTERRUPTS); > if (count < NR_IRQS) > irq_virq_count = count; > } > > That looks simply wrong..... There is a single use of irq_set_virq_count, which is only relevant to the PS3. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."