* [PATCH 1/2] dt-bindings: spi-meson: Add GXBB Compatible string [not found] <1473321206-32284-1-git-send-email-narmstrong@baylibre.com> @ 2016-09-08 7:53 ` Neil Armstrong 2016-09-12 19:07 ` Mark Brown [not found] ` <1473321206-32284-2-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> [not found] ` <293061a8-e867-4d91-20cb-6e5df8e9b543@suse.de> 1 sibling, 2 replies; 7+ messages in thread From: Neil Armstrong @ 2016-09-08 7:53 UTC (permalink / raw) To: broonie, carlo, khilman, devicetree Cc: Neil Armstrong, linux-spi, linux-arm-kernel, linux-amlogic, linux-kernel Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- Documentation/devicetree/bindings/spi/spi-meson.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/spi/spi-meson.txt b/Documentation/devicetree/bindings/spi/spi-meson.txt index bb52a86..dc6d031 100644 --- a/Documentation/devicetree/bindings/spi/spi-meson.txt +++ b/Documentation/devicetree/bindings/spi/spi-meson.txt @@ -7,7 +7,7 @@ NOR memories, without DMA support and a 64-byte unified transmit / receive buffer. Required properties: - - compatible: should be "amlogic,meson6-spifc" + - compatible: should be "amlogic,meson6-spifc" or "amlogic,meson-gxbb-spifc" - reg: physical base address and length of the controller registers - clocks: phandle of the input clock for the baud rate generator - #address-cells: should be 1 -- 1.9.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: spi-meson: Add GXBB Compatible string 2016-09-08 7:53 ` [PATCH 1/2] dt-bindings: spi-meson: Add GXBB Compatible string Neil Armstrong @ 2016-09-12 19:07 ` Mark Brown [not found] ` <1473321206-32284-2-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> 1 sibling, 0 replies; 7+ messages in thread From: Mark Brown @ 2016-09-12 19:07 UTC (permalink / raw) To: Neil Armstrong Cc: carlo, khilman, devicetree, linux-spi, linux-arm-kernel, linux-amlogic, linux-kernel [-- Attachment #1: Type: text/plain, Size: 186 bytes --] On Thu, Sep 08, 2016 at 09:53:25AM +0200, Neil Armstrong wrote: > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> Please use subject lines matching the style for the subsystem. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 473 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <1473321206-32284-2-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>]
* Re: [PATCH 1/2] dt-bindings: spi-meson: Add GXBB Compatible string [not found] ` <1473321206-32284-2-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> @ 2016-09-16 15:33 ` Rob Herring 0 siblings, 0 replies; 7+ messages in thread From: Rob Herring @ 2016-09-16 15:33 UTC (permalink / raw) To: Neil Armstrong Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A, carlo-KA+7E9HrN00dnm+yROfE0A, khilman-rdvid1DuHRBWk0Htik3J/w, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-spi-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA On Thu, Sep 08, 2016 at 09:53:25AM +0200, Neil Armstrong wrote: > Signed-off-by: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> > --- > Documentation/devicetree/bindings/spi/spi-meson.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/spi/spi-meson.txt b/Documentation/devicetree/bindings/spi/spi-meson.txt > index bb52a86..dc6d031 100644 > --- a/Documentation/devicetree/bindings/spi/spi-meson.txt > +++ b/Documentation/devicetree/bindings/spi/spi-meson.txt > @@ -7,7 +7,7 @@ NOR memories, without DMA support and a 64-byte unified transmit / > receive buffer. > > Required properties: > - - compatible: should be "amlogic,meson6-spifc" > + - compatible: should be "amlogic,meson6-spifc" or "amlogic,meson-gxbb-spifc" If you are going to use both, make sure the order is clear (most specific, best match first). Sometimes the chip names make that clear, but not here. > - reg: physical base address and length of the controller registers > - clocks: phandle of the input clock for the baud rate generator > - #address-cells: should be 1 > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <293061a8-e867-4d91-20cb-6e5df8e9b543@suse.de>]
* Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible [not found] ` <293061a8-e867-4d91-20cb-6e5df8e9b543@suse.de> @ 2016-09-08 12:50 ` Andreas Färber 2016-09-08 18:17 ` Kevin Hilman [not found] ` <4a199a95-3ee6-a3a0-bc8a-63bd0912e7d2-l3A5Bk7waGM@public.gmane.org> 0 siblings, 2 replies; 7+ messages in thread From: Andreas Färber @ 2016-09-08 12:50 UTC (permalink / raw) To: Neil Armstrong Cc: khilman, linux-kernel, linux-spi, broonie, carlo, linux-amlogic, linux-arm-kernel, devicetree Am 08.09.2016 um 14:04 schrieb Andreas Färber: > Am 08.09.2016 um 09:53 schrieb Neil Armstrong: >> This patchset adds a specific compatible string in the Meson SPIFC driver for >> the Amlogic Meson GXBB SoC. > > Any particular reason? We could just reuse the meson6 one since there > appear to be no code changes so far. So Neil is essentially telling me they don't know whether there are any differences in the IP block, so a separate compatible string was chosen. No objection from my side, but a general clarification from device tree maintainers when and when not to would be appreciated. (+ devicetree) Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible 2016-09-08 12:50 ` [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible Andreas Färber @ 2016-09-08 18:17 ` Kevin Hilman [not found] ` <4a199a95-3ee6-a3a0-bc8a-63bd0912e7d2-l3A5Bk7waGM@public.gmane.org> 1 sibling, 0 replies; 7+ messages in thread From: Kevin Hilman @ 2016-09-08 18:17 UTC (permalink / raw) To: Andreas Färber Cc: Neil Armstrong, linux-kernel, linux-spi, broonie, carlo, linux-amlogic, linux-arm-kernel, devicetree, Rob Herring Andreas Färber <afaerber@suse.de> writes: > Am 08.09.2016 um 14:04 schrieb Andreas Färber: >> Am 08.09.2016 um 09:53 schrieb Neil Armstrong: >>> This patchset adds a specific compatible string in the Meson SPIFC driver for >>> the Amlogic Meson GXBB SoC. >> >> Any particular reason? We could just reuse the meson6 one since there >> appear to be no code changes so far. > > So Neil is essentially telling me they don't know whether there are any > differences in the IP block, so a separate compatible string was chosen. > > No objection from my side, but a general clarification from device tree > maintainers when and when not to would be appreciated. (+ devicetree) I'm not sure what the "right" way is (Rob?) but I think the usual way is to add new compatibles when needed. Kevin ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <4a199a95-3ee6-a3a0-bc8a-63bd0912e7d2-l3A5Bk7waGM@public.gmane.org>]
* Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible [not found] ` <4a199a95-3ee6-a3a0-bc8a-63bd0912e7d2-l3A5Bk7waGM@public.gmane.org> @ 2016-09-08 13:21 ` Ben Dooks 2016-09-16 15:28 ` Rob Herring 1 sibling, 0 replies; 7+ messages in thread From: Ben Dooks @ 2016-09-08 13:21 UTC (permalink / raw) To: Andreas Färber, Neil Armstrong Cc: devicetree, khilman-rdvid1DuHRBWk0Htik3J/w, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-spi-u79uwXL29TY76Z2rM5mHXA, broonie-DgEjT+Ai2ygdnm+yROfE0A, carlo-KA+7E9HrN00dnm+yROfE0A, linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On 08/09/16 13:50, Andreas Färber wrote: > Am 08.09.2016 um 14:04 schrieb Andreas Färber: >> Am 08.09.2016 um 09:53 schrieb Neil Armstrong: >>> This patchset adds a specific compatible string in the Meson SPIFC driver for >>> the Amlogic Meson GXBB SoC. >> >> Any particular reason? We could just reuse the meson6 one since there >> appear to be no code changes so far. > > So Neil is essentially telling me they don't know whether there are any > differences in the IP block, so a separate compatible string was chosen. > > No objection from my side, but a general clarification from device tree > maintainers when and when not to would be appreciated. (+ devicetree) I prefer to add both the device-tree itself, so if there are differences found later then it can be dealt with without rebuilding both the DT and kernel. It is nice to have the new ones added to the driver so that you know the hardware choices in play. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible [not found] ` <4a199a95-3ee6-a3a0-bc8a-63bd0912e7d2-l3A5Bk7waGM@public.gmane.org> 2016-09-08 13:21 ` Ben Dooks @ 2016-09-16 15:28 ` Rob Herring 1 sibling, 0 replies; 7+ messages in thread From: Rob Herring @ 2016-09-16 15:28 UTC (permalink / raw) To: Andreas Färber Cc: Neil Armstrong, khilman-rdvid1DuHRBWk0Htik3J/w, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-spi-u79uwXL29TY76Z2rM5mHXA, broonie-DgEjT+Ai2ygdnm+yROfE0A, carlo-KA+7E9HrN00dnm+yROfE0A, linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree On Thu, Sep 08, 2016 at 02:50:37PM +0200, Andreas Färber wrote: > Am 08.09.2016 um 14:04 schrieb Andreas Färber: > > Am 08.09.2016 um 09:53 schrieb Neil Armstrong: > >> This patchset adds a specific compatible string in the Meson SPIFC driver for > >> the Amlogic Meson GXBB SoC. > > > > Any particular reason? We could just reuse the meson6 one since there > > appear to be no code changes so far. > > So Neil is essentially telling me they don't know whether there are any > differences in the IP block, so a separate compatible string was chosen. > > No objection from my side, but a general clarification from device tree > maintainers when and when not to would be appreciated. (+ devicetree) New chip, always define a new compatible. If you think they are the same or are close enough to function with the existing driver, then put both compatible strings in the DT. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-09-16 15:33 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1473321206-32284-1-git-send-email-narmstrong@baylibre.com>
2016-09-08 7:53 ` [PATCH 1/2] dt-bindings: spi-meson: Add GXBB Compatible string Neil Armstrong
2016-09-12 19:07 ` Mark Brown
[not found] ` <1473321206-32284-2-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-09-16 15:33 ` Rob Herring
[not found] ` <293061a8-e867-4d91-20cb-6e5df8e9b543@suse.de>
2016-09-08 12:50 ` [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible Andreas Färber
2016-09-08 18:17 ` Kevin Hilman
[not found] ` <4a199a95-3ee6-a3a0-bc8a-63bd0912e7d2-l3A5Bk7waGM@public.gmane.org>
2016-09-08 13:21 ` Ben Dooks
2016-09-16 15:28 ` Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).