* [PATCH 5/8] ARM64: dts: meson-gxbb: add i2s output pins
2017-03-23 16:50 [PATCH 0/8] pinctrl: meson: add audio output pins Jerome Brunet
@ 2017-03-23 16:50 ` Jerome Brunet
2017-03-28 13:15 ` Linus Walleij
2017-03-23 16:50 ` [PATCH 6/8] ARM64: dts: meson-gxbb: add spdif " Jerome Brunet
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Jerome Brunet @ 2017-03-23 16:50 UTC (permalink / raw)
To: Linus Walleij, Carlo Caione, Kevin Hilman
Cc: Jerome Brunet, linux-gpio, linux-arm-kernel, linux-amlogic,
devicetree, linux-kernel
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 63 +++++++++++++++++++++++++++++
1 file changed, 63 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
index 04b3324bc132..5ce70e1ec9ae 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
@@ -203,6 +203,48 @@
function = "pwm_ao_b";
};
};
+
+ i2s_am_clk_pins: i2s_am_clk {
+ mux {
+ groups = "i2s_am_clk";
+ function = "i2s_out_ao";
+ };
+ };
+
+ i2s_out_ao_clk_pins: i2s_out_ao_clk {
+ mux {
+ groups = "i2s_out_ao_clk";
+ function = "i2s_out_ao";
+ };
+ };
+
+ i2s_out_lr_clk_pins: i2s_out_lr_clk {
+ mux {
+ groups = "i2s_out_lr_clk";
+ function = "i2s_out_ao";
+ };
+ };
+
+ i2s_out_ch01_ao_pins: i2s_out_ch01_ao {
+ mux {
+ groups = "i2s_out_ch01_ao";
+ function = "i2s_out_ao";
+ };
+ };
+
+ i2s_out_ch23_ao_pins: i2s_out_ch23_ao {
+ mux {
+ groups = "i2s_out_ch23_ao";
+ function = "i2s_out_ao";
+ };
+ };
+
+ i2s_out_ch45_ao_pins: i2s_out_ch45_ao {
+ mux {
+ groups = "i2s_out_ch45_ao";
+ function = "i2s_out_ao";
+ };
+ };
};
clkc_AO: clock-controller@040 {
@@ -467,6 +509,27 @@
function = "hdmi_i2c";
};
};
+
+ i2sout_ch23_y_pins: i2sout_ch23_y {
+ mux {
+ groups = "i2sout_ch23_y";
+ function = "i2s_out";
+ };
+ };
+
+ i2sout_ch45_y_pins: i2sout_ch45_y {
+ mux {
+ groups = "i2sout_ch45_y";
+ function = "i2s_out";
+ };
+ };
+
+ i2sout_ch67_y_pins: i2sout_ch67_y {
+ mux {
+ groups = "i2sout_ch67_y";
+ function = "i2s_out";
+ };
+ };
};
};
--
2.9.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 5/8] ARM64: dts: meson-gxbb: add i2s output pins
2017-03-23 16:50 ` [PATCH 5/8] ARM64: dts: meson-gxbb: add i2s " Jerome Brunet
@ 2017-03-28 13:15 ` Linus Walleij
[not found] ` <CACRpkdYYqX=qkLyvRMAPMyqvwg0=NHpq1GXRnTyZbd=L2cna9g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 9+ messages in thread
From: Linus Walleij @ 2017-03-28 13:15 UTC (permalink / raw)
To: Jerome Brunet
Cc: devicetree@vger.kernel.org, Kevin Hilman,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Carlo Caione, open list:ARM/Amlogic Meson...,
linux-arm-kernel@lists.infradead.org
On Thu, Mar 23, 2017 at 5:50 PM, Jerome Brunet <jbrunet@baylibre.com> wrote:
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
For this and the other Meson DTS patches.
Please funnel these through the apropriate ARM SoC-feed tree.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 6/8] ARM64: dts: meson-gxbb: add spdif output pins
2017-03-23 16:50 [PATCH 0/8] pinctrl: meson: add audio output pins Jerome Brunet
2017-03-23 16:50 ` [PATCH 5/8] ARM64: dts: meson-gxbb: add i2s " Jerome Brunet
@ 2017-03-23 16:50 ` Jerome Brunet
2017-03-23 16:51 ` [PATCH 7/8] ARM64: dts: meson-gxl: add i2s " Jerome Brunet
[not found] ` <20170323165101.29262-1-jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
3 siblings, 0 replies; 9+ messages in thread
From: Jerome Brunet @ 2017-03-23 16:50 UTC (permalink / raw)
To: Linus Walleij, Carlo Caione, Kevin Hilman
Cc: Jerome Brunet, linux-gpio, linux-arm-kernel, linux-amlogic,
devicetree, linux-kernel
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
index 5ce70e1ec9ae..e5fd88e2c5f7 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
@@ -245,6 +245,20 @@
function = "i2s_out_ao";
};
};
+
+ spdif_out_ao_6_pins: spdif_out_ao_6 {
+ mux {
+ groups = "spdif_out_ao_6";
+ function = "spdif_out_ao";
+ };
+ };
+
+ spdif_out_ao_13_pins: spdif_out_ao_13 {
+ mux {
+ groups = "spdif_out_ao_13";
+ function = "spdif_out_ao";
+ };
+ };
};
clkc_AO: clock-controller@040 {
@@ -530,6 +544,13 @@
function = "i2s_out";
};
};
+
+ spdif_out_y_pins: spdif_out_y {
+ mux {
+ groups = "spdif_out_y";
+ function = "spdif_out";
+ };
+ };
};
};
--
2.9.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 7/8] ARM64: dts: meson-gxl: add i2s output pins
2017-03-23 16:50 [PATCH 0/8] pinctrl: meson: add audio output pins Jerome Brunet
2017-03-23 16:50 ` [PATCH 5/8] ARM64: dts: meson-gxbb: add i2s " Jerome Brunet
2017-03-23 16:50 ` [PATCH 6/8] ARM64: dts: meson-gxbb: add spdif " Jerome Brunet
@ 2017-03-23 16:51 ` Jerome Brunet
[not found] ` <20170323165101.29262-1-jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
3 siblings, 0 replies; 9+ messages in thread
From: Jerome Brunet @ 2017-03-23 16:51 UTC (permalink / raw)
To: Linus Walleij, Carlo Caione, Kevin Hilman
Cc: devicetree, linux-kernel, linux-gpio, linux-amlogic,
linux-arm-kernel, Jerome Brunet
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 62 ++++++++++++++++++++++++++++++
1 file changed, 62 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
index fe11b5fc61f7..88ad3490c124 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
@@ -124,6 +124,20 @@
function = "pwm_ao_b";
};
};
+
+ i2s_out_ch23_ao_pins: i2s_out_ch23_ao {
+ mux {
+ groups = "i2s_out_ch23_ao";
+ function = "i2s_out_ao";
+ };
+ };
+
+ i2s_out_ch45_ao_pins: i2s_out_ch45_ao {
+ mux {
+ groups = "i2s_out_ch45_ao";
+ function = "i2s_out_ao";
+ };
+ };
};
};
@@ -297,6 +311,54 @@
function = "hdmi_i2c";
};
};
+
+ i2s_am_clk_pins: i2s_am_clk {
+ mux {
+ groups = "i2s_am_clk";
+ function = "i2s_out";
+ };
+ };
+
+ i2s_out_ao_clk_pins: i2s_out_ao_clk {
+ mux {
+ groups = "i2s_out_ao_clk";
+ function = "i2s_out";
+ };
+ };
+
+ i2s_out_lr_clk_pins: i2s_out_lr_clk {
+ mux {
+ groups = "i2s_out_lr_clk";
+ function = "i2s_out";
+ };
+ };
+
+ i2s_out_ch01_pins: i2s_out_ch01 {
+ mux {
+ groups = "i2s_out_ch01";
+ function = "i2s_out";
+ };
+ };
+ i2sout_ch23_z_pins: i2sout_ch23_z {
+ mux {
+ groups = "i2sout_ch23_z";
+ function = "i2s_out";
+ };
+ };
+
+ i2sout_ch45_z_pins: i2sout_ch45_z {
+ mux {
+ groups = "i2sout_ch45_z";
+ function = "i2s_out";
+ };
+ };
+
+ i2sout_ch67_z_pins: i2sout_ch67_z {
+ mux {
+ groups = "i2sout_ch67_z";
+ function = "i2s_out";
+ };
+ };
};
eth-phy-mux {
--
2.9.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
[parent not found: <20170323165101.29262-1-jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>]
* [PATCH 8/8] ARM64: dts: meson-gxl: add spdif output pins
[not found] ` <20170323165101.29262-1-jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
@ 2017-03-23 16:51 ` Jerome Brunet
2017-03-24 19:52 ` [PATCH 0/8] pinctrl: meson: add audio " Kevin Hilman
1 sibling, 0 replies; 9+ messages in thread
From: Jerome Brunet @ 2017-03-23 16:51 UTC (permalink / raw)
To: Linus Walleij, Carlo Caione, Kevin Hilman
Cc: Jerome Brunet, linux-gpio-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Signed-off-by: Jerome Brunet <jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
---
arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
index 88ad3490c124..8f57e74b719c 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
@@ -138,6 +138,20 @@
function = "i2s_out_ao";
};
};
+
+ spdif_out_ao_6_pins: spdif_out_ao_6 {
+ mux {
+ groups = "spdif_out_ao_6";
+ function = "spdif_out_ao";
+ };
+ };
+
+ spdif_out_ao_9_pins: spdif_out_ao_9 {
+ mux {
+ groups = "spdif_out_ao_9";
+ function = "spdif_out_ao";
+ };
+ };
};
};
@@ -359,6 +373,13 @@
function = "i2s_out";
};
};
+
+ spdif_out_h_pins: spdif_out_ao_h {
+ mux {
+ groups = "spdif_out_h";
+ function = "spdif_out";
+ };
+ };
};
eth-phy-mux {
--
2.9.3
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 0/8] pinctrl: meson: add audio output pins
[not found] ` <20170323165101.29262-1-jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2017-03-23 16:51 ` [PATCH 8/8] ARM64: dts: meson-gxl: add spdif " Jerome Brunet
@ 2017-03-24 19:52 ` Kevin Hilman
2017-03-24 21:23 ` Jerome Brunet
1 sibling, 1 reply; 9+ messages in thread
From: Kevin Hilman @ 2017-03-24 19:52 UTC (permalink / raw)
To: Jerome Brunet
Cc: Linus Walleij, Carlo Caione, linux-gpio-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Jerome Brunet <jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> writes:
> This patchset adds the pinctrl definition and the related device-tree
> bindings of the i2s output and spdif output pins on the meson gxbb and
> gxl SoCs.
>
> This is part of the ongoing work to bring audio output suppot on the
> meson family. It was tested on the gxbb p200 and gxl p230.
Series looks good to me,
However, I'm not sure about Linus's preference, but most maintainers
(myself included) prefer a small description in the changelog, even if
it restates (with slightly more description) what's already in the
$SUBJECT.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/8] pinctrl: meson: add audio output pins
2017-03-24 19:52 ` [PATCH 0/8] pinctrl: meson: add audio " Kevin Hilman
@ 2017-03-24 21:23 ` Jerome Brunet
0 siblings, 0 replies; 9+ messages in thread
From: Jerome Brunet @ 2017-03-24 21:23 UTC (permalink / raw)
To: Kevin Hilman, Linus Walleij
Cc: devicetree, linux-kernel, linux-gpio, Carlo Caione, linux-amlogic,
linux-arm-kernel
On Fri, 2017-03-24 at 12:52 -0700, Kevin Hilman wrote:
> Jerome Brunet <jbrunet@baylibre.com> writes:
>
> > This patchset adds the pinctrl definition and the related device-tree
> > bindings of the i2s output and spdif output pins on the meson gxbb and
> > gxl SoCs.
> >
> > This is part of the ongoing work to bring audio output suppot on the
> > meson family. It was tested on the gxbb p200 and gxl p230.
>
> Series looks good to me,
>
> However, I'm not sure about Linus's preference, but most maintainers
> (myself included) prefer a small description in the changelog, even if
> it restates (with slightly more description) what's already in the
> $SUBJECT.
Understood. thanks for pointing it out.
This series was going to clash with Neil's pinctrl fixes anyway.
I'll respin it taking this into account.
>
> Kevin
^ permalink raw reply [flat|nested] 9+ messages in thread