From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Tejun Heo <tj@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Michael Turquette <mturquette@baylibre.com>,
Patrick Titiano <ptitiano@baylibre.com>,
linux-ide@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ata: ahci: add support for DaVinci DM816 SATA controller
Date: Tue, 14 Mar 2017 10:03:35 -0700 [thread overview]
Message-ID: <m2wpbraizc.fsf@baylibre.com> (raw)
In-Reply-To: <7ab4b440-f9d0-22fa-f463-f4c5542e21e7@baylibre.com> (Neil Armstrong's message of "Tue, 14 Mar 2017 10:00:07 +0100")
Neil Armstrong <narmstrong@baylibre.com> writes:
> On 03/14/2017 09:57 AM, Sergei Shtylyov wrote:
>> Hello!
>>
>> On 3/13/2017 7:36 PM, Bartosz Golaszewski wrote:
>>
>>> This SATA controller is quite similar to the one present on the DA850
>>> SoC, but the PHY configuration is different and it supports two HBA
>>> ports.
>>>
>>> The IP suffers from the same PMP issue the DA850 does - if we enable
>>> PMP but don't use it - softreset fails. Appropriate workaround was
>>> implemented in this driver as well.
>>>
>>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>>> ---
>>> drivers/ata/Kconfig | 9 +++
>>> drivers/ata/Makefile | 1 +
>>> drivers/ata/ahci_dm816.c | 200 +++++++++++++++++++++++++++++++++++++++++++++++
>>> 3 files changed, 210 insertions(+)
>>> create mode 100644 drivers/ata/ahci_dm816.c
>>>
>>> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
>>> index 70b57d2..7f59a7a 100644
>>> --- a/drivers/ata/Kconfig
>>> +++ b/drivers/ata/Kconfig
>>> @@ -118,6 +118,15 @@ config AHCI_DA850
>>>
>>> If unsure, say N.
>>>
>>> +config AHCI_DM816
>>> + tristate "DaVinci DM816 AHCI SATA support"
>>
>> Is it really DaVinci?
>>
>>> + depends on ARCH_OMAP2PLUS
>>
>> Especially if it depends on OMAP...
>
> Hi Sergei,
>
> Yes it's a DaVinci family SoC, but shares a lot of IPs with the OMAP family.
>
Actually, this is more of an OMAP family, which shares some IP from
DaVinci family
I think in other parts of the kernel, we refer to this as TI 816x
instead of using either DaVinci or OMAP.
Kevin
prev parent reply other threads:[~2017-03-14 17:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 16:36 [PATCH 0/2] ata: ahci-dm816: new driver Bartosz Golaszewski
2017-03-13 16:36 ` [PATCH 1/2] dt-bindings: ata: add DT bindings for ahci-dm816 SATA controller Bartosz Golaszewski
[not found] ` <1489422982-3461-2-git-send-email-bgolaszewski-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2017-03-13 16:53 ` Sergei Shtylyov
[not found] ` <2d0ede95-86d6-4d52-6cf5-91de35a29145-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-03-13 17:08 ` Bartosz Golaszewski
2017-03-13 17:27 ` Sergei Shtylyov
2017-03-14 9:06 ` Neil Armstrong
[not found] ` <61ee23f2-734b-f793-0054-364ce553ae5e-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-03-14 10:43 ` Bartosz Golaszewski
2017-03-13 16:36 ` [PATCH 2/2] ata: ahci: add support for DaVinci DM816 " Bartosz Golaszewski
2017-03-14 8:57 ` Sergei Shtylyov
2017-03-14 9:00 ` Neil Armstrong
2017-03-14 17:03 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wpbraizc.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=narmstrong@baylibre.com \
--cc=ptitiano@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).