devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rui Miguel Silva <rmfrfs@gmail.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ryan Harkin <ryan.harkin@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Rui Miguel Silva <rui.silva@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Steve Longerbeam <slongerbeam@gmail.com>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	mchehab@kernel.org, Shawn Guo <shawnguo@kernel.org>,
	linux-media@vger.kernel.org
Subject: Re: [PATCH v4 06/12] media: dt-bindings: add bindings for i.MX7 media driver
Date: Tue, 22 May 2018 14:19:21 +0100	[thread overview]
Message-ID: <m336yjvndy.fsf@gmail.com> (raw)
In-Reply-To: <20180518221346.fy4264hehvjjcd4y@kekkonen.localdomain>

Hi Sakari,
On Fri 18 May 2018 at 22:13, Sakari Ailus wrote:
> On Fri, May 18, 2018 at 09:27:58AM +0100, Rui Miguel Silva 
> wrote:
>> > > +endpoint node
>> > > +-------------
>> > > +
>> > > +- data-lanes    : (required) an array specifying active 
>> > > physical
>> > > MIPI-CSI2
>> > > +		    data input lanes and their mapping to 
>> > > logical lanes; the
>> > > +		    array's content is unused, only its 
>> > > length is meaningful;
>
> Btw. do note that you may get a warning due to this from the 
> CSI-2 bus
> property parsing code if the lane numbers are wrong.
>
>> > > +
>> > > +- fsl,csis-hs-settle : (optional) differential receiver 
>> > > (HS-RX)
>> > > settle time;
>> > 
>> > Could you calculate this, as other drivers do? It probably 
>> > changes
>> > depending on the device runtime configuration.
>> 
>> The only reference to possible values to this parameter is 
>> given by
>> table in [0], can you point me out the formula for imx7 in the
>> documentation?
>
> I don't know imx7 but the other CSI-2 drivers need no such 
> system specific
> configuration.

Hum, I think there is at least one more (which this is compliant) 
that
also use this configuration parameter. [0]

---
Cheers,
	Rui

[0]: 
https://github.com/torvalds/linux/blob/a048a07d7f4535baa4cbad6bc024f175317ab938/Documentation/devicetree/bindings/media/samsung-mipi-csis.txt#L46

  reply	other threads:[~2018-05-22 13:19 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17 12:50 [PATCH v4 00/12] media: staging/imx7: add i.MX7 media driver Rui Miguel Silva
2018-05-17 12:50 ` [PATCH v4 01/12] media: staging/imx: refactor imx media device probe Rui Miguel Silva
2018-05-17 12:50 ` [PATCH v4 02/12] media: staging/imx7: add imx7 CSI subdev driver Rui Miguel Silva
2018-05-17 12:50 ` [PATCH v4 03/12] clk: imx7d: fix mipi dphy div parent Rui Miguel Silva
2018-05-17 18:05   ` Stephen Boyd
2018-05-18  8:30     ` Rui Miguel Silva
2018-05-17 12:50 ` [PATCH v4 04/12] clk: imx7d: reset parent for mipi csi root Rui Miguel Silva
2018-05-17 12:50 ` [PATCH v4 05/12] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7 Rui Miguel Silva
2018-05-17 12:50 ` [PATCH v4 06/12] media: dt-bindings: add bindings for i.MX7 media driver Rui Miguel Silva
2018-05-18  6:58   ` Sakari Ailus
2018-05-18  8:27     ` Rui Miguel Silva
2018-05-18 22:13       ` Sakari Ailus
2018-05-22 13:19         ` Rui Miguel Silva [this message]
2018-05-22 14:08           ` Sakari Ailus
2019-03-10 21:48       ` Laurent Pinchart
2019-03-12 14:07         ` Rui Miguel Silva
2019-03-12 15:10           ` Laurent Pinchart
2019-03-12 15:37             ` Rui Miguel Silva
2018-05-17 12:50 ` [PATCH v4 07/12] ARM: dts: imx7s: add mipi phy power domain Rui Miguel Silva
2018-05-17 12:50 ` [PATCH v4 08/12] ARM: dts: imx7s: add multiplexer controls Rui Miguel Silva
2018-05-17 12:50 ` [PATCH v4 09/12] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections Rui Miguel Silva
2018-05-17 12:50 ` [PATCH v4 10/12] ARM: dts: imx7s-warp: add ov2680 sensor node Rui Miguel Silva
2018-05-17 12:50 ` [PATCH v4 11/12] media: imx7.rst: add documentation for i.MX7 media driver Rui Miguel Silva
2018-05-17 12:50 ` [PATCH v4 12/12] media: staging/imx: add i.MX7 entries to TODO file Rui Miguel Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m336yjvndy.fsf@gmail.com \
    --to=rmfrfs@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=rui.silva@linaro.org \
    --cc=ryan.harkin@linaro.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=shawnguo@kernel.org \
    --cc=slongerbeam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).