From: Rui Miguel Silva <rui.silva@linaro.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org,
sakari.ailus@linux.intel.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Steve Longerbeam <slongerbeam@gmail.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v9 01/13] media: staging/imx: refactor imx media device probe
Date: Fri, 07 Dec 2018 13:53:01 +0000 [thread overview]
Message-ID: <m37egl30le.fsf@linaro.org> (raw)
In-Reply-To: <b0fffeef-439b-e3a7-67d1-900a7ea1664f@xs4all.nl>
Hi Hans,
Thanks for the review.
On Fri 07 Dec 2018 at 12:38, Hans Verkuil wrote:
> On 11/22/2018 04:18 PM, Rui Miguel Silva wrote:
>> Refactor and move media device initialization code to a new
>> common
>> module, so it can be used by other devices, this will allow for
>> example
>> a near to introduce imx7 CSI driver, to use this media device.
>>
>> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
>> ---
>> drivers/staging/media/imx/Makefile | 1 +
>> .../staging/media/imx/imx-media-dev-common.c | 102
>> ++++++++++++++++++
>> drivers/staging/media/imx/imx-media-dev.c | 88
>> ++++-----------
>> drivers/staging/media/imx/imx-media-of.c | 6 +-
>> drivers/staging/media/imx/imx-media.h | 15 +++
>> 5 files changed, 141 insertions(+), 71 deletions(-)
>> create mode 100644
>> drivers/staging/media/imx/imx-media-dev-common.c
>>
>> diff --git a/drivers/staging/media/imx/Makefile
>> b/drivers/staging/media/imx/Makefile
>> index 698a4210316e..a30b3033f9a3 100644
>> --- a/drivers/staging/media/imx/Makefile
>> +++ b/drivers/staging/media/imx/Makefile
>> @@ -1,5 +1,6 @@
>> # SPDX-License-Identifier: GPL-2.0
>> imx-media-objs := imx-media-dev.o imx-media-internal-sd.o
>> imx-media-of.o
>> +imx-media-objs += imx-media-dev-common.o
>> imx-media-common-objs := imx-media-utils.o imx-media-fim.o
>> imx-media-ic-objs := imx-ic-common.o imx-ic-prp.o
>> imx-ic-prpencvf.o
>>
>> diff --git a/drivers/staging/media/imx/imx-media-dev-common.c
>> b/drivers/staging/media/imx/imx-media-dev-common.c
>> new file mode 100644
>> index 000000000000..55fe94fb72f2
>> --- /dev/null
>> +++ b/drivers/staging/media/imx/imx-media-dev-common.c
>> @@ -0,0 +1,102 @@
>> +// SPDX-License-Identifier: GPL
>
> This is an invalid SPDX license identifier. You probably want to
> use GPL-2.0.
hrr... you are right, I will update it here and others.
---
Cheers,
Rui
next prev parent reply other threads:[~2018-12-07 13:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 15:18 [PATCH v9 00/13] media: staging/imx7: add i.MX7 media driver Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 01/13] media: staging/imx: refactor imx media device probe Rui Miguel Silva
2018-12-07 12:38 ` Hans Verkuil
2018-12-07 13:53 ` Rui Miguel Silva [this message]
2018-11-22 15:18 ` [PATCH v9 02/13] media: staging/imx: rearrange group id to take in account IPU Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 03/13] media: staging/imx7: add imx7 CSI subdev driver Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 04/13] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7 Rui Miguel Silva
2018-12-03 12:10 ` Sakari Ailus
2018-12-05 9:48 ` Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 05/13] media: dt-bindings: add bindings for i.MX7 media driver Rui Miguel Silva
2018-12-07 12:39 ` Hans Verkuil
2018-12-07 13:54 ` Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 06/13] ARM: dts: imx7s: add mipi phy power domain Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 07/13] ARM: dts: imx7s: add multiplexer controls Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 08/13] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 09/13] ARM: dts: imx7s-warp: add ov2680 sensor node Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 10/13] media: imx7.rst: add documentation for i.MX7 media driver Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 11/13] media: staging/imx: add i.MX7 entries to TODO file Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 12/13] media: video-mux: add bayer formats Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 13/13] media: MAINTAINERS: add entry for Freescale i.MX7 media driver Rui Miguel Silva
2018-12-07 12:44 ` [PATCH v9 00/13] media: staging/imx7: add " Hans Verkuil
2018-12-07 13:38 ` Dan Carpenter
2018-12-07 14:01 ` Rui Miguel Silva
2019-01-18 16:49 ` Fabio Estevam
2019-01-18 18:28 ` Rui Miguel Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37egl30le.fsf@linaro.org \
--to=rui.silva@linaro.org \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).