From: "Krzysztof Hałasa" <khalasa@piap.pl>
To: Rob Herring <robh+dt@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: devicetree@vger.kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sakari Ailus <sakari.ailus@iki.fi>,
Jacopo Mondi <jacopo@jmondi.org>
Subject: [PATCH v6 0/2] On Semi AR0521 sensor driver
Date: Thu, 23 Dec 2021 07:54:33 +0100 [thread overview]
Message-ID: <m3ee63hkuu.fsf@t19.piap.pl> (raw)
Rob, Mauro, media subsystem reviewers,
This is the 6th version of my On Semi AR0521 sensor driver.
The documentation patch (1/2) hasn't been changed from v4:
onnn,ar0521.yaml | 112
1 file changed, 112 insertions(+)
The actual driver (2/2) changes:
MAINTAINERS | 7
drivers/media/i2c/Kconfig | 13
drivers/media/i2c/Makefile | 1
drivers/media/i2c/ar0521.c | 1051
4 files changed, 1072 insertions(+)
- I reformatted the code to fit in 80 columns. Nobody should be asked to
make his code worse (and the 80-column version IS worse), and multiple
high-profile Linux developers (including the top one) appear to share
my opinion, but nevertheless - if it's something that will make it go
in, I won't care.
- Basically the same applies to the // comments.
- I have removed the "interval" support (frames per second).
Unfortunately this cripples the driver further a bit - the userspace
will not be able to set precise frame timings needed for broadcast
quality video. I will have to keep a private patch for that.
Another effect of this change is that the pixel clock is now fixed at
184 MHz, which by default produces ca. 30 FPS at 2560x1920. This may
be problematic on systems with less than 4 MIPI lanes, and/or on ones
which can't support higher frequency MIPI bus (the previous version
used a calculated clock). Perhaps it will be possible to fix this
issue in the future, with a couple of core V4L2 changes.
- the driver now provides the .pre_streamon() for setting LP-11 state on
MIPI data and clock lanes. This is compatible with i.MX6 receiver.
- s_power() converted to SET_RUNTIME_PM_OPS().
- the "initial" I2C registers have been all converted to a table of
multi-register files, to minimize time spent on I2C bus.
- a lot of smaller changes suggested by Laurent, Sakari, Jacopo and
possibly others.
--
Krzysztof "Chris" Hałasa
Sieć Badawcza Łukasiewicz
Przemysłowy Instytut Automatyki i Pomiarów PIAP
Al. Jerozolimskie 202, 02-486 Warszawa
next reply other threads:[~2021-12-23 7:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 6:54 Krzysztof Hałasa [this message]
2021-12-23 6:57 ` [PATCH v6 1/2] dt-binding: media: document ON Semi AR0521 sensor bindings Krzysztof Hałasa
2021-12-23 7:06 ` [PATCH v6 2/2] Driver for ON Semi AR0521 camera sensor Krzysztof Hałasa
2021-12-23 17:49 ` Joe Perches
2021-12-23 18:48 ` Jacopo Mondi
2021-12-23 19:19 ` Joe Perches
2021-12-23 20:13 ` Joe Perches
2021-12-23 20:27 ` Joe Perches
2021-12-24 9:22 ` Jacopo Mondi
2021-12-24 12:30 ` Joe Perches
2021-12-29 15:05 ` Krzysztof Hałasa
2021-12-29 14:11 ` Krzysztof Hałasa
2021-12-31 23:14 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ee63hkuu.fsf@t19.piap.pl \
--to=khalasa@piap.pl \
--cc=devicetree@vger.kernel.org \
--cc=jacopo@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).