From: Rui Miguel Silva <rui.silva@linaro.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: hverkuil-cisco@xs4all.nl, slongerbeam@gmail.com,
p.zabel@pengutronix.de, linux-media@vger.kernel.org,
sebastien.szymanski@armadeus.com, otavio@ossystems.com.br,
robh+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/8] media: dt-bindings: imx7-csi: Document a single CSI clock
Date: Mon, 06 May 2019 22:21:40 +0100 [thread overview]
Message-ID: <m3ef5b5lej.fsf@linaro.org> (raw)
In-Reply-To: <20190504144027.31920-6-festevam@gmail.com>
Oi Fabio,
On Sat 04 May 2019 at 15:40, Fabio Estevam wrote:
> As per the i.MX7D Reference Manual only the MCLK is used for
> the CSI block, so only document this single clock.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
You missed to add a cover-letter to the series, but I have tested
it and reviewed on top of Steve series [0] and everything looks good.
Thanks for fixes.
For the all series:
Tested-by: Rui Miguel Silva <rmfrfs@gmail.com>
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
---
Cheers,
Rui
[0]: https://lore.kernel.org/linux-media/20190503224326.21039-1-slongerbeam@gmail.com/
> ---
> Documentation/devicetree/bindings/media/imx7-csi.txt | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/imx7-csi.txt b/Documentation/devicetree/bindings/media/imx7-csi.txt
> index 3c07bc676bc3..443aef07356e 100644
> --- a/Documentation/devicetree/bindings/media/imx7-csi.txt
> +++ b/Documentation/devicetree/bindings/media/imx7-csi.txt
> @@ -14,8 +14,7 @@ Required properties:
> - interrupts : should contain CSI interrupt;
> - clocks : list of clock specifiers, see
> Documentation/devicetree/bindings/clock/clock-bindings.txt for details;
> -- clock-names : must contain "axi", "mclk" and "dcic" entries, matching
> - entries in the clock property;
> +- clock-names : must contain "mclk";
>
> The device node shall contain one 'port' child node with one child 'endpoint'
> node, according to the bindings defined in:
> @@ -32,10 +31,8 @@ example:
> compatible = "fsl,imx7-csi";
> reg = <0x30710000 0x10000>;
> interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clks IMX7D_CLK_DUMMY>,
> - <&clks IMX7D_CSI_MCLK_ROOT_CLK>,
> - <&clks IMX7D_CLK_DUMMY>;
> - clock-names = "axi", "mclk", "dcic";
> + clocks = <&clks IMX7D_CSI_MCLK_ROOT_CLK>;
> + clock-names = "mclk";
>
> port {
> csi_from_csi_mux: endpoint {
next prev parent reply other threads:[~2019-05-06 21:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 14:40 [PATCH 2/8] media: imx7-media-csi: Acquire a single clock Fabio Estevam
2019-05-04 14:40 ` [PATCH 3/8] media: imx7-media-csi: Use devm_platform_ioremap_resource() Fabio Estevam
2019-05-04 14:40 ` [PATCH 4/8] media: imx7-media-csi: Propagate the correct error for platform_get_irq() Fabio Estevam
2019-05-04 14:40 ` [PATCH 5/8] media: imx7-media-csi: Propagate the correct error for devm_request_irq() Fabio Estevam
2019-05-04 14:40 ` [PATCH 6/8] media: imx7-media-csi: Remove unneeded break Fabio Estevam
2019-05-04 14:40 ` [PATCH 1/8] media: dt-bindings: imx7-csi: Document a single CSI clock Fabio Estevam
2019-05-06 21:21 ` Rui Miguel Silva [this message]
2019-05-27 20:18 ` Fabio Estevam
2019-06-13 18:07 ` Rob Herring
2019-05-04 14:40 ` [PATCH 7/8] media: imx7-media-csi: Check the return value from clk_prepare_enable() Fabio Estevam
2019-05-04 14:40 ` [PATCH 8/8] media: imx7-media-csi: Change imx7_csi_enable() to void Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ef5b5lej.fsf@linaro.org \
--to=rui.silva@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=otavio@ossystems.com.br \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sebastien.szymanski@armadeus.com \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).