[PATCH 1/2] ARM: dts: imx6ul: Add csi node

[PATCH 1/2] ARM: dts: imx6ul: Add csi node

[Sébastien Szymanski]

Add csi node for i.MX6UL SoC.

Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
---
 arch/arm/boot/dts/imx6ul.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
index 62ed30c781ed..af322bc58333 100644
--- a/arch/arm/boot/dts/imx6ul.dtsi
+++ b/arch/arm/boot/dts/imx6ul.dtsi
@@ -951,6 +951,17 @@
 				};
 			};
 
+			csi: csi@21c4000 {
+				compatible = "fsl,imx6ul-csi", "fsl,imx7-csi";
+				reg = <0x021c4000 0x4000>;
+				interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&clks IMX6UL_CLK_DUMMY>,
+					 <&clks IMX6UL_CLK_CSI>,
+					 <&clks IMX6UL_CLK_DUMMY>;
+				clock-names = "axi", "mclk", "dcic";
+				status = "disabled";
+			};
+
 			lcdif: lcdif@21c8000 {
 				compatible = "fsl,imx6ul-lcdif", "fsl,imx28-lcdif";
 				reg = <0x021c8000 0x4000>;
-- 
2.19.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] ARM: dts: imx6ul: Add csi node

[Fabio Estevam]

Hi Sébastien,

On Tue, Apr 30, 2019 at 4:47 AM Sébastien Szymanski
<sebastien.szymanski@armadeus.com> wrote:

> +                       csi: csi@21c4000 {
> +                               compatible = "fsl,imx6ul-csi", "fsl,imx7-csi";

After adding "fsl,imx6ul-csi" to
Documentation/devicetree/bindings/media/imx7-csi.txt:

Reviewed-by: Fabio Estevam <festevam@gmail.com>

Re: [PATCH 1/2] ARM: dts: imx6ul: Add csi node

[Fabio Estevam]

[Adding Rui]

On Tue, Apr 30, 2019 at 4:47 AM Sébastien Szymanski
<sebastien.szymanski@armadeus.com> wrote:
>
> Add csi node for i.MX6UL SoC.
>
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
>  arch/arm/boot/dts/imx6ul.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> index 62ed30c781ed..af322bc58333 100644
> --- a/arch/arm/boot/dts/imx6ul.dtsi
> +++ b/arch/arm/boot/dts/imx6ul.dtsi
> @@ -951,6 +951,17 @@
>                                 };
>                         };
>
> +                       csi: csi@21c4000 {
> +                               compatible = "fsl,imx6ul-csi", "fsl,imx7-csi";
> +                               reg = <0x021c4000 0x4000>;
> +                               interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> +                               clocks = <&clks IMX6UL_CLK_DUMMY>,
> +                                        <&clks IMX6UL_CLK_CSI>,
> +                                        <&clks IMX6UL_CLK_DUMMY>;
> +                               clock-names = "axi", "mclk", "dcic";

Also, I understand you followed
Documentation/devicetree/bindings/media/imx7-csi.txt and passed these
three clocks, but looking at the i.MX7D and i.MX6UL/ULL Reference
Manuals, I don't find the  the descriptions for the "axi" and "dcic"
CSI clocks.

It looks like that only "mclk" is what we really need here.

Should we change the bindings and the imx7-csi driver to not request
"axi" and "dcic" clocks?

Rui, what do you think? If you agree I can send a fix for this.

Thanks

Re: [PATCH 1/2] ARM: dts: imx6ul: Add csi node

[Rui Miguel Silva]

Oi Fabio,
On Thu 02 May 2019 at 16:28, Fabio Estevam wrote:
> [Adding Rui]
>
> On Tue, Apr 30, 2019 at 4:47 AM Sébastien Szymanski
> <sebastien.szymanski@armadeus.com> wrote:
>>
>> Add csi node for i.MX6UL SoC.
>>
>> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
>> ---
>>  arch/arm/boot/dts/imx6ul.dtsi | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
>> index 62ed30c781ed..af322bc58333 100644
>> --- a/arch/arm/boot/dts/imx6ul.dtsi
>> +++ b/arch/arm/boot/dts/imx6ul.dtsi
>> @@ -951,6 +951,17 @@
>>                                 };
>>                         };
>>
>> +                       csi: csi@21c4000 {
>> +                               compatible = "fsl,imx6ul-csi", "fsl,imx7-csi";
>> +                               reg = <0x021c4000 0x4000>;
>> +                               interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
>> +                               clocks = <&clks IMX6UL_CLK_DUMMY>,
>> +                                        <&clks IMX6UL_CLK_CSI>,
>> +                                        <&clks IMX6UL_CLK_DUMMY>;
>> +                               clock-names = "axi", "mclk", "dcic";
>
> Also, I understand you followed
> Documentation/devicetree/bindings/media/imx7-csi.txt and passed these
> three clocks, but looking at the i.MX7D and i.MX6UL/ULL Reference
> Manuals, I don't find the  the descriptions for the "axi" and "dcic"
> CSI clocks.
>
> It looks like that only "mclk" is what we really need here.

Yeah, you are right.

>
> Should we change the bindings and the imx7-csi driver to not request
> "axi" and "dcic" clocks?
>
> Rui, what do you think? If you agree I can send a fix for this.

If you please, that would be great. thanks.

---
Cheers,
	Rui