From: Rui Miguel Silva <rui.silva@linaro.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 3/5] ARM: dts: imx7s: Add video mux, csi and mipi_csi
Date: Thu, 04 Apr 2019 05:10:21 +0100 [thread overview]
Message-ID: <m3ftqyfm1e.fsf@linaro.org> (raw)
In-Reply-To: <20190403101114.GC12646@pendragon.ideasonboard.com>
Hi Laurent,
On Wed 03 Apr 2019 at 11:11, Laurent Pinchart wrote:
> Hi Rui,
>
> Thank you for the patch.
>
> On Thu, Mar 28, 2019 at 02:25:14PM +0000, Rui Miguel Silva
> wrote:
>> Add device tree nodes for csi, video multiplexer and mipi-csi.
>>
>> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
>> ---
>> arch/arm/boot/dts/imx7s.dtsi | 75
>> ++++++++++++++++++++++++++++++++++++
>> 1 file changed, 75 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx7s.dtsi
>> b/arch/arm/boot/dts/imx7s.dtsi
>> index 792efcd2caa1..3286838105c6 100644
>> --- a/arch/arm/boot/dts/imx7s.dtsi
>> +++ b/arch/arm/boot/dts/imx7s.dtsi
>> @@ -8,6 +8,7 @@
>> #include <dt-bindings/gpio/gpio.h>
>> #include <dt-bindings/input/input.h>
>> #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +#include <dt-bindings/reset/imx7-reset.h>
>> #include "imx7d-pinfunc.h"
>>
>> / {
>> @@ -506,6 +507,34 @@
>> #mux-control-cells = <0>;
>> mux-reg-masks = <0x14
>> 0x00000010>;
>> };
>> +
>> + video_mux: csi-mux {
>
> I wonder if the node should be renamed from csi-mux to
> video-mux, and
> possibly the label from video_mux to csi_mux (video_mux is a bit
> generic
> and may lead to name clashes). Apart from that,
>
> Reviewed-by: Laurent Pinchart
> <laurent.pinchart@ideasonboard.com>
Thanks for the review.
---
Cheers,
Rui
>
>> + compatible = "video-mux";
>> + mux-controls = <&mux 0>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + status = "disabled";
>> +
>> + port@0 {
>> + reg = <0>;
>> + };
>> +
>> + port@1 {
>> + reg = <1>;
>> +
>> +
>> csi_mux_from_mipi_vc0: endpoint {
>> +
>> remote-endpoint = <&mipi_vc0_to_csi_mux>;
>> + };
>> + };
>> +
>> + port@2 {
>> + reg = <2>;
>> +
>> + csi_mux_to_csi:
>> endpoint {
>> +
>> remote-endpoint = <&csi_from_csi_mux>;
>> + };
>> + };
>> + };
>> };
>>
>> ocotp: ocotp-ctrl@30350000 {
>> @@ -709,6 +738,23 @@
>> status = "disabled";
>> };
>>
>> + csi: csi@30710000 {
>> + compatible = "fsl,imx7-csi";
>> + reg = <0x30710000 0x10000>;
>> + interrupts = <GIC_SPI 7
>> IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&clks IMX7D_CLK_DUMMY>,
>> + <&clks
>> IMX7D_CSI_MCLK_ROOT_CLK>,
>> + <&clks IMX7D_CLK_DUMMY>;
>> + clock-names = "axi", "mclk",
>> "dcic";
>> + status = "disabled";
>> +
>> + port {
>> + csi_from_csi_mux: endpoint
>> {
>> + remote-endpoint =
>> <&csi_mux_to_csi>;
>> + };
>> + };
>> + };
>> +
>> lcdif: lcdif@30730000 {
>> compatible = "fsl,imx7d-lcdif",
>> "fsl,imx28-lcdif";
>> reg = <0x30730000 0x10000>;
>> @@ -718,6 +764,35 @@
>> clock-names = "pix", "axi";
>> status = "disabled";
>> };
>> +
>> + mipi_csi: mipi-csi@30750000 {
>> + compatible = "fsl,imx7-mipi-csi2";
>> + reg = <0x30750000 0x10000>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + interrupts = <GIC_SPI 25
>> IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&clks
>> IMX7D_IPG_ROOT_CLK>,
>> + <&clks
>> IMX7D_MIPI_CSI_ROOT_CLK>,
>> + <&clks
>> IMX7D_MIPI_DPHY_ROOT_CLK>;
>> + clock-names = "pclk", "wrap",
>> "phy";
>> + power-domains = <&pgc_mipi_phy>;
>> + phy-supply = <®_1p0d>;
>> + resets = <&src
>> IMX7_RESET_MIPI_PHY_MRST>;
>> + reset-names = "mrst";
>> + status = "disabled";
>> +
>> + port@0 {
>> + reg = <0>;
>> + };
>> +
>> + port@1 {
>> + reg = <1>;
>> +
>> + mipi_vc0_to_csi_mux:
>> endpoint {
>> + remote-endpoint =
>> <&csi_mux_from_mipi_vc0>;
>> + };
>> + };
>> + };
>> };
>>
>> aips3: aips-bus@30800000 {
next prev parent reply other threads:[~2019-04-04 4:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 14:25 [PATCH v3 0/5] ARM: imx7s: add media nodes Rui Miguel Silva
2019-03-28 14:25 ` [PATCH v3 1/5] ARM: dts: imx7s: add mipi phy power domain Rui Miguel Silva
2019-03-28 14:25 ` [PATCH v3 2/5] ARM: dts: imx7s: add multiplexer controls Rui Miguel Silva
2019-03-28 14:25 ` [PATCH v3 3/5] ARM: dts: imx7s: Add video mux, csi and mipi_csi Rui Miguel Silva
2019-04-03 10:11 ` Laurent Pinchart
2019-04-04 4:10 ` Rui Miguel Silva [this message]
2019-03-28 14:25 ` [PATCH v3 4/5] ARM: dts: imx7s-warp: add csi and mipi_csi node Rui Miguel Silva
2019-03-28 14:25 ` [PATCH v3 5/5] ARM: dts: imx7s-warp: add ov2680 sensor node Rui Miguel Silva
2019-04-03 10:15 ` [PATCH v3 0/5] ARM: imx7s: add media nodes Laurent Pinchart
2019-04-04 4:22 ` Rui Miguel Silva
2019-04-11 2:24 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ftqyfm1e.fsf@linaro.org \
--to=rui.silva@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).