From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Blin Subject: Re: [PATCH v2 1/2] ARM: bcm2835: dt: Add the ethernet to the device trees Date: Fri, 05 Feb 2016 15:25:01 +0100 Message-ID: References: <1454571364-24708-1-git-send-email-lkundrak@v3.sk> <1454571364-24708-2-git-send-email-lkundrak@v3.sk> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1454571364-24708-2-git-send-email-lkundrak-NGH9Lh4a5iE@public.gmane.org> (Lubomir Rintel's message of "Thu, 4 Feb 2016 08:36:03 +0100") Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lubomir Rintel Cc: linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Arnd Bergmann , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Peter Chen , Stephen Warren , popcornmix List-Id: devicetree@vger.kernel.org Lubomir Rintel writes: > diff --git a/arch/arm/boot/dts/bcm2836-rpi-2-b.dts b/arch/arm/boot/dts/bcm2836-rpi-2-b.dts [...] > @@ -33,3 +37,17 @@ > brcm,function = ; > }; > }; > + > +&usb { > + usb1@1 { > + compatible = "usb0424,9514"; > + reg = <01>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethernet: usbether@1 { > + compatible = "usb0424,ec00"; > + reg = <01>; > + }; > + }; > +}; Hi, This works for me, after making sure that your u-boot patch gets a chance to be run (unset usbethaddr from u-boot). Though, I am not really DT-literate, but shouldn't the ethernet block use the PID from the ethernet device? The usbether device is 9514 on RPi2, while ec00 is the hub. Your patch works, but this works as well after swapping the PIDs. Thanks -- Olivier Blin - blino -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html