* [PATCH 1/2] media: ov2680: dt: Add bindings for OV2680 [not found] <20180222102338.28896-1-rui.silva@linaro.org> @ 2018-02-22 10:23 ` Rui Miguel Silva 2018-02-22 10:59 ` Sakari Ailus 2018-02-22 11:31 ` Fabio Estevam 0 siblings, 2 replies; 5+ messages in thread From: Rui Miguel Silva @ 2018-02-22 10:23 UTC (permalink / raw) To: mchehab, sakari.ailus, hverkuil Cc: linux-media, linux-kernel, Ryan Harkin, Rui Miguel Silva, devicetree Add device tree binding documentation for the OV5640 camera sensor. CC: devicetree@vger.kernel.org Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> --- .../devicetree/bindings/media/i2c/ov2680.txt | 34 ++++++++++++++++++++++ 1 file changed, 34 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ov2680.txt diff --git a/Documentation/devicetree/bindings/media/i2c/ov2680.txt b/Documentation/devicetree/bindings/media/i2c/ov2680.txt new file mode 100644 index 000000000000..f9dc63ce5044 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/ov2680.txt @@ -0,0 +1,34 @@ +* Omnivision OV2680 MIPI CSI-2 sensor + +Required Properties: +- compatible: should be "ovti,ov2680" +- clocks: reference to the xvclk input clock. +- clock-names: should be "xvclk". + +Optional Properties: +- powerdown-gpios: reference to the GPIO connected to the powerdown pin, + if any. This is an active high signal to the OV2680. + +The device node must contain one 'port' child node for its digital output +video port, in accordance with the video interface bindings defined in +Documentation/devicetree/bindings/media/video-interfaces.txt. + +Example: + +&i2c2 { + ov2680: camera-sensor@36 { + compatible = "ovti,ov2680"; + reg = <0x36>; + clocks = <&osc>; + clock-names = "xvclk"; + powerdown-gpios = <&gpio1 3 GPIO_ACTIVE_HIGH>; + + port { + ov2680_mipi_ep: endpoint { + remote-endpoint = <&mipi_sensor_ep>; + clock-lanes = <0>; + data-lanes = <1>; + }; + }; + }; +}; -- 2.16.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] media: ov2680: dt: Add bindings for OV2680 2018-02-22 10:23 ` [PATCH 1/2] media: ov2680: dt: Add bindings for OV2680 Rui Miguel Silva @ 2018-02-22 10:59 ` Sakari Ailus 2018-02-23 14:56 ` Rui Miguel Silva 2018-02-22 11:31 ` Fabio Estevam 1 sibling, 1 reply; 5+ messages in thread From: Sakari Ailus @ 2018-02-22 10:59 UTC (permalink / raw) To: Rui Miguel Silva Cc: mchehab, hverkuil, linux-media, linux-kernel, Ryan Harkin, Rui Miguel Silva, devicetree Hi Rui, Thanks for the patchset. Could you use "dt: bindings: " prefix in the subject? On Thu, Feb 22, 2018 at 10:23:37AM +0000, Rui Miguel Silva wrote: > Add device tree binding documentation for the OV5640 camera sensor. > > CC: devicetree@vger.kernel.org > Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> > --- > .../devicetree/bindings/media/i2c/ov2680.txt | 34 ++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov2680.txt > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov2680.txt b/Documentation/devicetree/bindings/media/i2c/ov2680.txt > new file mode 100644 > index 000000000000..f9dc63ce5044 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/ov2680.txt > @@ -0,0 +1,34 @@ > +* Omnivision OV2680 MIPI CSI-2 sensor > + > +Required Properties: > +- compatible: should be "ovti,ov2680" > +- clocks: reference to the xvclk input clock. > +- clock-names: should be "xvclk". > + > +Optional Properties: > +- powerdown-gpios: reference to the GPIO connected to the powerdown pin, > + if any. This is an active high signal to the OV2680. > + > +The device node must contain one 'port' child node for its digital output Please add that the port contains a single endpoint as well. > +video port, in accordance with the video interface bindings defined in > +Documentation/devicetree/bindings/media/video-interfaces.txt. Please list required and optional endpoint properties as well. > + > +Example: > + > +&i2c2 { > + ov2680: camera-sensor@36 { > + compatible = "ovti,ov2680"; > + reg = <0x36>; > + clocks = <&osc>; > + clock-names = "xvclk"; > + powerdown-gpios = <&gpio1 3 GPIO_ACTIVE_HIGH>; > + > + port { > + ov2680_mipi_ep: endpoint { > + remote-endpoint = <&mipi_sensor_ep>; > + clock-lanes = <0>; > + data-lanes = <1>; > + }; > + }; > + }; > +}; -- Regards, Sakari Ailus sakari.ailus@linux.intel.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] media: ov2680: dt: Add bindings for OV2680 2018-02-22 10:59 ` Sakari Ailus @ 2018-02-23 14:56 ` Rui Miguel Silva 0 siblings, 0 replies; 5+ messages in thread From: Rui Miguel Silva @ 2018-02-23 14:56 UTC (permalink / raw) To: Sakari Ailus Cc: mchehab, hverkuil, linux-media, linux-kernel, Ryan Harkin, Rui Miguel Silva, devicetree Hi Sakari, Thanks for the review. On Thu 22 Feb 2018 at 10:59, Sakari Ailus wrote: > Hi Rui, > > Thanks for the patchset. > > Could you use "dt: bindings: " prefix in the subject? Sure, no problem. > > On Thu, Feb 22, 2018 at 10:23:37AM +0000, Rui Miguel Silva > wrote: >> Add device tree binding documentation for the OV5640 camera >> sensor. >> >> CC: devicetree@vger.kernel.org >> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> >> --- >> .../devicetree/bindings/media/i2c/ov2680.txt | 34 >> ++++++++++++++++++++++ >> 1 file changed, 34 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/media/i2c/ov2680.txt >> >> diff --git >> a/Documentation/devicetree/bindings/media/i2c/ov2680.txt >> b/Documentation/devicetree/bindings/media/i2c/ov2680.txt >> new file mode 100644 >> index 000000000000..f9dc63ce5044 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/i2c/ov2680.txt >> @@ -0,0 +1,34 @@ >> +* Omnivision OV2680 MIPI CSI-2 sensor >> + >> +Required Properties: >> +- compatible: should be "ovti,ov2680" >> +- clocks: reference to the xvclk input clock. >> +- clock-names: should be "xvclk". >> + >> +Optional Properties: >> +- powerdown-gpios: reference to the GPIO connected to the >> powerdown pin, >> + if any. This is an active high signal to the >> OV2680. >> + >> +The device node must contain one 'port' child node for its >> digital output > > Please add that the port contains a single endpoint as well. Ack. > >> +video port, in accordance with the video interface bindings >> defined in >> +Documentation/devicetree/bindings/media/video-interfaces.txt. > > Please list required and optional endpoint properties as well. OK. --- Cheers, Rui > >> + >> +Example: >> + >> +&i2c2 { >> + ov2680: camera-sensor@36 { >> + compatible = "ovti,ov2680"; >> + reg = <0x36>; >> + clocks = <&osc>; >> + clock-names = "xvclk"; >> + powerdown-gpios = <&gpio1 3 GPIO_ACTIVE_HIGH>; >> + >> + port { >> + ov2680_mipi_ep: endpoint { >> + remote-endpoint = >> <&mipi_sensor_ep>; >> + clock-lanes = <0>; >> + data-lanes = <1>; >> + }; >> + }; >> + }; >> +}; ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] media: ov2680: dt: Add bindings for OV2680 2018-02-22 10:23 ` [PATCH 1/2] media: ov2680: dt: Add bindings for OV2680 Rui Miguel Silva 2018-02-22 10:59 ` Sakari Ailus @ 2018-02-22 11:31 ` Fabio Estevam 2018-02-23 14:57 ` Rui Miguel Silva 1 sibling, 1 reply; 5+ messages in thread From: Fabio Estevam @ 2018-02-22 11:31 UTC (permalink / raw) To: Rui Miguel Silva Cc: Mauro Carvalho Chehab, Sakari Ailus, Hans Verkuil, linux-media, linux-kernel, Ryan Harkin, Rui Miguel Silva, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS On Thu, Feb 22, 2018 at 7:23 AM, Rui Miguel Silva <rmfrfs@gmail.com> wrote: > Add device tree binding documentation for the OV5640 camera sensor. s/OV5640/OV2680 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] media: ov2680: dt: Add bindings for OV2680 2018-02-22 11:31 ` Fabio Estevam @ 2018-02-23 14:57 ` Rui Miguel Silva 0 siblings, 0 replies; 5+ messages in thread From: Rui Miguel Silva @ 2018-02-23 14:57 UTC (permalink / raw) To: Fabio Estevam Cc: Mauro Carvalho Chehab, Sakari Ailus, Hans Verkuil, linux-media, linux-kernel, Ryan Harkin, Rui Miguel Silva, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS Hi Fabio, On Thu 22 Feb 2018 at 11:31, Fabio Estevam wrote: > On Thu, Feb 22, 2018 at 7:23 AM, Rui Miguel Silva > <rmfrfs@gmail.com> wrote: >> Add device tree binding documentation for the OV5640 camera >> sensor. > > s/OV5640/OV2680 Thanks for notice this ;). --- Cheers, Rui ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-23 14:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180222102338.28896-1-rui.silva@linaro.org>
2018-02-22 10:23 ` [PATCH 1/2] media: ov2680: dt: Add bindings for OV2680 Rui Miguel Silva
2018-02-22 10:59 ` Sakari Ailus
2018-02-23 14:56 ` Rui Miguel Silva
2018-02-22 11:31 ` Fabio Estevam
2018-02-23 14:57 ` Rui Miguel Silva
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).