From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rui Miguel Silva <rmfrfs@gmail.com>
Subject: Re: [PATCH v2 06/15] media: staging/imx: add imx7 capture subsystem
Date: Tue, 24 Apr 2018 09:46:22 +0100
Message-ID: <m3tvs1dmap.fsf@gmail.com>
References: <20180423134750.30403-1-rui.silva@linaro.org>
 <20180423134750.30403-7-rui.silva@linaro.org>
 <1524498503.3396.5.camel@pengutronix.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <driverdev-devel-bounces@linuxdriverproject.org>
In-reply-to: <1524498503.3396.5.camel@pengutronix.de>
List-Unsubscribe: <http://driverdev.linuxdriverproject.org/mailman/options/driverdev-devel>,
 <mailto:driverdev-devel-request@linuxdriverproject.org?subject=unsubscribe>
List-Archive: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/>
List-Post: <mailto:driverdev-devel@linuxdriverproject.org>
List-Help: <mailto:driverdev-devel-request@linuxdriverproject.org?subject=help>
List-Subscribe: <http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel>,
 <mailto:driverdev-devel-request@linuxdriverproject.org?subject=subscribe>
Errors-To: driverdev-devel-bounces@linuxdriverproject.org
Sender: "devel" <driverdev-devel-bounces@linuxdriverproject.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Ryan Harkin <ryan.harkin@linaro.org>, Rob Herring <robh+dt@kernel.org>, Rui Miguel Silva <rui.silva@linaro.org>, sakari.ailus@linux.intel.com, Steve Longerbeam <slongerbeam@gmail.com>, Fabio Estevam <fabio.estevam@nxp.com>, mchehab@kernel.org, Shawn Guo <shawnguo@kernel.org>, linux-media@vger.kernel.org
List-Id: devicetree@vger.kernel.org

Hi Philipp,
On Mon 23 Apr 2018 at 15:48, Philipp Zabel wrote:
> On Mon, 2018-04-23 at 14:47 +0100, Rui Miguel Silva wrote:
>> Add imx7 capture subsystem to imx-media core to allow the use 
>> some of the
>> existing modules for i.MX5/6 with i.MX7 SoC.
>> 
>> Since i.MX7 does not have an IPU unset the ipu_present flag to 
>> differentiate
>> some runtime behaviors.
>> 
>> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
>> ---
>>  drivers/staging/media/imx/imx-media-dev.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>> 
>> diff --git a/drivers/staging/media/imx/imx-media-dev.c 
>> b/drivers/staging/media/imx/imx-media-dev.c
>> index c0f277adeebe..be68235c4caa 100644
>> --- a/drivers/staging/media/imx/imx-media-dev.c
>> +++ b/drivers/staging/media/imx/imx-media-dev.c
>> @@ -486,6 +486,9 @@ static int imx_media_probe(struct 
>> platform_device *pdev)
>>  
>>  	imxmd->ipu_present = true;
>>  
>> +	if (of_device_is_compatible(node, 
>> "fsl,imx7-capture-subsystem"))
>> +		imxmd->ipu_present = false;
>> +
>
> Is this something of_match_device should be used for?

Yeah, good point. I will develop your suggestion.

---
Cheers,
	Rui

>
>>  	if (imxmd->ipu_present) {
>>  		ret = imx_media_add_internal_subdevs(imxmd);
>>  		if (ret) {
>> @@ -543,6 +546,7 @@ static int imx_media_remove(struct 
>> platform_device *pdev)
>>  
>>  static const struct of_device_id imx_media_dt_ids[] = {
>>  	{ .compatible = "fsl,imx-capture-subsystem" },
>> +	{ .compatible = "fsl,imx7-capture-subsystem" },
>>  	{ /* sentinel */ }
>>  };
>>  MODULE_DEVICE_TABLE(of, imx_media_dt_ids);
>
> regards
> Philipp
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel