From: Rui Miguel Silva <rui.silva@linaro.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Rui Miguel Silva <rui.silva@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
linux-media <linux-media@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Ryan Harkin <ryan.harkin@linaro.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680
Date: Mon, 23 Apr 2018 16:09:55 +0100 [thread overview]
Message-ID: <m3wowydkn0.fsf@linaro.org> (raw)
In-Reply-To: <CAOMZO5A3+WMu+U5STP-z3qdXnUQN2yTJne2OV9-SrEs70JJyDA@mail.gmail.com>
Hi Fabio,
Thanks for the review.
On Mon 23 Apr 2018 at 14:11, Fabio Estevam wrote:
> Hi Rui,
>
> On Thu, Apr 19, 2018 at 8:00 AM, Rui Miguel Silva
> <rui.silva@linaro.org> wrote:
>
>> +Optional Properties:
>> +- powerdown-gpios: reference to the GPIO connected to the
>> powerdown pin,
>> + if any. This is an active high signal to
>> the OV2680.
>
> I looked at the OV2680 datasheet and I see a pin called XSHUTDN,
> which has
> the following description:
>
> XSHUTDN: reset and power down (active low with internal pull
> down resistor)
>
> So it should be active low, not active high.
Yes, you are correct, I will fix this, and the dts entry.
Thanks.
---
Cheers,
Rui
next prev parent reply other threads:[~2018-04-23 15:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180419110056.10342-1-rui.silva@linaro.org>
2018-04-19 11:00 ` [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680 Rui Miguel Silva
2018-04-23 14:11 ` Fabio Estevam
2018-04-23 15:09 ` Rui Miguel Silva [this message]
2018-04-23 15:58 ` Fabio Estevam
2018-04-24 15:53 ` Fabio Estevam
2018-04-24 16:11 ` Rui Miguel Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3wowydkn0.fsf@linaro.org \
--to=rui.silva@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ryan.harkin@linaro.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).