From: Rui Miguel Silva <rui.silva@linaro.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Philipp Zabel <p.zabel@pengutronix.de>,
Steve Longerbeam <slongerbeam@gmail.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v12 00/13] media: staging/imx7: add i.MX7 media driver
Date: Tue, 05 Feb 2019 11:53:11 +0000 [thread overview]
Message-ID: <m3y36u3108.fsf@linaro.org> (raw)
In-Reply-To: <20190205111435.2oz46dqphfdt6mn5@kekkonen.localdomain>
Hi Sakari,
On Tue 05 Feb 2019 at 11:14, Sakari Ailus wrote:
> Hi Rui,
>
> On Mon, Feb 04, 2019 at 12:00:26PM +0000, Rui Miguel Silva
> wrote:
>> Hi,
>> This series introduces the Media driver to work with the i.MX7
>> SoC. it uses the
>> already existing imx media core drivers but since the i.MX7,
>> contrary to
>> i.MX5/6, do not have an IPU and because of that some changes in
>> the imx media
>> core are made along this series to make it support that case.
>>
>> This patches adds CSI and MIPI-CSI2 drivers for i.MX7, along
>> with several
>> configurations changes for this to work as a capture subsystem.
>> Some bugs are
>> also fixed along the line. And necessary documentation.
>>
>> For a more detailed view of the capture paths, pads links in
>> the i.MX7 please
>> take a look at the documentation in PATCH 10.
>>
>> The system used to test and develop this was the Warp7 board
>> with an OV2680
>> sensor, which output format is 10-bit bayer. So, only MIPI
>> interface was
>> tested, a scenario with an parallel input would nice to have.
>>
>> Bellow goes an example of the output of the pads and links and
>> the output of
>> v4l2-compliance testing.
>>
>> The v4l-utils version used is:
>> v4l2-compliance SHA: 1a6c8fe9a65c26e78ba34bd4aa2df28ede7d00cb,
>> 32 bits
>>
>> The Media Driver fail some tests but this failures are coming
>> from code out of
>> scope of this series (imx-capture), and some from the sensor
>> OV2680
>> but that I think not related with the sensor driver but with
>> the testing and
>> core.
>>
>> The csi and mipi-csi entities pass all compliance tests.
>>
>> Cheers,
>> Rui
>>
>> v11->v12:
>> Sakari:
>> - check v4l2_ctrl_handler_free and init when exposed to
>> userspace
>> - check csi_remove missing v4l2_async_notifier_unregister
>> - media device unregister before ctrl_handler_free
>> - GPL => GPL v2
>> - Fix squash of CSI patches, issue on v11
>> - add Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>> 10--13
>> - mipi_s_stream check for ret < 0 and call
>> pm_runtime_put_noidle
>> - use __maybe_unused in pm functions
>> - Extra space before labels
>
> For patches 1, 2 and 4:
>
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Thanks for all your reviews, I did not add this before, because I
messed the patch order in v11.
---
Cheers,
Rui
next prev parent reply other threads:[~2019-02-05 11:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 12:00 [PATCH v12 00/13] media: staging/imx7: add i.MX7 media driver Rui Miguel Silva
2019-02-04 12:00 ` [PATCH v12 01/13] media: staging/imx: refactor imx media device probe Rui Miguel Silva
2019-02-04 12:00 ` [PATCH v12 02/13] media: staging/imx: rearrange group id to take in account IPU Rui Miguel Silva
2019-02-04 12:00 ` [PATCH v12 03/13] media: dt-bindings: add bindings for i.MX7 media driver Rui Miguel Silva
2019-02-04 12:00 ` [PATCH v12 04/13] media: staging/imx7: add imx7 CSI subdev driver Rui Miguel Silva
2019-02-04 12:00 ` [PATCH v12 05/13] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7 Rui Miguel Silva
2019-02-04 12:00 ` [PATCH v12 06/13] ARM: dts: imx7s: add mipi phy power domain Rui Miguel Silva
2019-02-04 12:00 ` [PATCH v12 07/13] ARM: dts: imx7s: add multiplexer controls Rui Miguel Silva
2019-02-04 12:00 ` [PATCH v12 08/13] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections Rui Miguel Silva
2019-02-04 12:00 ` [PATCH v12 09/13] ARM: dts: imx7s-warp: add ov2680 sensor node Rui Miguel Silva
2019-02-04 12:00 ` [PATCH v12 10/13] media: imx7.rst: add documentation for i.MX7 media driver Rui Miguel Silva
2019-02-04 12:00 ` [PATCH v12 11/13] media: staging/imx: add i.MX7 entries to TODO file Rui Miguel Silva
2019-02-04 12:00 ` [PATCH v12 12/13] media: video-mux: add bayer formats Rui Miguel Silva
2019-02-04 12:00 ` [PATCH v12 13/13] media: MAINTAINERS: add entry for Freescale i.MX7 media driver Rui Miguel Silva
2019-02-05 11:14 ` [PATCH v12 00/13] media: staging/imx7: add " Sakari Ailus
2019-02-05 11:53 ` Rui Miguel Silva [this message]
2019-02-05 12:28 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3y36u3108.fsf@linaro.org \
--to=rui.silva@linaro.org \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).