From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Schwab Subject: Re: [PATCH v9 0/2] PWM support for HiFive Unleashed Date: Mon, 18 Mar 2019 18:26:10 +0100 Message-ID: References: <1552378289-27245-1-git-send-email-yash.shah@sifive.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: (Yash Shah's message of "Fri, 15 Mar 2019 17:19:59 +0530") Sender: linux-kernel-owner@vger.kernel.org To: Yash Shah Cc: Palmer Dabbelt , linux-pwm@vger.kernel.org, linux-riscv@lists.infradead.org, Thierry Reding , robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sachin Ghadi , Paul Walmsley List-Id: devicetree@vger.kernel.org On Mär 15 2019, Yash Shah wrote: > You need to make sure the period setting is passed via the > conventional way in DT file. > Example: > pwmleds { > compatible = "pwm-leds"; > heartbeat { > pwms = <&L45 0 10000000 0>; > max-brightness = <255>; > linux,default-trigger = "heartbeat"; > }; > }; I've now managed to build a working FSBL with that change, but that didn't change anything. There is not even a heartbeat option in /sys/class/leds/heartbeat/trigger any more. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."