Re: [PATCH] [V2] gpio: New driver for LSI ZEVIO SoCs

["Fabian Vogt" <fabian@ritter-vogt.de>]

Hi,

>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/gpio/gpio-zevio.txt
>> @@ -0,0 +1,19 @@
>> +Zevio GPIO controller
>> +
>> +Required properties:
>> +- compatible = "lsi,zevio-gpio"
>> +- reg = <BASEADDR SIZE>
>> +- #gpio-cells = <2>
>> +- gpio-controller;
>> +
>> +Optional:
>> +- #ngpios = <32>: Number of GPIOs. Defaults to 32 if absent
>> +
>> +Example:
>> +	gpio: gpio@90000000 {
>> +		compatible = "lsi,zevio-gpio";
>> +		reg = <0x90000000 0x1000>;
>> +	
>
> <tab> here and I can't see the reason to have this blank line here.
>
>> +		gpio-controller;
>> +		#gpio-cells = <2>;
>> +	};
>> \ No newline at end of file
>
> Doesn't look right.
>
>> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
>> index b2450ba..ba8c357 100644
>> --- a/drivers/gpio/Kconfig
>> +++ b/drivers/gpio/Kconfig
>> @@ -138,6 +138,13 @@ config GPIO_EP93XX
>>  	depends on ARCH_EP93XX
>>  	select GPIO_GENERIC
>>
>> +config GPIO_ZEVIO
>> +	bool "LSI ZEVIO SoC memory mapped GPIOs"
>> +	depends on ARCH_NSPIRE
>> +	select GENERIC_IRQ_CHIP
>> +	help
>> +	  Say yes here to support the GPIO controller in LSI ZEVIO SoCs.
>> +
>
> Not sure how subsystem maintainer handle this but I would prefer
> to keep this sorted as it is done in Makefile.

Yes, but without the gpio-zevio.c file the Kconfig item and the Makefile
entry wouldn't work and vice-versa. The three latest patches which added  
GPIO
drivers weren't split as well.

>> --- a/drivers/gpio/Makefile
>> +++ b/drivers/gpio/Makefile
>> @@ -87,3 +87,4 @@ obj-$(CONFIG_GPIO_WM831X)	+= gpio-wm831x.o
>>  obj-$(CONFIG_GPIO_WM8350)	+= gpio-wm8350.o
>>  obj-$(CONFIG_GPIO_WM8994)	+= gpio-wm8994.o
>>  obj-$(CONFIG_GPIO_XILINX)	+= gpio-xilinx.o
>> +obj-$(CONFIG_GPIO_ZEVIO)	+= gpio-zevio.o
>> \ No newline at end of file
>
> ditto.
>
> The patch contains several trailing whitespace reported by checkpatch.pl
> which should be fixed.
Oh, I accidentially sent the uncleaned version of the patch, sorry.
I'll resend the cleaned version as V3.

Bye,
Fabian