From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Imre Kaloz" Subject: Re: [PATCH 1/4] ARM: dts: kirkwood: add Linksys EA4500 Date: Thu, 05 Nov 2015 12:03:03 +0100 Message-ID: References: <00000150d49a7cf7-e97bf540-89ce-49bf-a25e-2d082acab273-000000@email.amazonses.com> <3957044.Sz6eC5OsVr@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <3957044.Sz6eC5OsVr@wuerfel> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Arnd Bergmann Cc: gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Luka Perkov , jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org, andrew-g2DYL2Zd6BY@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, 04 Nov 2015 23:41:01 +0100, Arnd Bergmann wrote: > On Wednesday 04 November 2015 22:25:05 Luka Perkov wrote: >> +/ { >> + model = "Linksys EA4500"; >> + compatible = "linksys,ea4500", "marvell,kirkwood-88f6282", >> "marvell,kirkwood"; > > According to https://wikidevi.com/wiki/Linksys_EA4500 there are multiple > versions > of this device, and at least EA4500v3 is completely incompatible with > the version > in this patch. Should we add "linksys,ea4500v1" as a compatible string > to identify > this better? Not sure, as "v1" is never marked on the box/boards, and for this reason as far as I remember, we've never marked "v1" on any upstream code (unlike vX). Imre -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html