From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A68E9C433EF for ; Tue, 22 Mar 2022 13:21:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234161AbiCVNXK (ORCPT ); Tue, 22 Mar 2022 09:23:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233598AbiCVNXJ (ORCPT ); Tue, 22 Mar 2022 09:23:09 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F7ED6A028; Tue, 22 Mar 2022 06:21:41 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 38155210F2; Tue, 22 Mar 2022 13:21:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1647955300; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/JoKpF3z7MBf7QUqTBD9HK/zpIQn6GZC430lpurSEQE=; b=Lpojd85MpAWa8d96zqrpkuUkSMBsVsoOU/3Y9PCZwObRK3y6sXJdQNPvE7XVYoXqMTbsSx dL5j6FqY1UuD9sF+l5POI19rbb8wK96DuOXic3qp7GRfdI8PMynvvljcA4kxfDhNTEx+Cy yKr/rjmy+g7zr22CiyQ0WvtbnLSUkJk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1647955300; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/JoKpF3z7MBf7QUqTBD9HK/zpIQn6GZC430lpurSEQE=; b=2k+VsAoUglPEf/PakggrFswkcmMUhbN3+FFuUfaFhGtCr6u4VwqQmFz+AHZIzTl5aaI8fJ 0/6OUYyFNTH7iFAA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 20086A3B83; Tue, 22 Mar 2022 13:21:40 +0000 (UTC) Date: Tue, 22 Mar 2022 14:21:40 +0100 Message-ID: From: Takashi Iwai To: Lucas Tanure Cc: Liam Girdwood , Mark Brown , Rob Herring , Jaroslav Kysela , Takashi Iwai , , , , Subject: Re: [PATCH v4 00/16] Support external boost at CS35l41 ASoC driver In-Reply-To: <20220317093120.168534-1-tanureal@opensource.cirrus.com> References: <20220317093120.168534-1-tanureal@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 17 Mar 2022 10:31:04 +0100, Lucas Tanure wrote: > > Move the support for CS35L41 external boost to its shared library > for ASoC use. > This move resulted in cs35l41_hda_reg_sequence being removed, > and its steps were broken down into regmap writes or functions > from the library. And hardware configuration struct was unified > for its use in the shared lib. > While at it, some minor bugs were found and fixed it. > > v4 changelog: > - Separated GPIO 1 and 2 function enums > > v3 changelog: > - Remove patches already accepted > - Improved logic in documentation patch > - Documentation patch goes before its code > - Fixed missing Signed-off-by > - Fixed subject for HDA patches > > v2 changelog: > - Instead of removing the log, playback actions will log the last regmap access. > - Documentation patch with the correct subject line and fixed bug reported by Rob Herring on the > provided example. > > Previous versions: > v1: https://lkml.org/lkml/2022/3/3/759 > v2: https://lkml.org/lkml/2022/3/4/743 > v3: https://lkml.org/lkml/2022/3/8/975 > > David Rhodes (1): > ASoC: dt-bindings: cs35l41: Document CS35l41 External Boost > > Lucas Tanure (15): > sound: cs35l41: Unify hardware configuration > sound: cs35l41: Check hw_config before using it > sound: cs35l41: Move cs35l41_gpio_config to shared lib > ALSA: hda: cs35l41: Fix I2S params comments > ALSA: hda: cs35l41: Always configure the DAI > ALSA: hda: cs35l41: Add Boost type flag > hda: cs35l41: Put the device into safe mode for external boost > hda: cs35l41: Mute the device before shutdown > sound: cs35l41: Enable Internal Boost in shared lib > ALSA: hda: cs35l41: Move boost config to initialization code > ALSA: hda: cs35l41: Remove cs35l41_hda_reg_sequence struct > ALSA: hda: cs35l41: Reorganize log for playback actions > ALSA: hda: cs35l41: Handle all external boost setups the same way > ALSA: hda: cs35l41: Move external boost handling to lib for ASoC use > ASoC: cs35l41: Support external boost The code changes look OK (but for the issue Rob reported for dt-bindings stuff). But, could you try to use more consistent prefix for the subject lines? We don't use "sound:" prefix in general unless the patch is about (native) OSS drivers. Instead, use "ALSA:" for the general ALSA/ASoC patches. Also, "hda:" should be "ALSA: hda:" instead. thanks, Takashi