From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [alsa-devel] [PATCH] ASoC: pcm512x: Add PCM512x driver Date: Thu, 06 Feb 2014 14:12:48 +0100 Message-ID: References: <1391689575-4039-1-git-send-email-broonie@kernel.org> <20140206130735.GP32298@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20140206130735.GP32298-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: Florian Meier , Liam Girdwood , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org List-Id: devicetree@vger.kernel.org At Thu, 6 Feb 2014 13:07:35 +0000, Mark Brown wrote: > > On Thu, Feb 06, 2014 at 01:51:33PM +0100, Takashi Iwai wrote: > > Mark Brown wrote: > > > > +static const char *pcm512x_dsp_program_texts[] = { > > > The numbers of items in pcm512x_dsp_program_texts[] and _values[] > > don't match. > > Yeah, fixed. I'm thinking whether we can check this in the macro. I thought of using BUILD_BUG_ON(), but it's unsure whether it aligns there well. > > > +static const struct soc_enum pcm512x_clk_missing = > > > + SOC_ENUM_SINGLE(PCM512x_CLKDET, 0, 7, pcm512x_clk_missing_text); > > > Isn't it 8? > > Hrm, it is but this points out an error in the control helpers which has > been there since forever - they call that parameter max but it's not a > maximum, it's the number of elements in the enumeration. I bet we have > a bunch of other enumerations which miss the last element as a result. Yeah, the argument name is really confusing. I had to double-check the code when I reviewed your patch, too :) Also it'd be better to have a practice to use either ARRAY_SIZE() or a constant there, too. Takashi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html