From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 5/9] staging: bcm2835-audio: more generic probe function name Date: Tue, 16 Oct 2018 17:47:56 +0200 Message-ID: References: <20181016150228.16994-1-nsaenzjulienne@suse.de> <20181016150228.16994-6-nsaenzjulienne@suse.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20181016150228.16994-6-nsaenzjulienne@suse.de> Sender: linux-kernel-owner@vger.kernel.org To: Nicolas Saenz Julienne Cc: gregkh@linuxfoundation.org, eric@anholt.net, stefan.wahren@i2se.com, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, tiwai@suse.de List-Id: devicetree@vger.kernel.org On Tue, 16 Oct 2018 17:02:24 +0200, Nicolas Saenz Julienne wrote: > > There will only be one probe function, there is no use for appendig > "_dt" the end of the name. > > Signed-off-by: Nicolas Saenz Julienne > --- > drivers/staging/vc04_services/bcm2835-audio/bcm2835.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.c > index 6ee8334dfc81..039565311d10 100644 > --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.c > +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.c > @@ -291,7 +291,7 @@ static int snd_add_child_devices(struct device *device, u32 numchans) > return 0; > } > > -static int snd_bcm2835_alsa_probe_dt(struct platform_device *pdev) > +static int snd_bcm2835_alsa_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > u32 numchans; > @@ -344,7 +344,7 @@ static const struct of_device_id snd_bcm2835_of_match_table[] = { > MODULE_DEVICE_TABLE(of, snd_bcm2835_of_match_table); > > static struct platform_driver bcm2835_alsa0_driver = { Actually now I wonder why this "0" here... It has nothing to do with the patch, but it's a good opportunity to clean it up, too. thanks, Takashi