Re: [PATCH v4 11/13] dt-bindings: iio: adc: adi,ad4134: Document PWM usage

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing mutual exclusivity between pwms and odr-gpios
--

commit c1bcb33be57f5c8d53016ee21cdb73103ab97ef3
Author: Marcelo Schmitt <marcelo.schmitt@analog.com>

dt-bindings: iio: adc: adi,ad4134: Document PWM usage

This patch updates the AD4134 binding schema to document the use of a PWM
signal connected to the ODR pin for faster output data rates. It adds the
pwms property to the device tree bindings.

> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4134.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4134.yaml
> index c70b9113cd677..6a190b7a93114 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad4134.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4134.yaml
> @@ -104,6 +104,10 @@ properties:
>        GPIO connected to ODR pin. Used to sample ADC data in minimum I/O mode.
>      maxItems: 1
>  
> +  pwms:
> +    description: PWM signal connected to the ODR pin.
> +    maxItems: 1

[Severity: Low]
Does the schema allow specifying both pwms and odr-gpios simultaneously?

Since both properties describe a physical connection driving the exact
same ODR pin on the AD4134, specifying both in a device tree could result
in an invalid hardware state.

Should a oneOf or not constraint be added to the schema to enforce mutual
exclusivity between pwms and odr-gpios?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1791309733.git.marcelo.schmitt@analog.com?part=11