Re: [PATCH v3 4/8] cacheinfo: Expose the code to generate a cache-id from a device_node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] build: missing stub for cache_of_calculate_id() when !CONFIG_OF
--

commit e0883884c41c729d9be1bcb80b5f81d167e44a20
Author: James Morse <james.morse@arm.com>

cacheinfo: Expose the code to generate a cache-id from a device_node

The MPAM driver needs the cache-id during probe before cacheinfo is fully
setup by device_initcall(). This commit exposes the calculation code so early
driver parts can set up resctrl structures.

> diff --git a/include/linux/cacheinfo.h b/include/linux/cacheinfo.h
> index 56fa646df0d12..469d490968acb 100644
> --- a/include/linux/cacheinfo.h
> +++ b/include/linux/cacheinfo.h
> @@ -114,6 +114,7 @@ int acpi_get_cache_info(unsigned int cpu,
>  #endif
>  
>  const struct attribute_group *cache_get_priv_group(struct cacheinfo *this_leaf);
> +u32 cache_of_calculate_id(struct device_node *np);

[Severity: Low]
Does this declaration need a static inline stub for when CONFIG_OF is
disabled? 

The implementation of cache_of_calculate_id() in drivers/base/cacheinfo.c is
only compiled when CONFIG_OF is enabled. If a caller uses this function in a
configuration without CONFIG_OF, won't it cause a build failure during linking
due to an undefined reference?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261008-mpam-resctrl-dt-knp-support-v3-0-35196c2b43bf@oss.qualcomm.com?part=4