Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Radu Sabau" <radu.sabau@analog.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 2/6] dt-bindings: iio: imu: Add bindings for ADI ADIS16607
Date: Thu, 08 Oct 2026 08:37:19 +0000	[thread overview]
Message-ID: <sashiko-outbox-163845@kernel.org> (raw)
In-Reply-To: <20261008-adis16607-v2-2-7c94df80878a@analog.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: commit message claims nonexistent FIFO watermark property
--

commit 46f4e849c03631bf69981fbde007debcca23f628
Author: Radu Sabau <radu.sabau@analog.com>

dt-bindings: iio: imu: Add bindings for ADI ADIS16607

This commit adds device tree bindings for the Analog Devices ADIS16607
Precision MEMS Inertial Measurement Unit. It documents the supported
compatible variants, required SPI properties, and optional properties for
external clocks and reset GPIOs.

>     The binding exposes optional properties for:
>       - An external clock for sync mode (falling back to the internal 8 kHz
>         clock when absent)
>       - A hardware reset GPIO (active low)
>       - FIFO mode for buffered data acquisition with a configurable watermark

[Severity: Medium]
Is this commit message accurate?

The message claims the binding exposes optional properties for a
configurable FIFO watermark, but looking at the properties block in
Documentation/devicetree/bindings/iio/imu/adi,adis16607.yaml, no such
properties are defined.

Because unevaluatedProperties is set to false, if a developer attempts to
configure a FIFO watermark in their device tree node based on this commit
message, it will cause a schema validation failure during dt_binding_check.

Are FIFO watermarks managed dynamically via IIO sysfs rather than statically
in the device tree for this hardware?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261008-adis16607-v2-0-7c94df80878a@analog.com?part=2

  reply	other threads:[~2026-10-08  8:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-08  8:31 [PATCH v2 0/6] iio: imu: Add support for the ADI ADIS16607 Radu Sabau via B4 Relay
2026-10-08  8:31 ` [PATCH v2 1/6] iio: imu: adis: Add optional self_test callback and fix custom reset dispatch Radu Sabau via B4 Relay
2026-10-08  8:45   ` sashiko-bot
2026-10-08  8:31 ` [PATCH v2 2/6] dt-bindings: iio: imu: Add bindings for ADI ADIS16607 Radu Sabau via B4 Relay
2026-10-08  8:37   ` sashiko-bot [this message]
2026-10-08 10:14   ` Conor Dooley
2026-10-08  8:31 ` [PATCH v2 3/6] iio: imu: Add driver for the " Radu Sabau via B4 Relay
2026-10-08  8:31 ` [PATCH v2 4/6] iio: imu: adis16607: Add FIFO-based buffered/triggered capture Radu Sabau via B4 Relay
2026-10-08  8:45   ` sashiko-bot
2026-10-08  8:31 ` [PATCH v2 5/6] iio: imu: adis16607: Add external clock sync support Radu Sabau via B4 Relay
2026-10-08  8:42   ` sashiko-bot
2026-10-08  8:31 ` [PATCH v2 6/6] iio: imu: adis16607: Add calibration bias support for gyro/accel Radu Sabau via B4 Relay
2026-10-08  8:43   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-163845@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=radu.sabau@analog.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox