From: sashiko-bot@kernel.org
To: "Changhuang Liang" <changhuang.liang@starfivetech.com>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v6 2/2] hwmon: (starfive-pwm-fan) Add PWM fan driver for StarFive JHB100
Date: Thu, 08 Oct 2026 09:02:58 +0000 [thread overview]
Message-ID: <sashiko-outbox-163883@kernel.org> (raw)
In-Reply-To: <20261008071950.4772-3-changhuang.liang@starfivetech.com>
> Add PWM fan controller driver for StarFive JHB100 SoC.
>
> Fan speed is controlled through up to 8 PWM channels supplied by an
> external PWM controller and exposed as pwm[1-8], and one PWM channel can
> drive up to two fans. The tachometer block supports 16 independent
> inputs and reports fan speed in RPM through the hwmon sysfs interface,
> along with stall and low-speed alarms.
>
> For this controller, the special clock and reset operation sequence is:
> probe: clk_prepare_enable() then reset_control_deassert()
> remove: clk_disable_unprepare() then reset_control_assert()
>
> Co-developed-by: William Qiu <william.qiu@starfivetech.com>
> Signed-off-by: William Qiu <william.qiu@starfivetech.com>
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261008071950.4772-1-changhuang.liang@starfivetech.com?part=2
prev parent reply other threads:[~2026-10-08 9:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 7:19 [PATCH v6 0/2] Add JHB100 Fan-Tach support Changhuang Liang
2026-10-08 7:19 ` [PATCH v6 1/2] dt-bindings: hwmon: Add starfive,jhb100-pwm-fan Changhuang Liang
2026-10-08 8:57 ` sashiko-bot
2026-10-08 7:19 ` [PATCH v6 2/2] hwmon: (starfive-pwm-fan) Add PWM fan driver for StarFive JHB100 Changhuang Liang
2026-10-08 9:02 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-163883@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=changhuang.liang@starfivetech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox