Re: [PATCH v2 5/5] ASoC: qcom: sc8280xp: Add Nord sound card support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] ASoC: qcom: Codec internal enums hardcoded in machine driver
--

commit 2721d92879dd4f31b8adcd325b2322e0930198bc
Author: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
ASoC: qcom: sc8280xp: Add Nord sound card support

This commit adds support for the Nord Ride and RRD sound cards by
introducing the qcom,nord-sndcard compatible and associated
platform-specific data. It configures the codec DAI format for DSP_A
operation and enables MI2S bit clock handling. It also adds a
platform-specific sound card initialization callback to configure the
ADAU1979 capture codec to use LRCLK as its system clock source.

> diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c
> index b5d367486d56a..a759ae9511b6b 100644
> --- a/sound/soc/qcom/sc8280xp.c
> +++ b/sound/soc/qcom/sc8280xp.c
> @@ -25,6 +25,10 @@
>  #define I2S_BIT_RATE(rate, channels, format) \
>  	((rate) * (channels) * (format))
>  
> +#define ADAU1977_SYSCLK 0
> +#define ADAU1977_SYSCLK_SRC_MCLK 0
> +#define ADAU1977_SYSCLK_SRC_LRCLK 1

[Severity: Low]
Does duplicating these magic values from the codec driver create a brittle
dependency?

When nord_snd_init() passes these hardcoded macros to
snd_soc_component_set_sysclk(), it relies on the internal integer values of
the ADAU1977/ADAU1979 codec's clock definitions matching these definitions.
If the codec driver maintainers change the enum values, the machine driver
will silently configure the wrong clock and cause audio capture failures.

Could these identifiers be exposed through a shared header in include/sound/
instead of being duplicated in the machine driver?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261008-nord-asoc-driver-support-v2-v2-0-0b6f7e94060d@oss.qualcomm.com?part=5