Re: [PATCH 4/5] arm64: dts: qcom: nord: Add GPU cooling

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: missing cooling-device mappings for 4 GPU thermal zones
--

commit be1fe5e4df785d4f2fc715cc8d3e734547b71199
Author: Aastha Pandey <aastha.pandey@oss.qualcomm.com>

arm64: dts: qcom: nord: Add GPU cooling

This commit sets up GPU cooling on Nord by throttling the Adreno 753 GPU
when it reaches 105C. It labels the GPU thermal zones and their passive trip
points, maps them to the GPU as a cooling device, and adds polling delays.

> diff --git a/arch/arm64/boot/dts/qcom/nord-embedded.dtsi b/arch/arm64/boot/dts/qcom/nord-embedded.dtsi
> index 4379092b7bf8d..23370007c9748 100644
> --- a/arch/arm64/boot/dts/qcom/nord-embedded.dtsi
> +++ b/arch/arm64/boot/dts/qcom/nord-embedded.dtsi

[ ... ]

> +&gpuss_2_thermal {
> +	polling-delay-passive = <10>;
> +
> +	cooling-maps {
> +		map0 {
> +			trip = <&gpuss2_alert0>;
> +			cooling-device = <&gpu_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> +		};
> +	};
> +};

[Severity: Medium]
Are the cooling device mappings for the gpuss_1_0_thermal, gpuss_1_1_thermal,
gpuss_1_2_thermal, and gpu_1_0_thermal zones intentionally omitted from this
list?

If a sustained GPU workload creates hotspots near these unmapped sensors,
localized heating will not trigger GPU throttling. This could allow the SoC
to reach unsafe temperature thresholds and trigger a hardware shutdown
before the adjacent mapped sensors become hot enough to intervene.

These zones and their trip points are explicitly labeled in the nord.dtsi
changes below, which suggests they should have cooling maps defined alongside
the other zones.

> diff --git a/arch/arm64/boot/dts/qcom/nord.dtsi b/arch/arm64/boot/dts/qcom/nord.dtsi
> index 147d8e595a3a3..b032d1d2ad9b6 100644
> --- a/arch/arm64/boot/dts/qcom/nord.dtsi
> +++ b/arch/arm64/boot/dts/qcom/nord.dtsi

[ ... ]

> -		gpuss-1-0-thermal {
> +		gpuss_1_0_thermal: gpuss-1-0-thermal {
>  			polling-delay-passive = <0>;
>  			polling-delay = <0>;
>  			thermal-sensors = <&tsens6 5>;

[ ... ]

> -		gpuss-1-1-thermal {
> +		gpuss_1_1_thermal: gpuss-1-1-thermal {
>  			polling-delay-passive = <0>;
>  			polling-delay = <0>;
>  			thermal-sensors = <&tsens6 6>;

[ ... ]

> -		gpuss-1-2-thermal {
> +		gpuss_1_2_thermal: gpuss-1-2-thermal {
>  			polling-delay-passive = <0>;
>  			polling-delay = <0>;
>  			thermal-sensors = <&tsens7 5>;

[ ... ]

> -		gpu-1-0-thermal {
> +		gpu_1_0_thermal: gpu-1-0-thermal {
>  			polling-delay-passive = <0>;
>  			polling-delay = <0>;
>  			thermal-sensors = <&tsens7 6>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009-nord-gpu1-v1-0-a06a6c57bde7@oss.qualcomm.com?part=4