From: sashiko-bot@kernel.org
To: "Igor Velkov" <iav@iav.lv>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Add the front panel LEDs to Kobol Helios64
Date: Fri, 09 Oct 2026 00:44:39 +0000 [thread overview]
Message-ID: <sashiko-outbox-164681@kernel.org> (raw)
In-Reply-To: <20261009-helios64-leds-v1-1-6c58a66bf0c6@iav.lv>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: undocumented SATA activity led-9 addition
--
commit 3279f02d863433a09e5dbd918d375fd5550e3671
Author: Igor Velkov <iav@iav.lv>
arm64: dts: rockchip: Add the front panel LEDs to Kobol Helios64
This commit adds definitions for the front panel LEDs to the Kobol Helios64
device tree. It maps the network, USB, and five SATA error LEDs to their
respective GPIO pins based on the hardware schematic.
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> index d146e5075b4f8..25f0ba5a47ac6 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
[ ... ]
> @@ -120,6 +122,60 @@ led-1 {
[ ... ]
> + led-8 {
> + color = <LED_COLOR_ID_RED>;
> + function = LED_FUNCTION_DISK_ERR;
> + function-enumerator = <5>;
> + gpios = <&gpio2 RK_PA6 GPIO_ACTIVE_HIGH>;
> + };
> +
> + led-9 {
> + color = <LED_COLOR_ID_BLUE>;
> + function = LED_FUNCTION_DISK_ACTIVITY;
> + gpios = <&gpio4 RK_PD4 GPIO_ACTIVE_HIGH>;
> + default-state = "on";
> + };
> };
[Severity: Medium]
The commit message lists a total of 7 LEDs being added (one network, one USB,
and five SATA error LEDs). However, this code block adds an 8th LED for SATA
activity on gpio4 RK_PD4.
Was this SATA activity LED intended to be included in this patch, and if so,
could the commit message be updated to mention it?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261009-helios64-leds-v1-1-6c58a66bf0c6@iav.lv?part=1
next prev parent reply other threads:[~2026-10-09 0:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 0:40 [PATCH] arm64: dts: rockchip: Add the front panel LEDs to Kobol Helios64 Igor Velkov via B4 Relay
2026-10-09 0:44 ` sashiko-bot [this message]
2026-10-09 0:52 ` Igor Velkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-164681@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=iav@iav.lv \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox