Re: [PATCH v4 2/5] scsi: ufs: qcom: dt-bindings: Document Glymur UFS controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: ufs: missing corresponding QMP PHY binding for glymur
--

commit a93bc22aa0502f012705cac0afb0fdda1f1052cf
Author: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>

scsi: ufs: qcom: dt-bindings: Document Glymur UFS controller

This commit documents the UFS Host Controller on the Glymur SoC. It adds the
qcom,glymur-ufshc compatible string to the QCOM SM8650 UFS host controller
schema.

> diff --git a/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml b/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml
> index d03295806657f..f132b1a9ebc28 100644
> --- a/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml
> +++ b/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml
> @@ -16,6 +16,7 @@ select:
>        contains:
>          enum:
>            - qcom,eliza-ufshc
> +          - qcom,glymur-ufshc

[Severity: Low]
UFS hardware on Qualcomm SoCs requires both a host controller and a
corresponding QMP PHY.

This commit adds the host controller compatible string qcom,glymur-ufshc, and
a subsequent patch in this series introduces the PHY driver support for
qcom,glymur-qmp-ufs-phy in drivers/phy/qualcomm/phy-qcom-qmp-ufs.c.

However, does this series also need to add qcom,glymur-qmp-ufs-phy to the PHY
device tree bindings? As it stands, device tree authors cannot validly declare
the PHY node for the Glymur SoC without failing schema validation.

>            - qcom,hawi-ufshc
>            - qcom,kaanapali-ufshc

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009-glymur_ufs_qcb_enablement-v4-0-9a6ce83195b7@oss.qualcomm.com?part=2