From: sashiko-bot@kernel.org
To: "Linus Walleij" <linusw@kernel.org>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: power: Convert Ux500 PM domains to schema
Date: Fri, 09 Oct 2026 12:23:20 +0000 [thread overview]
Message-ID: <sashiko-outbox-165529@kernel.org> (raw)
In-Reply-To: <20261009-ux500-power-domains-v7-3-rc1-redux-v1-1-5eb1b90bc35e@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: node name pm_domains0 violates generic power-domain.yaml pattern
--
commit e036f4f6150d2ad689c2435137c3f93e75ad275c
Author: Linus Walleij <linusw@kernel.org>
Subject: dt-bindings: power: Convert Ux500 PM domains to schema
Convert the legacy Ux500 power domain text binding to YAML. Move it under
bindings/power. Reference the generic power-domain schema.
> diff --git a/Documentation/devicetree/bindings/power/stericsson,ux500-pm-domains.yaml b/Documentation/devicetree/bindings/power/stericsson,ux500-pm-domains.yaml
> new file mode 100644
> index 0000000000000..bf83ce3326746
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/stericsson,ux500-pm-domains.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
[ ... ]
> +allOf:
> + - $ref: power-domain.yaml#
> +
[Severity: Low]
Does referencing the generic power-domain.yaml cause dtbs_check to fail for
existing device trees?
By referencing the generic power-domain schema, this binding strictly enforces
its node name pattern:
^(power-controller|power-domain|performance-domain)([@-].*)?$
However, the existing device tree node in arch/arm/boot/dts/st/ste-dbx5x0.dtsi
is named pm_domains0:
pm_domains: pm_domains0 {
compatible = "stericsson,ux500-pm-domains";
#power-domain-cells = <1>;
};
While the example below was updated to power-controller to pass local
dt_binding_check, the corresponding .dtsi file was omitted from this patch.
Should the .dtsi file be updated in this series to prevent a lingering
dtbs_check validation regression?
[ ... ]
> +examples:
> + - |
> + #include <dt-bindings/arm/ux500_pm_domains.h>
> +
> + pm_domains: power-controller {
> + compatible = "stericsson,ux500-pm-domains";
> + #power-domain-cells = <1>;
> + };
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261009-ux500-power-domains-v7-3-rc1-redux-v1-0-5eb1b90bc35e@kernel.org?part=1
next prev parent reply other threads:[~2026-10-09 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 12:15 [PATCH 0/3] pmdomain: Basic DT defines for ux500 power domains Linus Walleij
2026-10-09 12:15 ` [PATCH 1/3] dt-bindings: power: Convert Ux500 PM domains to schema Linus Walleij
2026-10-09 12:23 ` sashiko-bot [this message]
2026-10-09 12:15 ` [PATCH 2/3] dt-bindings: arm: ux500: Drop NR_DOMAINS Linus Walleij
2026-10-09 12:15 ` [PATCH 3/3] dt-bindings: arm: Add the actual power domains on U8500 Linus Walleij
2026-10-09 14:33 ` [PATCH 0/3] pmdomain: Basic DT defines for ux500 power domains Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-165529@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linusw@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox