Re: [PATCH v3 3/7] ASoC: codec: pcm1681: Add TDM support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] ASoC: missing regmap_update_bits error check in pcm1681_set_deemph()
--

commit c7cf94fd54a2248eb129e6005f0299fa2844892f
Author: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>

ASoC: codec: pcm1681: Add TDM support

The PCM1681 selects the audio interface format using FMT[3:0] in the format
register. This commit adds support for SND_SOC_DAIFMT_DSP_A and programs the
PCM1681 I2S TDM format when it is selected. It also corrects the reset
default for the format register to match the hardware reset value.

> diff --git a/sound/soc/codecs/pcm1681.c b/sound/soc/codecs/pcm1681.c
> index a1ccf1edf4819..3675b2236d663 100644
> --- a/sound/soc/codecs/pcm1681.c
> +++ b/sound/soc/codecs/pcm1681.c

[ ... ]

> @@ -217,6 +217,9 @@ static int pcm1681_hw_params(struct snd_pcm_substream *substream,
>  	case SND_SOC_DAIFMT_LEFT_J:
>  		val = 0x05;
>  		break;
> +	case SND_SOC_DAIFMT_DSP_A:
> +		val = 0x06;
> +		break;
>  	default:
>  		dev_err(component->dev, "Invalid DAI format\n");
>  		return -EINVAL;

[Severity: Low]
Does this code ignore the return value of the first regmap_update_bits() call
in pcm1681_set_deemph()?

When pcm1681_hw_params() finishes successfully, it calls pcm1681_set_deemph():

sound/soc/codecs/pcm1681.c:pcm1681_set_deemph() {
    ...
	if (val != -1) {
		regmap_update_bits(priv->regmap, PCM1681_DEEMPH_CONTROL,
				   PCM1681_DEEMPH_RATE_MASK, val << 3);
		enable = 1;
	} else {
    ...
}

If the first register update to set the de-emphasis rate fails due to a
transient bus error, its return value is ignored before executing the
subsequent update.

If the subsequent transaction to enable it succeeds, the codec will have
de-emphasis enabled with an incorrect or default rate, potentially causing
minor audio distortion.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009-nord-asoc-driver-support-v3-v3-0-0c1897f21ccf@oss.qualcomm.com?part=3