Re: [PATCH v5 09/13] ARM: dts: imx6ul: Extend Variscite carrier board descriptions

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: Missing vmmc-supply property in &usdhc1 leaving reg_sd1_vmmc unused
--

commit f482087d41ff9ef7afd90e49e664cce4877e9d8e
Author: Stefano Radaelli <stefano.r@variscite.com>

ARM: dts: imx6ul: Extend Variscite carrier board descriptions

This patch adds and extends several carrier board descriptions for Variscite
boards, including the introduction of the Symphony and VAR-6ULCustomBoard
device tree files. It also refactors common pin groups and peripheral
configurations into shared components.

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-dart-6ulcustomboard-sd-card.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-dart-6ulcustomboard-sd-card.dtsi
> new file mode 100644
> index 0000000000000..f6cec58f5a4e4
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-dart-6ulcustomboard-sd-card.dtsi
> @@ -0,0 +1,31 @@
[ ... ]
> +/ {
> +	reg_sd1_vmmc: regulator-sd1-vmmc {
> +		compatible = "regulator-fixed";
> +		regulator-name = "VSD_3V3";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +	};
> +};
> +
> +&usdhc1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_usdhc1>, <&pinctrl_usdhc1_gpio>;
> +	cd-gpios = <&gpio4 19 GPIO_ACTIVE_LOW>;
> +	no-1-8-v;
> +	keep-power-in-suspend;
> +	wakeup-source;
> +	status = "okay";
> +};

[Severity: Low]
Should the usdhc1 node include a vmmc-supply property referencing the
reg_sd1_vmmc regulator defined just above? The regulator is declared here but
appears to be left unused, which might prevent the SD card from being powered
correctly if the MMC subsystem relies on this supply link.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1791487179.git.stefano.r@variscite.com?part=9